Re: [Intel-wired-lan] [PATCH iwl-net 1/3] idpf: fix memory leaks and crashes while performing a soft reset

2024-08-01 Thread Singh, Krishneil K
> -Original Message- > From: Simon Horman > Sent: Tuesday, July 30, 2024 9:37 AM > To: Lobakin, Aleksander > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; David S. Miller ; Eric > Dumazet ; Jakub Kicinski ; Paolo > Abeni ; NEX SW NCIS OSDT ITP Upstreaming > ; net...@vger.ker

Re: [Intel-wired-lan] [PATCH iwl-net 1/3] idpf: fix memory leaks and crashes while performing a soft reset

2024-07-30 Thread Simon Horman
On Mon, Jul 29, 2024 at 10:54:50AM +0200, Alexander Lobakin wrote: > From: Simon Horman > Date: Fri, 26 Jul 2024 17:09:54 +0100 > > > On Wed, Jul 24, 2024 at 03:40:22PM +0200, Alexander Lobakin wrote: > >> The second tagged commit introduced a UAF, as it removed restoring > >> q_vector->vport poi

Re: [Intel-wired-lan] [PATCH iwl-net 1/3] idpf: fix memory leaks and crashes while performing a soft reset

2024-07-30 Thread Simon Horman
On Mon, Jul 29, 2024 at 10:54:50AM +0200, Alexander Lobakin wrote: > From: Simon Horman > Date: Fri, 26 Jul 2024 17:09:54 +0100 > > > On Wed, Jul 24, 2024 at 03:40:22PM +0200, Alexander Lobakin wrote: > >> The second tagged commit introduced a UAF, as it removed restoring > >> q_vector->vport poi

Re: [Intel-wired-lan] [PATCH iwl-net 1/3] idpf: fix memory leaks and crashes while performing a soft reset

2024-07-29 Thread Alexander Lobakin
From: Simon Horman Date: Fri, 26 Jul 2024 17:09:54 +0100 > On Wed, Jul 24, 2024 at 03:40:22PM +0200, Alexander Lobakin wrote: >> The second tagged commit introduced a UAF, as it removed restoring >> q_vector->vport pointers after reinitializating the structures. >> This is due to that all queue a

Re: [Intel-wired-lan] [PATCH iwl-net 1/3] idpf: fix memory leaks and crashes while performing a soft reset

2024-07-26 Thread Simon Horman
On Wed, Jul 24, 2024 at 03:40:22PM +0200, Alexander Lobakin wrote: > The second tagged commit introduced a UAF, as it removed restoring > q_vector->vport pointers after reinitializating the structures. > This is due to that all queue allocation functions are performed here > with the new temporary

[Intel-wired-lan] [PATCH iwl-net 1/3] idpf: fix memory leaks and crashes while performing a soft reset

2024-07-24 Thread Alexander Lobakin
The second tagged commit introduced a UAF, as it removed restoring q_vector->vport pointers after reinitializating the structures. This is due to that all queue allocation functions are performed here with the new temporary vport structure and those functions rewrite the backpointers to the vport.