Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2024 15:00:52 +0200 Alexander Lobakin wrote: > > Technically, neither ART nor TSC are directly related to the PTP cross > > timestamp. It's just the implementation on Intel NICs, where those > > NICs use x86 ART to crosstimestamp. > > > > For cross timestamp on ARM, it's also HW spec

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-08-08 Thread Alexander Lobakin
From: Kolacinski, Karol Date: Wed, 7 Aug 2024 16:26:29 +0200 > From: Aleksander Lobakin > Date: Wed, 07 Aug 2024 15:54 +0200 > +static void ice_ptp_set_funcs_e830(struct ice_pf *pf) > +{ > +#ifdef CONFIG_ICE_HWTS > + if (pcie_ptm_enabled(pf->pdev) && > + boot_cpu_

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-08-07 Thread Kolacinski, Karol
From: Aleksander Lobakin Date: Wed, 07 Aug 2024 15:54 +0200 +static void ice_ptp_set_funcs_e830(struct ice_pf *pf) +{ +#ifdef CONFIG_ICE_HWTS + if (pcie_ptm_enabled(pf->pdev) && + boot_cpu_has(X86_FEATURE_ART) && + boot_cpu_has(X86_FEATURE_TSC_KNOW

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-08-07 Thread Alexander Lobakin
From: Kolacinski, Karol Date: Mon, 5 Aug 2024 18:21:39 +0200 > From: Aleksander Lobakin > Date: Fri, 26 Jul 2024 15:37 +0200 >>> +/** >>> + * ice_ptp_set_funcs_e830 - Set specialized functions for E830 support >>> + * @pf: Board private structure >>> + * >>> + * Assign functions to the PTP capab

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-08-05 Thread Kolacinski, Karol
From: Aleksander Lobakin Date: Fri, 26 Jul 2024 15:37 +0200 > > +/** > > + * ice_ptp_set_funcs_e830 - Set specialized functions for E830 support > > + * @pf: Board private structure > > + * > > + * Assign functions to the PTP capabiltiies structure for E830 devices. > > + * Functions which operate

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-26 Thread Jacob Keller
On 7/26/2024 6:37 AM, Alexander Lobakin wrote: >> diff --git a/drivers/net/ethernet/intel/ice/ice_osdep.h >> b/drivers/net/ethernet/intel/ice/ice_osdep.h >> index a2562f04267f..c03ab0207e0a 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_osdep.h >> +++ b/drivers/net/ethernet/intel/ice/ice_os

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-26 Thread Alexander Lobakin
From: Karol Kolacinski Date: Thu, 25 Jul 2024 11:34:51 +0200 > From: Jacob Keller > > The E830 and E82x devices use essentially the same logic for performing > a crosstimestamp. The only difference is that E830 hardware has > different offsets. Instead of having two implementations, combine the

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-25 Thread Jacob Keller
On 7/25/2024 2:34 AM, Karol Kolacinski wrote: > From: Jacob Keller > > The E830 and E82x devices use essentially the same logic for performing > a crosstimestamp. The only difference is that E830 hardware has > different offsets. Instead of having two implementations, combine them > into a sin

[Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-25 Thread Karol Kolacinski
From: Jacob Keller The E830 and E82x devices use essentially the same logic for performing a crosstimestamp. The only difference is that E830 hardware has different offsets. Instead of having two implementations, combine them into a single ice_capture_crosststamp() function. Also combine the wra