On 10/25/2023 5:20 AM, Jiri Pirko wrote:
> Wed, Oct 25, 2023 at 02:16:39PM CEST, j...@resnulli.us wrote:
>> Wed, Oct 25, 2023 at 12:48:37PM CEST, wojciech.dre...@intel.com wrote:
>>>
>>>
>>> On 25.10.2023 12:33, Ivan Vecera wrote:
The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
On Wed, 2023-10-25 at 23:40 +, Justin Stitt wrote:
> This patch converts some basic cases of ethtool_sprintf() to
> ethtool_puts().
>
> The conversions are used in cases where ethtool_sprintf() was being used
> with just two arguments:
> > ethtool_sprintf(, buffer[i].name);
OK.
> or
On Wed, 2023-10-25 at 23:40 +, Justin Stitt wrote:
> Add some warnings for using ethtool_sprintf() where a simple
> ethtool_puts() would suffice.
>
> The two cases are:
>
> 1) Use ethtool_sprintf() with just two arguments:
> > ethtool_sprintf(, driver[i].name);
OK.
> or
> 2) Use
> -Original Message-
> From: Intel-wired-lan On Behalf Of Paul
> Greenwalt
> Sent: Wednesday, October 18, 2023 4:17 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: and...@lunn.ch; Greenwalt, Paul ; Nowlin, Dan
> ; net...@vger.kernel.org; Chmielewski, Pawel
> ; Nguyen, Anthony L
> ;
> -Original Message-
> From: Intel-wired-lan On Behalf Of Paul
> Greenwalt
> Sent: Wednesday, October 18, 2023 4:17 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: and...@lunn.ch; Michael, Alice ; Greenwalt, Paul
> ; net...@vger.kernel.org; Chmielewski, Pawel
> ; Nguyen, Anthony L
> ;
> -Original Message-
> From: Intel-wired-lan On Behalf Of Paul
> Greenwalt
> Sent: Wednesday, October 18, 2023 4:17 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: and...@lunn.ch; Greenwalt, Paul ;
> net...@vger.kernel.org; Brandeburg, Jesse ;
> Chmielewski, Pawel ; Nguyen, Anthony L
> ;
> -Original Message-
> From: Intel-wired-lan On Behalf Of Paul
> Greenwalt
> Sent: Wednesday, October 18, 2023 4:17 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nowlin, Dan ; Greenwalt, Paul
> ; and...@lunn.ch; net...@vger.kernel.org;
> Brandeburg, Jesse ; Nguyen, Anthony L
> ;
> -Original Message-
> From: Intel-wired-lan On Behalf Of Paul
> Greenwalt
> Sent: Wednesday, October 18, 2023 4:17 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: and...@lunn.ch; Greenwalt, Paul ;
> net...@vger.kernel.org; Brandeburg, Jesse ;
> Chmielewski, Pawel ; Nguyen, Anthony L
> ;
> -Original Message-
> From: Intel-wired-lan On Behalf Of Paul
> Greenwalt
> Sent: Wednesday, October 18, 2023 4:17 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: and...@lunn.ch; Greenwalt, Paul ;
> net...@vger.kernel.org; Brandeburg, Jesse ;
> Chmielewski, Pawel ; Nguyen, Anthony L
> ;
allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20231025 gcc
arm allmodconfig gcc
arm allnoconfig
On 10/25/2023 5:27 AM, Wojciech Drewek wrote:
>
>
> On 25.10.2023 14:20, Jiri Pirko wrote:
>> Wed, Oct 25, 2023 at 02:16:39PM CEST, j...@resnulli.us wrote:
>>> Wed, Oct 25, 2023 at 12:48:37PM CEST, wojciech.dre...@intel.com wrote:
On 25.10.2023 12:33, Ivan Vecera wrote:
>
On 10/25/2023 7:39 AM, Ivan Vecera wrote:
>
>
> On 25. 10. 23 12:48, Wojciech Drewek wrote:
>>
>> On 25.10.2023 12:33, Ivan Vecera wrote:
>>> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
>>> I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify
>>> i40e_adminq_init_regs() and
On Thu, Oct 19, 2023 at 03:53:42PM +0200, Ivan Vecera wrote:
> The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one.
>
> Fixes: 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature
> for X722")
> Signed-off-by: Ivan Vecera
Thanks,
I agree that
Removed fields:
.fc_autoneg_status
Since commit c56999f94876 ("i40e/i40evf: Add set_fc and init of
FC settings") write-only and otherwise unused
.eeprom_version
Write-only and otherwise unused
.atr_sample_rate
Has only one possible value (I40E_DEFAULT_ATR_SAMPLE_RATE). Remove
On 25. 10. 23 13:03, Wojciech Drewek wrote:
On 25.10.2023 12:59, Ivan Vecera wrote:
From commit 9eed69a9147c ("i40e: Drop FCoE code from core driver files")
the field i40e_mac_info.san_addr is unused (never filled).
The field i40e_mac_info.max_fcoeq is unused from the beginning.
Remove
>From commit 9eed69a9147c ("i40e: Drop FCoE code from core driver files")
the field i40e_mac_info.san_addr is unused (never filled).
The field i40e_mac_info.max_fcoeq is unused from the beginning.
Remove both.
Reviewed-by: Wojciech Drewek
Co-developed-by: Michal Schmidt
Signed-off-by: Michal
When adding a drop rule on a VF, rule direction is not being set, which
results in it always being set to ingress (ICE_ESWITCH_FLTR_INGRESS
equals 0). Because of this, drop rules added on port representors don't
match any packets.
To fix it, set rule direction in drop action to egress when netdev
allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
archsdk_defconfig gcc
arc randconfig-001-20231024 gcc
arc randconfig-001-20231025 gcc
On 25. 10. 23 12:48, Wojciech Drewek wrote:
On 25.10.2023 12:33, Ivan Vecera wrote:
The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify
i40e_adminq_init_regs() and remove enums for these VF MAC types.
Signed-off-by: Ivan Vecera
On 25.10.2023 14:20, Jiri Pirko wrote:
> Wed, Oct 25, 2023 at 02:16:39PM CEST, j...@resnulli.us wrote:
>> Wed, Oct 25, 2023 at 12:48:37PM CEST, wojciech.dre...@intel.com wrote:
>>>
>>>
>>> On 25.10.2023 12:33, Ivan Vecera wrote:
The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
Wed, Oct 25, 2023 at 02:16:39PM CEST, j...@resnulli.us wrote:
>Wed, Oct 25, 2023 at 12:48:37PM CEST, wojciech.dre...@intel.com wrote:
>>
>>
>>On 25.10.2023 12:33, Ivan Vecera wrote:
>>> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
>>> I40E_MAC_X722_VF so remove helper i40e_is_vf(),
Wed, Oct 25, 2023 at 12:48:37PM CEST, wojciech.dre...@intel.com wrote:
>
>
>On 25.10.2023 12:33, Ivan Vecera wrote:
>> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
>> I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify
>> i40e_adminq_init_regs() and remove enums for these VF MAC
From: Jacob Keller
The ice driver currently attempts to destroy and re-initialize the Tx
timestamp tracker during the reset flow. The release of the Tx tracker
only happened during CORE reset or GLOBAL reset. The ice_ptp_rebuild()
function always calls the ice_ptp_init_tx function which will
From: Jacob Keller
The driver calls ice_ptp_cfg_timestamp() during
ice_ptp_prepare_for_reset() to disable timestamping while the device is
resetting. It then attempts to restore timestamp configuration at the
end of ice_rebuild(). However, it currently forcibly calls
ice_ptp_cfg_timestamp() with
From: Jacob Keller
The driver stores the current Tx and Rx timestamping configuration in
pf->ptp.tstamp_config. This structure is supposed to represent the
currently requested configuration from userspace that we've applied to
the device.
The values of this structure are modified within the low
From: Jacob Keller
Before performing a Tx timestamp in ice_stamp(), the driver checks
a ptp_tx ring variable to see if timestamping is enabled on that ring.
This value is set for all rings whenever userspace configures Tx
timestamping.
Ostensibly this was done to avoid wasting cycles checking
From: Jacob Keller
The ice_ptp_reset() function uses a goto to skip past clock owner
operations if performing a PF reset or if the device is not the clock
owner. This is a bit confusing. Factor this out into
ice_ptp_rebuild_owner() instead.
The ice_ptp_reset() function is called by
From: Jacob Keller
The ice_ptp_tx_cfg_intr() function sends a control queue message to
configure the PHY timestamp interrupt block. This is a very similar name
to a function which is used to configure the MAC Other Interrupt Cause
Enable register.
Rename this function to
From: Jacob Keller
The ice_ptp_configure_tx_tstamp function writes to PFINT_OICR_ENA to
configure it with the PFINT_OICR_TX_TSYN_M bit. The name of this
function is confusing because there are multiple other functions with
almost identical names.
Rename it to ice_ptp_cfg_tx_interrupt in order
From: Jacob Keller
The tx->verify_cached flag is used to inform the Tx timestamp tracking
code whether it needs to verify the cached Tx timestamp value against
a previous captured value. This is necessary on E810 hardware which does
not have a Tx timestamp ready bitmap.
In addition, we
From: Jacob Keller
The ice_ptp_prepare_for_reset() and ice_ptp_reset() functions currently
check the pf->flags ICE_FLAG_PFR_REQ bit to determine if the current
reset is a PF reset or not.
This is problematic, because it is possible that a PF reset and a higher
level reset (CORE reset, GLOBAL
Add PTP state machine so that the driver can correctly identify PTP
state around resets.
When the driver got information about ungraceful reset, PTP was not
prepared for reset and it returned error. When this situation occurs,
prepare PTP before rebuilding its structures.
Signed-off-by: Jacob
PTP reset process has multiple places where timestamping can end up in
an incorrect state.
This series introduces a proper state machine for PTP and refactors
a large part of the code to ensure that timestamping does not break.
Jacob Keller (9):
ice: pass reset type to PTP reset functions
On 25.10.2023 12:59, Ivan Vecera wrote:
> From commit 9eed69a9147c ("i40e: Drop FCoE code from core driver files")
> the field i40e_mac_info.san_addr is unused (never filled).
> The field i40e_mac_info.max_fcoeq is unused from the beginning.
> Remove both.
>
> Co-developed-by: Michal Schmidt
On 25.10.2023 12:33, Ivan Vecera wrote:
> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
> I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify
> i40e_adminq_init_regs() and remove enums for these VF MAC types.
>
> Signed-off-by: Ivan Vecera
> ---
>
On 25.10.2023 12:33, Ivan Vecera wrote:
> Move version check helper functions from i40e_type.h to
> i40e_prototype.h as per discussion [1].
>
> [1]
> https://lore.kernel.org/all/cdcd6b97-1138-4cd7-854f-b3faa1f47...@intel.com/#t
>
> Cc: Wojciech Drewek
> Cc: Jacob Keller
> Signed-off-by:
The series removes MAC types for VF functions and moves inline helper
functions from i40e_type.h to i40e_prototype.h
Ivan Vecera (2):
i40e: Remove VF MAC types
i40e: Move inline helpers to i40e_prototype.h
drivers/net/ethernet/intel/i40e/i40e_adminq.c | 33 +++-
Move version check helper functions from i40e_type.h to
i40e_prototype.h as per discussion [1].
[1]
https://lore.kernel.org/all/cdcd6b97-1138-4cd7-854f-b3faa1f47...@intel.com/#t
Cc: Wojciech Drewek
Cc: Jacob Keller
Signed-off-by: Ivan Vecera
---
.../net/ethernet/intel/i40e/i40e_prototype.h
The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify
i40e_adminq_init_regs() and remove enums for these VF MAC types.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/intel/i40e/i40e_adminq.c | 33 ++-
39 matches
Mail list logo
