Re: [Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-12 Thread Bo Thorsen
Den 08-03-2015 kl. 11:58 skrev Guido Seifert: > I am just curious. In one of my old projects I replaced all SIGNAL/SLOT > connections with the newer function pointer api. > In theory I now could remove all the 'public/protected/private slot' markers > from my .h files. Now I am wondering, if this

Re: [Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-11 Thread Guido Seifert
> Hi Guido, Hi back :-) > I think the main disadvantage in this is that it would surprise Qt > developers. There is knowledge in you writing "slots" in the .h file, > just like there is in using emit. Yes, but if there was a compelling reason not to use 'slots' I would mark my slots, but co

Re: [Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-09 Thread hualet
Oh, I replied immediately when I saw the question, haven’t read other answers which I should’ve read before I send to the list. Sorry for that, Guido and the list. ___ Interest mailing list Interest@qt-project.org http://lists.qt-project.org/mailman/lis

Re: [Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-09 Thread Guido Seifert
How does it help? I know the new syntax very well. I was interested in an implementation detail. If there are advantages/disadvantages (speed/size) besides the obvious, e.g. compile time tests. Or if there is a difference if or if not the slots macros are used even though the function pointer ap

Re: [Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-09 Thread hualet
This official post may help http://qt-project.org/wiki/New_Signal_Slot_Syntax ___ Interest mailing list Interest@qt-project.org http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-08 Thread Thiago Macieira
On Sunday 08 March 2015 14:28:55 Constantin Makshin wrote: > 1) less code and data -> smaller executable; That might not be true. Assuming you replaced a private slot declaration with just a member function connection, there should be only minimal benefit in code size (only the moc tables and m

Re: [Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-08 Thread Giuseppe D'Angelo
Il 08/03/2015 12:28, Constantin Makshin ha scritto: Both advantages and disadvantages will come from the fact that MOC won't generate anything for methods in these sections. There's an extra pro that comes with that: visibility markers actually come into play. A slot is always publicly invok

Re: [Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-08 Thread Constantin Makshin
Both advantages and disadvantages will come from the fact that MOC won't generate anything for methods in these sections. Pros: 1) less code and data -> smaller executable; 2) less code -> faster compilation; 3) smaller "MOC table" -> faster lookups when connecting and/or processing signals. Cons

[Interest] Does removing 'private slots' from .h files have any advantages? Disadvantages?

2015-03-08 Thread Guido Seifert
Hi, I am just curious. In one of my old projects I replaced all SIGNAL/SLOT connections with the newer function pointer api. In theory I now could remove all the 'public/protected/private slot' markers from my .h files. Now I am wondering, if this is only cosmetic, or does it have any advantages/