Re: [PHP-DEV] Re: crash in sqlite_oo/spl

2004-02-25 Thread Marcus Boerger
Hello Ard, Wednesday, February 25, 2004, 1:53:18 AM, you wrote: > Marcus Boerger wrote: >> Hello Ard, >> >> on the first sight it looks pretty much as if you havn't updated your build >> tree completley. Please check that ext/spl, ext/sqlite and Zend are up to >> date. Because for me it works p

Re: [PHP-DEV] Suggestions for Reflection API

2004-02-25 Thread Marcus Boerger
Hello Sebastian, Wednesday, February 25, 2004, 8:55:54 AM, you wrote: > Hi, > I just looked for the first time in months at the Reflection API and > have two suggestions: > 1.) There are a couple of methods that throw an Exception. > I think it would be better to introduce a

Re: [PHP-DEV] Suggestions for Reflection API

2004-02-25 Thread Sebastian Bergmann
Marcus Boerger wrote: > Have a better look :-) Ah, I only looked at the prototypes. -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ Das Buch zu PHP 5: http://professionelle-softwareentwicklung-mit-php5.de/ -- PHP Internals - PHP Runtime Develo

Re: [PHP-DEV] Re: crash in sqlite_oo/spl

2004-02-25 Thread Ard Biesheuvel
Thanks, this why i had a SEGV too. And i found a problem in the way the engine destructs and frees objects during shutdown. Please try again it should be fixed right now. It works now. -- Ard -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.ph

[PHP-DEV] [Fwd: PATCH: operator precedence test and some wordsize stuff]

2004-02-25 Thread Ard Biesheuvel
Wrong list, sorry Original Message Subject: PATCH: operator precedence test and some wordsize stuff Date: Wed, 25 Feb 2004 12:03:27 +0100 From: [EMAIL PROTECTED] (Ard Biesheuvel) To: [EMAIL PROTECTED] Newsgroups: php.zend-engine.cvs Followup-To: php.dev -- Ard Index: Zend/zend_co

[PHP-DEV] Fix for bug #21760

2004-02-25 Thread David Eriksson
Hi! Would anyone mind to commit the attached one-line fix for bug #21760? I don't have commit access to the sockets extension. http://bugs.php.net/bug.php?id=21760 -- Regards, -\- David Eriksson -/- Developer of the Universe PHP extension for CORBA access. Index: ext/sockets/sockets.c =

Re: [PHP-DEV] Suggestions for Reflection API

2004-02-25 Thread Greg Beaver
Hi Marcus, @version has been a valid tag in phpDocumentor since version 0.1 :). The problem on pear-dev is that when a BC-breaking bugfix release occur, and there is a program that has coded a hack around the bug that was fixed. I don't think this needs to be a language feature ($__version),

[PHP-DEV] CVS Account Request: rich_y

2004-02-25 Thread Richard York
To maintain docs for PEAR package Mail_IMAP and possibly to maintain the code for Mail_IMAP. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] segfault with iterators

2004-02-25 Thread Andi Gutmans
This should be fixed now. Thanks for the reproducing case. Andi At 20:20 17/02/2004 +0100, Pierre-Alain Joye wrote: Segfault: } $obj = new Test(); foreach ($obj->c()->a as $value) { // Segafults print "Test\n"; } ?> -- PHP Internals - PHP Runtime Development Mailing List To unsubscri

Fwd: [PHP-DEV] RC1

2004-02-25 Thread Andi Gutmans
Quick reminder... If you have any bugs to fix, please fix them in the coming days. Andi Date: Thu, 12 Feb 2004 21:59:24 +0200 To: [EMAIL PROTECTED] From: Andi Gutmans <[EMAIL PROTECTED]> Subject: [PHP-DEV] RC1 Hey, Now Beta 4 is out of the door I think March 1st is a realistic date to get RC1 ou

Re: [PHP-DEV] segfault with iterators

2004-02-25 Thread Jani Taskinen
Was there a test for this..? Would be nice if Pierre/Andi would add one if not. :) --Jani On Wed, 25 Feb 2004, Andi Gutmans wrote: >This should be fixed now. >Thanks for the reproducing case. > >Andi > >At 20:20 17/02/2004 +0100, Pierre-Alain Joye wrote: >>Segfault: >

Re: [PHP-DEV] segfault with iterators

2004-02-25 Thread Andi Gutmans
Nope. I don't have time to add one right now... Pierre got time? :) If not I'll try and do it within the next few days. Andi At 21:53 25/02/2004 +0200, Jani Taskinen wrote: Was there a test for this..? Would be nice if Pierre/Andi would add one if not. :) --Jani On Wed, 25 Feb 2004

[PHP-DEV] CVS Account Request: allanper

2004-02-25 Thread Allan Al Haj Naves Pereira
help in the translation for portugues(Brazil) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: segfault in shutdown sequence

2004-02-25 Thread Timm Friebe
On Tue, 2004-02-24 at 22:45, Jani Taskinen wrote: > This is most likely fixed already in CVS. > > --Jani It wasn't yesterday, but now it is:) I was able to reproduce it but couldn't come up with a simple script demonstrating the behaviour. - Timm -- PHP Internals - PHP Runtime Deve

[PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Timm Friebe
[EMAIL PROTECTED]:~/devel/php/tests > cat inheritance.php [EMAIL PROTECTED]:~/devel/php/tests > php-dev inheritance.php Fatal error: Declaration of Bar::__construct() must be compatible with that of Foo::__construct() in /usr/home/thekid/devel/php/tests/inheritance.php on line 10 Is this reall

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Marcus Boerger
Hello Timm, i had the same expirience today too. And also for me it makes not much sense. The constructor shouldn't check inheritance rules. And as a consequence maybe interfaces shouldn't allow constructors. marcus Wednesday, February 25, 2004, 11:36:57 PM, you wrote: > [EMAIL PROTECTED]:~/dev

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Timm Friebe
On Wed, 2004-02-25 at 23:44, Marcus Boerger wrote: > Hello Timm, > > i had the same expirience today too. And also for me it makes not much > sense. The constructor shouldn't check inheritance rules. Neither should other methods follow this. What if I want to add a non-default parameter to an ove

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Marcus Boerger
Hello Timm, well for normal methods we must do that. The derived class must support the same signature that the base class supports. In you example that would only work if the derived method would have a default parameter for the additional parameter: regards marcus Wednesday, February 25, 20

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Timm Friebe
On Wed, 2004-02-25 at 23:52, Timm Friebe wrote: > On Wed, 2004-02-25 at 23:44, Marcus Boerger wrote: > > Hello Timm, > > > > i had the same expirience today too. And also for me it makes not much > > sense. The constructor shouldn't check inheritance rules. > > Neither should other methods follow

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible

2004-02-25 Thread Hans Lellelid
Timm Friebe wrote: On Wed, 2004-02-25 at 23:44, Marcus Boerger wrote: Hello Timm, i had the same expirience today too. And also for me it makes not much sense. The constructor shouldn't check inheritance rules. Neither should other methods follow this. What if I want to add a non-default parame

Re: Fwd: [PHP-DEV] RC1

2004-02-25 Thread Timm Friebe
On Wed, 2004-02-25 at 15:41, Andi Gutmans wrote: > Quick reminder... > If you have any bugs to fix, please fix them in the coming days. The following: -- ', $p->getDeclaringClass()->getName(), "\n"; $p= &new Reflection_Property(

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Marcus Boerger
Hello Timm, Thursday, February 26, 2004, 12:34:31 AM, you wrote: > On Wed, 2004-02-25 at 23:52, Timm Friebe wrote: >> On Wed, 2004-02-25 at 23:44, Marcus Boerger wrote: >> > Hello Timm, >> > >> > i had the same expirience today too. And also for me it makes not much >> > sense. The constructor s

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Timm Friebe
On Thu, 2004-02-26 at 01:38, Marcus Boerger wrote: > Hello Timm, [...] > > Should work #1, Bar::connect() adds an argument > No the sugnature is incompatible. An instance of Foo cannot be called > with Bar or Connector's connect() Signature. Hence Bar is not a Foo > or Connector. Hrm, that's quite

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Marcus Boerger
Hello Timm, Hello Zeev, please have a look at this thread. Obviously you started a huge BC break here. See my second comment on a possible way out. Thursday, February 26, 2004, 2:13:48 AM, you wrote: > On Thu, 2004-02-26 at 01:38, Marcus Boerger wrote: >> Hello Timm, > [...] >> > Should work #1,

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Adam Maccabee Trachtenberg
On Thu, 26 Feb 2004, Marcus Boerger wrote: > well for normal methods we must do that. The derived class must support the > same signature that the base class supports. In you example that would only > work if the derived method would have a default parameter for the additional > parameter: > >

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Timm Friebe
On Thu, 2004-02-26 at 02:13, Timm Friebe wrote: > On Thu, 2004-02-26 at 01:38, Marcus Boerger wrote: > > Hello Timm, > [...] > > > Should work #1, Bar::connect() adds an argument > > No the sugnature is incompatible. An instance of Foo cannot be called > > with Bar or Connector's connect() Signatur

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Timm Friebe
On Thu, 2004-02-26 at 02:38, Marcus Boerger wrote: > Hello Timm, [...] > Yes! Maybe it would be good to apply the correct rules with E_COMPILE_ERROR > in cases where interfaces come into play and E_STRICT for compatibility mode > and non interfaces. Would that work for you? Yupp, that's perfect.

Re: Fwd: [PHP-DEV] RC1

2004-02-25 Thread Timm Friebe
On Wed, 2004-02-25 at 15:41, Andi Gutmans wrote: > Quick reminder... > If you have any bugs to fix, please fix them in the coming days. Not a bug, but a feature request - make set_exception_handler() accept the meta-type "callable" instead of only strings. - Timm Index: Zend/zend_builtin_function

[PHP-DEV] Bus Error in shutdown

2004-02-25 Thread Timm Friebe
No simple reproduce script available, unfortunately: Program received signal SIGBUS, Bus error. 0x8285320 in zend_fetch_obj_w_handler (execute_data=0xbfbfefc4, opline=0x854a4e0, op_array=0x854d648, tsrm_ls=0x8385050) at /usr/home/thekid/devel/php/php/Zend/zend_execute.c:2044 /usr/home/thekid/dev

[PHP-DEV] Memory leak in *printf

2004-02-25 Thread Timm Friebe
/usr/home/thekid/devel/php/php/ext/standard/formatted_print.c(625) : Freeing 0x085634A0 (16 bytes), script=/home/thekid/experiments/examples/reflection.php Last leak repeated 1 time /usr/home/thekid/devel/php/php/ext/standard/formatted_print.c(627) : Freeing 0x083B2020 (59 bytes), script=/home/th

[PHP-DEV] Segfault during shutdown

2004-02-25 Thread Timm Friebe
Seems to be related to http://lists.php.net/article.php?group=php.internals&article=8103 (which was fixed for most cases I was able to reproduce it with). Here, too, I do not have a nice short script (I've started migrating a rather largish framework to PHP5) but from a quick glance it only shows

Re: Fwd: [PHP-DEV] RC1

2004-02-25 Thread Timm Friebe
On Thu, 2004-02-26 at 01:33, Timm Friebe wrote: > On Wed, 2004-02-25 at 15:41, Andi Gutmans wrote: > > Quick reminder... > > If you have any bugs to fix, please fix them in the coming days. ...and another one: $ cat protected.php newInstance()); ?> $ php-dev protected.php Constructor was called

Re: Fwd: [PHP-DEV] RC1

2004-02-25 Thread Timm Friebe
On Thu, 2004-02-26 at 05:50, Timm Friebe wrote: > On Thu, 2004-02-26 at 01:33, Timm Friebe wrote: > > On Wed, 2004-02-25 at 15:41, Andi Gutmans wrote: > > > Quick reminder... > > > If you have any bugs to fix, please fix them in the coming days. > > ...and another one: And yet another one (includ

[PHP-DEV] Class Baz contains 1 abstract methods and must therefore be declared abstract (Baz::run)

2004-02-25 Thread Timm Friebe
Fails: "Fatal error: Class Baz contains 1 abstract methods and must therefore be declared abstract (Baz::run)" (expected behaviour): Works (no error message, is instantiable): Is this correct? Why would this differ for inherited classes? And why are these checks performed at runtime? - Timm

[PHP-DEV] phpMyAdmin-2.5.6-rc2 does not work with HEAD

2004-02-25 Thread Sebastian Bergmann
Fatal error: Can't use function return value in write context in C:\Server\htdocs\phpMyAdmin\libraries\common.lib.php on line 307 307: define('PMA_MYSQL_CLIENT_API', \ (int)sprintf('%d%02d%02d', $client_api[0], $client_api[1], \ intval($client_api[2]))); -- Sebastian Be

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Andi Gutmans
At 23:36 25/02/2004 +0100, Timm Friebe wrote: [EMAIL PROTECTED]:~/devel/php/tests > cat inheritance.php class Bar extends Foo { function __construct($foo, $bar) { // Add = NULL after $bar to make it work } } ?> [EMAIL PROTECTED]:~/devel/php/tests > php-dev inheritance.php Fatal e

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Andi Gutmans
At 23:52 25/02/2004 +0100, Timm Friebe wrote: On Wed, 2004-02-25 at 23:44, Marcus Boerger wrote: > Hello Timm, > > i had the same expirience today too. And also for me it makes not much > sense. The constructor shouldn't check inheritance rules. Neither should other methods follow this. What if I w

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible

2004-02-25 Thread Andi Gutmans
At 18:54 25/02/2004 -0500, Hans Lellelid wrote: It seems now that PHP is no longer inconsistent, but it also seems that it is impossible to override methods w/ incompatible signature. Is that a correct assessment? This is a pretty big difference from PHP4, then. Personally, I can live with i

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Timm Friebe
On Thu, 2004-02-26 at 07:49, Andi Gutmans wrote: > At 23:36 25/02/2004 +0100, Timm Friebe wrote: [...] > Guys, > > You are breaking the isA relationship. We fixed this so that from now on, > people will not make such mistakes anymore (I think it's the right way to > go, so that we don't leave br

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Andi Gutmans
At 08:03 26/02/2004 +0100, Timm Friebe wrote: On Thu, 2004-02-26 at 07:49, Andi Gutmans wrote: > At 23:36 25/02/2004 +0100, Timm Friebe wrote: [...] > Guys, > > You are breaking the isA relationship. We fixed this so that from now on, > people will not make such mistakes anymore (I think it's the r

Re: [PHP-DEV] Bus Error in shutdown

2004-02-25 Thread Andi Gutmans
Please let me know when you are able to reproduce it. The stacktrace doesn't tell me much. Thanks, Andi At 04:28 26/02/2004 +0100, Timm Friebe wrote: No simple reproduce script available, unfortunately: Program received signal SIGBUS, Bus error. 0x8285320 in zend_fetch_obj_w_handler (execute_data=

Re: [PHP-DEV] Bus Error in shutdown

2004-02-25 Thread Timm Friebe
On Thu, 2004-02-26 at 08:13, Andi Gutmans wrote: > Please let me know when you are able to reproduce it. > The stacktrace doesn't tell me much. > Thanks, > Andi Got it:) attributes as $name => $attr) { } } } $f= new Foo(); $f->export(); ?> - Timm -- PHP Internals - PHP Runti

Re: [PHP-DEV] Declaration of Bar::__construct() must be compatible with that of Foo::__construct()

2004-02-25 Thread Michael Walter
Timm Friebe wrote: [EMAIL PROTECTED]:~/devel/php/tests > cat inheritance.php class Foo { function __construct($foo) { } } class Bar extends Foo { function __construct($foo, $bar) { // Add = NULL after $bar to make it work } } ?> [EMAIL PROTECTED]:~/devel/php/te