Re: [PHP-DEV] Fix for #27291 (get_browser() problems)

2004-02-29 Thread Rasmus Lerdorf
Hey Jay, sorry, didn't notice this message until after sending out my previous request. How do you feel about taking over maintaining the browscap code and splitting it off into its own pecl extension so you are not restricted by PHP's release schedule? -Rasmus On Thu, 26 Feb 2004, Jay Smith wro

[PHP-DEV] Cleaning up the browscap mess

2004-02-29 Thread Rasmus Lerdorf
Guys, given the recent implosion of browscap/get_browser I would like to find a volunteer to clean up this code. See http://bugs.php.net/27438 for the fireworks and http://bugs.php.net/27291 for some background. I would suggest as a first step to pull it out of ext/standard and create a pecl exte

Re: [PHP-DEV] BC break: $o= new stdclass; empty($o)

2004-02-29 Thread Timm Friebe
On Sun, 2004-02-29 at 19:09, Stanislav Malyshev wrote: > TF>> I have a patch, but that includes a TSRMLS_FETCH() - maybe it would > TF>> be wise to change: > > Patch that does what? Well, fix the BC issue by implementing what was marked with "TBI" (which, as I assume, means "to be implemented").

Re: [PHP-DEV] BC break: $o= new stdclass; empty($o)

2004-02-29 Thread Stanislav Malyshev
TF>> I have a patch, but that includes a TSRMLS_FETCH() - maybe it would TF>> be wise to change: Patch that does what? -- Stanislav Malyshev, Zend Products Engineer [EMAIL PROTECTED] http://www.zend.com/ +972-3-6139665 ext.109 -- PHP Internals - PHP Runtime Development Mailing List To unsu

Re: [PHP-DEV] BC break: $o= new stdclass; empty($o)

2004-02-29 Thread Timm Friebe
On Sun, 2004-02-29 at 18:10, Timm Friebe wrote: > Hi, [...] > Was this an intentional change? zend_execute.h, lines 95 - 98: case IS_OBJECT: /* OBJ-TBI */ result = 1; break; I have a patch, but that includes a TSRMLS_FETCH() - maybe it would be wise to change: ZEND

Re: [PHP-DEV] SimpleXML & Casting to String

2004-02-29 Thread Andi Gutmans
At 12:36 29/02/2004 -0500, Sterling Hughes wrote: The problem is that user-land overloading can't be supported. C extensions might be able to be supported but I don't think it's a good idea to start hacking this into PHP. It wouldn't end at the comparison operator but people would want it to wo

Re: [PHP-DEV] SimpleXML & Casting to String

2004-02-29 Thread Sterling Hughes
On Feb 29, 2004, at 12:31 PM, Andi Gutmans wrote: At 12:20 29/02/2004 -0500, Sterling Hughes wrote: On Feb 29, 2004, at 12:03 PM, Andi Gutmans wrote: I think there isn't a problem with "echo" as it will call the string handler. However, in other cases it might be problematic. Maybe a solution i

Re: [PHP-DEV] SimpleXML & Casting to String

2004-02-29 Thread Andi Gutmans
At 12:20 29/02/2004 -0500, Sterling Hughes wrote: On Feb 29, 2004, at 12:03 PM, Andi Gutmans wrote: I think there isn't a problem with "echo" as it will call the string handler. However, in other cases it might be problematic. Maybe a solution is to implement an equals function so that people wo

Re: [PHP-DEV] SimpleXML & Casting to String

2004-02-29 Thread Sterling Hughes
On Feb 29, 2004, at 12:03 PM, Andi Gutmans wrote: I think there isn't a problem with "echo" as it will call the string handler. However, in other cases it might be problematic. Maybe a solution is to implement an equals function so that people would do: if ($doc->name->equals("Hello")) ? I don'

[PHP-DEV] BC break: $o= new stdclass; empty($o)

2004-02-29 Thread Timm Friebe
Hi, $ php5 -r '$o= new stdclass; var_dump(empty($o));' bool(false) $ php4 -r '$o= new stdclass; var_dump(empty($o));' bool(true) Was this an intentional change? - Timm -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] SimpleXML & Casting to String

2004-02-29 Thread Andi Gutmans
I think there isn't a problem with "echo" as it will call the string handler. However, in other cases it might be problematic. Maybe a solution is to implement an equals function so that people would do: if ($doc->name->equals("Hello")) ? I don't think we can support auto-string conversion transp