Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Andi Gutmans
It's not a big deal, but I don't see why we should add a configure option if it's something which we'll remove the minute Wez has some more spare time and improves the implementation. At 01:40 AM 4/22/2004 +0200, Marcus Boerger wrote: Hello Andi, i still cannot say any reason against a configur

Re: [PHP-DEV] xmlSetGenericErrorFunc Abuse

2004-04-21 Thread Paul Querna
On Wed, 2004-04-21 at 23:06, Sterling Hughes wrote: > Err, read back in the message. Specifically about "should reset the > generic error handler." If it doesn't reset it, that's a separate > issue. see the attached patch. it fixes this problem for my test case. Does not completely shutdown

Re: [PHP-DEV] xmlSetGenericErrorFunc Abuse

2004-04-21 Thread Sterling Hughes
On Apr 21, 2004, at 6:16 PM, Paul Querna wrote: On Wed, 2004-04-21 at 18:50, Sterling Hughes wrote: Its actually quite different than that problem. This is a problem for people who use threads. I am afraid that you are completely wrong. httpd -V: Server version: Apache/2.1.0-dev Server built:

[PHP-DEV] umask weirdness

2004-04-21 Thread Bret Hughes
I posted this to the php general list and one of the other subscribers suggested that I post this here. It was also suggested that this might be a bug in apache2 but before I post this every where I thought I would try here. I have found a funky situation that I am trying to figure out if it is

Re: [PHP-DEV] xmlSetGenericErrorFunc Abuse

2004-04-21 Thread Paul Querna
On Wed, 2004-04-21 at 18:50, Sterling Hughes wrote: > Its actually quite different than that problem. This is a problem for > people who use threads. I am afraid that you are completely wrong. httpd -V: Server version: Apache/2.1.0-dev Server built: Feb 15 2004 14:26:54 Server's Module Magic

Re: [PHP-DEV] xmlSetGenericErrorFunc Abuse

2004-04-21 Thread Sterling Hughes
On Apr 21, 2004, at 2:36 PM, Paul Querna wrote: The libxml2 Extension in PHP5 uses xmlSetGenericErrorFunc(NULL, php_libxml_error_handler); This globally(inside the process) sets the libxml2 error hander to PHP's own function. Why is this bad? It clobbers the processing done by anything else t

Re: [PHP-DEV] Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Jason Garber
Just a note, Would "Object" be more appropriate than "Class"? The expected variable type is an object (defined by a class), and the gettype() function returns 'object'.. # php -r '$x=new stdclass(); var_dump(gettype($x));' string(6) "object" It may mean adding a new reserved word though. ~Jas

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Marcus Boerger
Hello Andi, i still cannot say any reason against a configure option here? marcus Wednesday, April 21, 2004, 1:42:00 PM, you wrote: > For now make it like 4MB. When you fix it to mmap() parts of the file I'd > use 256 or 512KB. > Andi > At 12:38 PM 4/21/2004 +0100, Wez Furlong wrote: >>Whic

Re: [PHP-DEV] Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Marcus Boerger
Hello Andi, the patch is here. It's a bit outdated but shouldn't cause much problems to apply after RC2. It allows "Class", "Array" but atm misses "Resource". marcus Wednesday, April 21, 2004, 11:50:46 AM, you wrote: > At 03:29 PM 4/20/2004 -0400, George Schlossnagle wrote: >>On Apr 20, 2004,

Re: [PHP-DEV] Re: typehinting and NULL

2004-04-21 Thread Marcus Boerger
Hello Andi, sounds like a great idea, maybe even the best one. marcus Wednesday, April 21, 2004, 12:25:15 PM, you wrote: > I wanted to support: > function preventNULL($val not NULL) > function allowNULL($val) > However, I left it for after 5.0.0 due to the feature freeze. Note, that it > will

[PHP-DEV] xmlSetGenericErrorFunc Abuse

2004-04-21 Thread Paul Querna
The libxml2 Extension in PHP5 uses xmlSetGenericErrorFunc(NULL, php_libxml_error_handler); This globally(inside the process) sets the libxml2 error hander to PHP's own function. Why is this bad? It clobbers the processing done by anything else that uses libxml2 in the same process as PHP. For

Re: [PHP-DEV] PHP Extension Memory Problems

2004-04-21 Thread Wez Furlong
> > What can I do in my extension to unset or clear the variable so that it > doesn’t have to be done in the PHP script? > if (!PZVAL_IS_REF(Arr)) > { >zend_error(E_ERROR, "The Arr parameter must be passed by reference"); ^^^ Don't use E_ERROR in an extension unless it wou

[PHP-DEV] PHP Extension Memory Problems

2004-04-21 Thread Bruce Bailey
I have two problems with a PHP extension that I wrote that creates PHP arrays. 1) If I call my extension function that creates PHP arrays and returns them, unless I either ‘unset’ or assign it to the empty string the process acts like there is a memory leak. PHP: For ($I = 0; $I < $count; $I+

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Andi Gutmans
At 08:46 AM 4/21/2004 -0400, Ilia Alshanetsky wrote: On April 21, 2004 05:52 am, Andi Gutmans wrote: > I have played with mmap() in the past. I found that mapping in relatively > small blocks such as 1MB does not really hurt performance. I suggest not to > add yet another INI option but to do it wi

Re: [PHP-DEV] Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Andrey Hristov
Quoting Johannes Schlueter <[EMAIL PROTECTED]>: > Andrey Hristov wrote: > > class foobar { > [...] > > protected function doSomething_objectFubar($fub) { > > $a = func_get_args();var_dump(__METHOD__, $a); > > } > > > > public function doSomething() { > > $args = func_ge

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Ilia Alshanetsky
On April 21, 2004 05:52 am, Andi Gutmans wrote: > I have played with mmap() in the past. I found that mapping in relatively > small blocks such as 1MB does not really hurt performance. I suggest not to > add yet another INI option but to do it with smaller blocks. I think even > 256KB wouldn't make

[PHP-DEV] PHP 5 RC2RC2

2004-04-21 Thread Andi Gutmans
Hey Guys, You can get PHP 5 RC2RC2 from http://snaps.php.net/~andi This includes the proposed interface change and a fix for exceptions. Please check it out and if there aren't any problems I'll roll RC2 tomorrow. Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Wez Furlong
1MB it is. --Wez. - Original Message - From: "Andi Gutmans" <[EMAIL PROTECTED]> To: "Derick Rethans" <[EMAIL PROTECTED]> Cc: "Wez Furlong" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Wednesday, April 21, 2004 12:51 PM Subject: Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Andi Gutmans
At 01:49 PM 4/21/2004 +0200, Derick Rethans wrote: On Wed, 21 Apr 2004, Andi Gutmans wrote: > >My patch is "nice" at this stage in the release because it is a > >minimal change that can't hurt anything; tweaking the passthru > >code is a bit more worrying :/ > > In that case, I'd put a hardcoded l

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Derick Rethans
On Wed, 21 Apr 2004, Andi Gutmans wrote: > >My patch is "nice" at this stage in the release because it is a > >minimal change that can't hurt anything; tweaking the passthru > >code is a bit more worrying :/ > > In that case, I'd put a hardcoded limit after which you fallback to > non-mmap()'ed re

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Andi Gutmans
For now make it like 4MB. When you fix it to mmap() parts of the file I'd use 256 or 512KB. Andi At 12:38 PM 4/21/2004 +0100, Wez Furlong wrote: Which brings us back to the original problem ;) How big should the limit be? --Wez. > In that case, I'd put a hardcoded limit after which you fallback

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Wez Furlong
Which brings us back to the original problem ;) How big should the limit be? --Wez. > In that case, I'd put a hardcoded limit after which you fallback to > non-mmap()'ed reading and not add an INI option. Then you can add the > tweaked code when you have time/energy. > Andi -- PHP Internals -

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Andi Gutmans
At 12:10 PM 4/21/2004 +0100, Wez Furlong wrote: Andi, Do you think mmap'ing a series of smaller chunks is going to be faster than mmap'ing the whole file, or faster than reading chunks conventionally? (just asking; I've not done any tests) I'm saying that mmap'ing chunks which are relatively big s

Re: [PHP-DEV] Re: Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Michael Walter
Christian Schneider wrote: Michael Walter wrote: How exactly do you think are default parameters related to the issue, anyway? Java uses multi-method dispatch to work around missing default values: function foo($a, $some_flag) { ... } function foo($a) { foo($a, false); } instead of function foo

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Wez Furlong
Andi, Do you think mmap'ing a series of smaller chunks is going to be faster than mmap'ing the whole file, or faster than reading chunks conventionally? (just asking; I've not done any tests) The mmap code in the passthru function will fall back on reading chunks in a loop if the mmap failed. Th

[PHP-DEV] $class_name::$const_name syntax

2004-04-21 Thread Antony Dovgal
Hi all! I know, it's too late to propose such things before PHP5.0.0, but maybe there is a chance to include it to 5.1... Short example: I found similar ideas here: http://lists.php.net/article.php?group=php.internals&article=7980, but this patch doesn't allow to fetch constants from the cla

Re[2]: [PHP-DEV] CVS Account request

2004-04-21 Thread Voytsekhovskyy Alexander
Good day, Nuno. NL> It takes some time in order to have your request approved. It may take up to NL> two months!! NL> In the middletime, you may start contributing, sending your translated docs NL> to the russian mailling list. Yes, I practise it for the last several monthes. I should support a

[PHP-DEV] Re: typehinting and NULL

2004-04-21 Thread Andi Gutmans
I wanted to support: function preventNULL($val not NULL) function allowNULL($val) However, I left it for after 5.0.0 due to the feature freeze. Note, that it will also not change today's semantics. Andi At 12:15 PM 4/21/2004 +0200, Christian Schneider wrote: Marcus Boerger wrote: function allowi

Re: [PHP-DEV] Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Johannes Schlueter
Andrey Hristov wrote: > class foobar { [...] > protected function doSomething_objectFubar($fub) { > $a = func_get_args();var_dump(__METHOD__, $a); > } > > public function doSomething() { > $args = func_get_args(); > $method_name = __FUNCTION__; > foreach

[PHP-DEV] Re: typehinting and NULL

2004-04-21 Thread Christian Schneider
Marcus Boerger wrote: function allowingNULL(object $val = NULL) function preventNULL(object $val) I like this idea even though it's abusing the default value syntax. What's a bit weird is something like function foo(object $obj = NULL, $mandatoryparameter) { ... } where people will wonder why ther

Re: [PHP-DEV] Re: Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Jevon Wright
But at the same time, it would be nice to have a standardised multi-method syntax or code - or users might develop their own weird and wacky, inconsistent ways of implementing it. Perhaps the code submitted before could be included in the PHP documentation, telling users on how they could emulate t

[PHP-DEV] typehinting and NULL

2004-04-21 Thread Marcus Boerger
Hello Andi, Zeev, internals, after readin the PHP articles on PHP5 and the rerequested typehinting for arrays i once again thought about typehints and NULL. At the moment typehints allow NULL always. That is complete nonsense because NULL doesn't pass any instance-of check. And in general there

Re: [PHP-DEV] Re: Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Andi Gutmans
I don't want to prolong this discussion but I agree with the people who are against multi-method dispatch. I don't think it makes much sense in PHP, and I think that in the few places where someone really feels they need it, it can be implemented in user-land. It's just going to complicate the

Re: [PHP-DEV] limit for mmaping for readfile (Bug #19749)

2004-04-21 Thread Andi Gutmans
Wez, I have played with mmap() in the past. I found that mapping in relatively small blocks such as 1MB does not really hurt performance. I suggest not to add yet another INI option but to do it with smaller blocks. I think even 256KB wouldn't make a big difference. Andi At 10:10 PM 4/20/2004

Re: [PHP-DEV] Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Marcus Boerger
Hello John, Wednesday, April 21, 2004, 11:34:01 AM, you wrote: > On Wed, 2004-04-21 at 02:47, Andrey Hristov wrote: >> OTOH hinting for array (internally) will be nice also. > Arrays are the only complex type that we can't hint, I'd love to see > this sort of thing implemented. Not completely r

Re: [PHP-DEV] Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Andi Gutmans
At 03:29 PM 4/20/2004 -0400, George Schlossnagle wrote: On Apr 20, 2004, at 3:18 PM, Marcus Boerger wrote: The problem with this is that that integer may well be a string when you look at it. There's no good way to do this past discriminating between scalar, array and object (by type, of course).

Re: [PHP-DEV] Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread John Coggeshall
On Wed, 2004-04-21 at 02:47, Andrey Hristov wrote: > OTOH hinting for array (internally) will be nice also. Arrays are the only complex type that we can't hint, I'd love to see this sort of thing implemented. John -- -=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=- John Coggeshall

Re: [PHP-DEV] Re: Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Wez Furlong
> Maybe we should take that off list though and present just > the result of our research :-) Yes please ;) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: Multi-Method Dispatch in PHP 5.1?

2004-04-21 Thread Christian Schneider
Michael Walter wrote: How exactly do you think are default parameters related to the issue, anyway? Java uses multi-method dispatch to work around missing default values: function foo($a, $some_flag) { ... } function foo($a) { foo($a, false); } instead of function foo($a, $some_flag = false) { ...