[PHP-DEV] [PATCH] Fix date() bug

2008-09-27 Thread Ilia Cheishvili
Hi all, This patch addresses the issue with the date() function. When passing in a 'u', the date() function simply outputs six zeros. To fix this, I added a gettimeofday() call that figures out what to display for microseconds. I am including the headers and using the function with

Re: [PHP-DEV] [PATCH] Fix date() bug

2008-09-27 Thread Alexey Zakhlestin
On Sat, Sep 27, 2008 at 11:04 AM, Ilia Cheishvili [EMAIL PROTECTED] wrote: Hi all, This patch addresses the issue with the date() function. When passing in a 'u', the date() function simply outputs six zeros. To fix this, I added a gettimeofday() call that figures out what to display for

Re: [PHP-DEV] alpha3

2008-09-27 Thread Alexey Zakhlestin
On Sat, Sep 27, 2008 at 8:10 AM, Greg Beaver [EMAIL PROTECTED] wrote: I have to respectfully disagree with both of you: Stas: choosing an imperfect solution when a better one already exists is just plain stupid, and isn't what you want *or* what you suggested - the solution you, Liz, Marcus

Re: [PHP-DEV] alpha3

2008-09-27 Thread Ilia Cheishvili
I would definitely have to agree. I would much prefer to have a minimal solution implemented and then to iterate over it in the future than to try to figure out the perfect implementation the first time. Just from watching where the thread about namespaces has gone, I would definitely have to say

Re: [PHP-DEV] [PATCH] Fix date() bug

2008-09-27 Thread Ilia Cheishvili
It definitely would be, and that's actually the way I would have preferred to do it. I didn't want to impact too much code, if that makes sense in this case, but I'm glad that someone agrees :) I have attached a patch to do exactly this. Ilia On Sat, Sep 27, 2008 at 1:40 AM, Alexey Zakhlestin

Re: [PHP-DEV] [PATCH] Fix date() bug

2008-09-27 Thread Alexey Zakhlestin
On Sat, Sep 27, 2008 at 12:04 PM, Ilia Cheishvili [EMAIL PROTECTED] wrote: It definitely would be, and that's actually the way I would have preferred to do it. I didn't want to impact too much code, if that makes sense in this case, but I'm glad that someone agrees :) I have attached a patch

Re: [PHP-DEV] [PATCH] Fix date() bug

2008-09-27 Thread Ilia Cheishvili
Ah, I see. I like that even better :) And I attached yet another patch that incorporates your idea. Ilia On Sat, Sep 27, 2008 at 2:20 AM, Alexey Zakhlestin [EMAIL PROTECTED]wrote: On Sat, Sep 27, 2008 at 12:04 PM, Ilia Cheishvili [EMAIL PROTECTED] wrote: It definitely would be, and that's

Re: [PHP-DEV] alpha3

2008-09-27 Thread Steph Fox
Hi Greg, Steph: the limited solution proposed by Stas and company (removing functions [and I would add constants]/fixing name resolution) *is* a basic solution that can be expanded on. I outlined the steps in my reply. It's the best solution to the problem, not an imperfect one. A namespace

Re: [PHP-DEV] [PATCH] Fix date() bug

2008-09-27 Thread Alexey Zakhlestin
On Sat, Sep 27, 2008 at 12:26 PM, Ilia Cheishvili [EMAIL PROTECTED] wrote: Ah, I see. I like that even better :) And I attached yet another patch that incorporates your idea. thanks. I did some more code-digging, and it looks, like proper point for fixing is not here, anyway. It should be in

Re: [PHP-DEV] [PATCH] Fix date() bug

2008-09-27 Thread Alexey Zakhlestin
On Sat, Sep 27, 2008 at 1:28 PM, Hannes Magnusson [EMAIL PROTECTED] wrote: On Sat, Sep 27, 2008 at 09:04, Ilia Cheishvili [EMAIL PROTECTED] wrote: Hi all, This patch addresses the issue with the date() function. When passing in a 'u', the date() function simply outputs six zeros. To fix

Re: [PHP-DEV] alpha3

2008-09-27 Thread jvlad
Adding support for functions, constants and even variables is actually quite do-able with the solution I suggested (different separator between namespace name and function/constant/variable name) and can be added easily. Adding support for functions, constants and even variables is actually

Re: [PHP-DEV] alpha3

2008-09-27 Thread Gregory Beaver
jvlad wrote: Adding support for functions, constants and even variables is actually quite do-able with the solution I suggested (different separator between namespace name and function/constant/variable name) and can be added easily. Adding support for functions, constants and even

Re: [PHP-DEV] [PATCH] Fix date() bug

2008-09-27 Thread Ilia Cheishvili
I did some digging around in the code and came up with the solution that you suggested. I put the fix in unixtime2tm.c, letting php_date.c remain the nice abstraction layer between the system-dependent code of getting the time and actually formatting it for display. The patch is attached.

Re: [PHP-DEV] PHP opcode documentation

2008-09-27 Thread Hannes Magnusson
On Thu, Sep 25, 2008 at 20:36, Rasmus Lerdorf [EMAIL PROTECTED] wrote: zoe wrote: I have some PHP opcode documentation which might be useful, an html version is linked here: http://www.zapt.info/opcodes.html. Awesome work!! Cool. I think the php-doc folks can help you come up with