Re: [PHP-DEV] max_execution_time and async signal handling in apache2handler

2009-03-15 Thread Jani Taskinen
There's also this (very old) bug report about similar issue: http://bugs.php.net/bug.php?id=16820&edit=1 Moriyoshi Koizumi wrote: Hi, I noticed it, but I took it as a completely different idea, something like a performance improvement that doesn't cover the issue. It turned out that is what

Re: [PHP-DEV] max_execution_time and async signal handling in apache2handler

2009-03-15 Thread Moriyoshi Koizumi
Hi, I noticed it, but I took it as a completely different idea, something like a performance improvement that doesn't cover the issue. It turned out that is what I should have had a look at. Thanks for the pointer. Moriyoshi On Mon, Mar 16, 2009 at 8:52 AM, shire wrote: > > Hi Moriyoshi, > > M

Re: [PHP-DEV] max_execution_time and async signal handling in apache2handler

2009-03-15 Thread shire
Hi Moriyoshi, Moriyoshi Koizumi wrote: Hi, I got a bug report on the Japanese PHP user's list that states free() aborts within the timer signal handler due to reentrance to the function when max_execution_time takes effect and the signal occurs within the same libc function. The reporter also

Re: [PHP-DEV] SplStack Implementation

2009-03-15 Thread Marcus Boerger
Hello Ben, there is no need in checking whether the implementation uses single or double linked. Access to any structure from the engine will always be slower by orders of magnitude, then maintaining a pinter structure directly in C code. Now doing something with that in PHP code will again be s

Re: [PHP-DEV] [PATCH] Remove nTableSize from HashTable?

2009-03-15 Thread Marcus Boerger
Hello Matt, if there is no advantage in doing so, why offer a patch? Ok, you probably meant disadvantage. And the advantge of doing so is probably a lower memory foot print. Did you by any chance run any profiling? Without numbers, I guess it is not worth the effort changing a core component.

[PHP-DEV] max_execution_time and async signal handling in apache2handler

2009-03-15 Thread Moriyoshi Koizumi
Hi, I got a bug report on the Japanese PHP user's list that states free() aborts within the timer signal handler due to reentrance to the function when max_execution_time takes effect and the signal occurs within the same libc function. The reporter also states he uses apache2handler, which doesn'

Re: [PHP-DEV] SplStack Implementation

2009-03-15 Thread Etienne Kneuss
Hello, On Sun, Mar 15, 2009 at 2:19 PM, Ben Smithers wrote: > Firstly, apologies if this is not the correct place to ask such a question - > I was directed here from a forum. > > I recently discovered the datastructures found in the Standard PHP Library. > I noticed that SplStack is implemented u

[PHP-DEV] [PATCH] Remove nTableSize from HashTable?

2009-03-15 Thread Matt Wilmas
Hi Dmitry, all, Just a quick one... ;^) Is there much, if any, advantage to removing the HashTable member nTableSize? It's just nTableMask + 1, so it can be derived easily in the couple places that need it... Figured it can't hurt to make things smaller, and it only adds a couple addition o

[PHP-DEV] SplStack Implementation

2009-03-15 Thread Ben Smithers
Firstly, apologies if this is not the correct place to ask such a question - I was directed here from a forum. I recently discovered the datastructures found in the Standard PHP Library. I noticed that SplStack is implemented using a doubly-linked list and wondered why. Given that a stack is L