Re: [PHP-DEV] how to find a memory corruption in php ?

2011-04-03 Thread Pascal COURTOIS
Le 03/04/2011 20:37, Pierre Joye a écrit : > post it with the necessary steps to reproduce it. We may try to reduce > the code to the minimal we need to get the leak (I remember someone > having a tool for that) ok, thanks: http://bugs.php.net/bug.php?id=54460 -- PHP Internals - PHP Runtime Deve

Re: [PHP-DEV] how to find a memory corruption in php ?

2011-04-03 Thread Pierre Joye
post it with the necessary steps to reproduce it. We may try to reduce the code to the minimal we need to get the leak (I remember someone having a tool for that) On Sun, Apr 3, 2011 at 6:27 PM, Pascal COURTOIS wrote: > Le 03/04/2011 15:46, Patrick ALLAERT a écrit : > >> Sounds like "now" is a go

Re: [PHP-DEV] how to find a memory corruption in php ?

2011-04-03 Thread Pascal COURTOIS
Le 03/04/2011 15:46, Patrick ALLAERT a écrit : > Sounds like "now" is a good time to fill in a bug report at > http://bugs.php.net/ :) The trouble is I don't know how to fill in such bug report. It happens with my template engine which is thousands of lines of PHP. The template engine has been

Re: [PHP-DEV] how to find a memory corruption in php ?

2011-04-03 Thread Patrick ALLAERT
2011/4/3 Pascal COURTOIS : > Le 03/04/2011 12:46, Pierre Joye a écrit : > >> USE_ZEND_ALLOC=0 valgrind php --leak-check=full sapi/cli/php ... (or >> httpd if you use apache or only reproducible there) >> >> That will tell you if there are actual leaks. > >  it IS leaking: > > ==9772== Memcheck, a m

Re: [PHP-DEV] patch review

2011-04-03 Thread Pierre Joye
Please post relevant comments and information to the bug report directly. It will make our work and review easier. Thanks, On Sun, Apr 3, 2011 at 2:07 PM, Tomas Kuliavas wrote: > 2011.04.03 13:58 Tomas Brastavičius rašė: >> Hi, >> >> can somebody review the following patch: >> http://bugs.php.ne

Re: [PHP-DEV] patch review

2011-04-03 Thread Tomas Kuliavas
2011.04.03 13:58 Tomas Brastavičius rašė: > Hi, > > can somebody review the following patch: > http://bugs.php.net/bug.php?id=54369 > > I am willing the bug is fixed in the next PHP release and ready to do a > job if something is wrong with the patch. Check url encoding documentation first. http:/

Re: [PHP-DEV] patch review

2011-04-03 Thread Pascal COURTOIS
Le 03/04/2011 13:30, Peter Beverloo a écrit : > The parsing change you are proposing is invalid per RFC 1738. RFC 1738 has been obsoleted by RFC 3986 http://tools.ietf.org/html/rfc3986 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.

Re: [PHP-DEV] patch review

2011-04-03 Thread Peter Beverloo
2011/4/3 Tomas Brastavičius : > Hi, > > can somebody review the following patch: > http://bugs.php.net/bug.php?id=54369 > > I am willing the bug is fixed in the next PHP release and ready to do a > job if something is wrong with the patch. > > Thank you > > Regards, > Tomas > > > -- > PHP Internals

Re: [PHP-DEV] how to find a memory corruption in php ?

2011-04-03 Thread Pascal COURTOIS
Le 03/04/2011 12:46, Pierre Joye a écrit : > USE_ZEND_ALLOC=0 valgrind php --leak-check=full sapi/cli/php ... (or > httpd if you use apache or only reproducible there) > > That will tell you if there are actual leaks. it IS leaking: ==9772== Memcheck, a memory error detector ==9772== Copyright

[PHP-DEV] patch review

2011-04-03 Thread Tomas Brastavičius
Hi, can somebody review the following patch: http://bugs.php.net/bug.php?id=54369 I am willing the bug is fixed in the next PHP release and ready to do a job if something is wrong with the patch. Thank you Regards, Tomas -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] how to find a memory corruption in php ?

2011-04-03 Thread Pascal COURTOIS
Le 03/04/2011 12:46, Pierre Joye a écrit : > Try to run it by disabling the zend memory manager: with zend memory manager disabled the program works fine. I'll try with valgrind as you suggest -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/u

Re: [PHP-DEV] how to find a memory corruption in php ?

2011-04-03 Thread Pierre Joye
On Sun, Apr 3, 2011 at 12:20 PM, Pascal COURTOIS wrote: > Le 01/04/2011 18:46, Pascal COURTOIS a écrit : >> Le 01/04/2011 15:20, Pierre Joye a écrit : >>> hi, >>> >>> In php 5.3+ the memory limit default is 256MB, not 128MB. 5.3 does not >>> necessary use more memory but actually uses and reports

Re: [PHP-DEV] how to find a memory corruption in php ?

2011-04-03 Thread Pascal COURTOIS
Le 01/04/2011 18:46, Pascal COURTOIS a écrit : > Le 01/04/2011 15:20, Pierre Joye a écrit : >> hi, >> >> In php 5.3+ the memory limit default is 256MB, not 128MB. 5.3 does not >> necessary use more memory but actually uses and reports its usage more >> efficiently. I would suggest to use this defau