Re: [PHP-DEV] Revert Tokenizer behavior for 5.4

2011-09-16 Thread Ferenc Kovacs
> > Wait wait wait. Thats the point here? > __COMPILER_HALT_OFFSET__ already tells you where the data starts. > > -Hannes > I didn't sent this message first, but after reading the mail from Chris, I think maybe it would clear the confusion: It is about tokenizing a file which has __halt_compiler(

Re: [PHP-DEV] 5.4 beta

2011-09-16 Thread Hannes Magnusson
On Thu, Sep 15, 2011 at 23:44, Pierre Joye wrote: > On Thu, Sep 15, 2011 at 11:42 PM, Stas Malyshev > wrote: > >> The problem is data may vary by CLDR version, etc. and keeping pace with all >> variants on all platforms, etc. will be a nightmare. > > To have a couple of versions, say x.y, x.y+1

Re: [PHP-DEV] [PATCH] Autoguessing TEST_PHP_EXECUTABLE if none is provided in run-tests.php

2011-09-16 Thread Alexey Shein
It seems last message didn't go to the list, resending 2011/9/12 Alexey Shein : > Created bug report here, included Christopher's suggestion into the patch: > https://bugs.php.net/bug.php?id=55672 Please, review the patch and tell me if there are any objections not to take it. Thank you. -- Reg

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-16 Thread Alexey Shein
2011/9/15 Hannes Magnusson : > On Wed, Sep 14, 2011 at 12:36, Alexey Shein wrote: >> 2011/9/14 Ferenc Kovacs : Why do we even have this tmp-php.ini? Why not just make test without any .ini files, i.e. just with -n option? >>> >>> [20:44:09] Tyrael: tmp-php.ini is built from the sys

Re: [PHP-DEV] 5.4 beta

2011-09-16 Thread Pierre Joye
On Fri, Sep 16, 2011 at 10:10 AM, Hannes Magnusson wrote: > On Thu, Sep 15, 2011 at 23:44, Pierre Joye wrote: >> On Thu, Sep 15, 2011 at 11:42 PM, Stas Malyshev >> wrote: >> >>> The problem is data may vary by CLDR version, etc. and keeping pace with all >>> variants on all platforms, etc. will

Re: [PHP-DEV] 5.4 beta

2011-09-16 Thread Lester Caine
Hannes Magnusson wrote: My test failure seem to be both caused by data difference, but also float precision and timezone issues, and thats within our domain to ensure is working fine. The remaining interbase/firebird errors are similar niggles ... but I'm not sure just how one would know that

Re: [PHP-DEV] A couple of missing directories if configure.js is forgotten.

2011-09-16 Thread Richard Quadling
Sure thing. https://bugs.php.net/bug.php?id=55709 and https://bugs.php.net/bug.php?id=55710 2011/9/15 Pierre Joye : > hi Richard, > > Can you open a bug for each of your patches please? Thanks! > > 2011/9/15 Ángel González : >> Richard Quadling wrote: >>> >>> Hi. >>> >>> Sometimes I remove Rele

Re: [PHP-DEV] A couple of missing directories if configure.js is forgotten.

2011-09-16 Thread Richard Quadling
2011/9/15 Ángel González : > Richard Quadling wrote: >> >> Hi. >> >> Sometimes I remove Release prior to nmake to make sure everything builds >> clean. >> >> 2 directories fail to get build >> >> Release\win32 >> Release\devel >> >> The attached patch fixes that. >> >> -       @for %D in ($(BUILD_D