RE: [PHP-DEV] Uploading a patch fails...

2012-01-28 Thread Clint M Priest
Okay... Pierre had recommended I upload the patches to that bug report when I first got started. I just finished getting the last of the hard stuff working tonight. The patch is pretty big (though the 200k may have had a lot of white-space changes). It may also be so big because that patch in

Re: [PHP-DEV] Uploading a patch fails...

2012-01-28 Thread Ferenc Kovacs
2012/1/28 Ángel González : > On 28/01/12 03:05, Rasmus Lerdorf wrote: >> >> There is a 100k limit, but the error message you are getting indicates >> that you aren't actually hitting that limitation. The server config has >> a 2M limit, so you should be fitting well within that. I'm not sure how >>

[PHP-DEV] SOAP request user_agent field

2012-01-28 Thread Sergio Carlos Morales
As noted on bug #60887 SOAP does not send the user-agent field when requesting the wsdl Subsequent requests are Is this a normal behavior? Or the request to the WSDL should also include the User-Agent field? Please comment to determine if patch should be applied or not to include the field in the

[PHP-DEV] Symlinks in / don't work

2012-01-28 Thread Rasmus Lerdorf
Hey Dmitry, could you take a look at this one. I think this is mostly your code and I am a bit lost in the path manipulation that is going on here. This is bug https://bugs.php.net/51860 and it can be reproduced from cli like this: % cd / % ln -s / phptest % echo "OK" > /phpfile % echo ' /phpinc

Re: [PHP-DEV] Re: PHP_SESSION_* constant values

2012-01-28 Thread Paul Dragoonis
On Sat, Jan 28, 2012 at 9:53 PM, Justin Martin wrote: > Someone actually just pointed out to me that if(-1) returns true. In that > case, I suppose my suggestion doesn't quite work. > > The reason I suggest this is that I suspect people will constantly be > looking up what the constants are called

Re: [PHP-DEV] Uploading a patch fails...

2012-01-28 Thread Ángel González
On 28/01/12 03:05, Rasmus Lerdorf wrote: There is a 100k limit, but the error message you are getting indicates that you aren't actually hitting that limitation. The server config has a 2M limit, so you should be fitting well within that. I'm not sure how your 200k patch is hittig that "file is e

Re: [PHP-DEV] Re: PHP_SESSION_* constant values

2012-01-28 Thread Sanford Whiteman
> Someone actually just pointed out to me that if(-1) returns true. In > that case, I suppose my suggestion doesn't quite work. Well, it still "works" depending on what conclusion you want to draw in your local environment. Sessions_disabled || yes_active_session might go through the same code

Re: [PHP-DEV] Uploading a patch fails...

2012-01-28 Thread Ferenc Kovacs
> > BTW, I would recommend using Wiki and RFC for tracking new features, > especially of this magnitude. This is obviously not a bug, and not a small > feature request either... the RFC is already in the wiki, AFAIR it is linked from the ticket also. https://wiki.php.net/rfc/propertygetsetsyntax h

[PHP-DEV] Re: PHP_SESSION_* constant values

2012-01-28 Thread Justin Martin
Someone actually just pointed out to me that if(-1) returns true. In that case, I suppose my suggestion doesn't quite work. The reason I suggest this is that I suspect people will constantly be looking up what the constants are called. On 12-01-28 11:17 AM, Justin Martin wrote: Hello everyon

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Sanford Whiteman
> There is no BC change here as session_status() has been added in the > 5_4 branch as far as i can tell. OK, fair enough, I didn't understand it was trying to get into 5.4. -- S. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Paul Dragoonis
On Sat, Jan 28, 2012 at 9:14 PM, Sanford Whiteman wrote: >> I believe comparing the value against a constant, is always more >> readable than wondering what "truthy" means. if(session_status() === >> PHP_SESSION_ACTIVE) is much self-documenting than the proposed change. > > ...  also  an  obvious

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Sanford Whiteman
> I believe comparing the value against a constant, is always more > readable than wondering what "truthy" means. if(session_status() === > PHP_SESSION_ACTIVE) is much self-documenting than the proposed change. ... also an obvious BC break for anyone who was using the values instead of the

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Stas Malyshev
Hi! I'd like to suggest we change these values to - PHP_SESSION_DISABLED = -1 - PHP_SESSION_NONE = 0 - PHP_SESSION_ACTIVE = 1 This way, one can do if(session_status()) to check if there is an active session, rather than having to compare the result to a constant. Any objections?

Re: [PHP-DEV] Uploading a patch fails...

2012-01-28 Thread Stas Malyshev
Hi! I'm trying to upload the latest getters/setters patch to: https://bugs.php.net/bug.php?id=49526 I get "Uploaded file is empty or nothing was uploaded." Is there a problem or a file size limit? The patch file is 205k now. BTW, I would recommend using Wiki and RFC for tracking new featur

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Paul Dragoonis
On Sat, Jan 28, 2012 at 7:17 PM, Justin Martin wrote: > Hello everyone, > > For the result of session_status(), the corresponding constants for the > sessions state are > >  - PHP_SESSION_DISABLED = 0 >  - PHP_SESSION_NONE = 1 >  - PHP_SESSION_ACTIVE = 2 > > I'd like to suggest we change these val

[PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Justin Martin
Hello everyone, For the result of session_status(), the corresponding constants for the sessions state are - PHP_SESSION_DISABLED = 0 - PHP_SESSION_NONE = 1 - PHP_SESSION_ACTIVE = 2 I'd like to suggest we change these values to - PHP_SESSION_DISABLED = -1 - PHP_SESSION_NONE = 0 -

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/Zend/zend_execute_API.c trunk/Zend/zend_execute_API.c

2012-01-28 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thank you for catching that. Please go ahead and commit!. Thanks On 01/28/2012 04:00 PM, Derick Rethans wrote: > Hi David, > > When I was just checking PHP 5.4 compatibility with Xdebug I ran > into the case where zend_eval_string() no longer would

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/Zend/zend_execute_API.c trunk/Zend/zend_execute_API.c

2012-01-28 Thread Derick Rethans
Hi David, When I was just checking PHP 5.4 compatibility with Xdebug I ran into the case where zend_eval_string() no longer would bail out when you'd evalulate something that doesn't work (like a standalone "$this->property;" without being in a class scope). Xdebug has code (simplified) like t