Re: [PHP-DEV] Cherry picking #60560 for php 5.4

2013-06-29 Thread Lior Kaplan
On Fri, Jun 28, 2013 at 11:47 PM, Stas Malyshev wrote: > Hi! > > > Bug #60560 was fixed in trunk while PHP 5.4 was in its RC phases. The fix > > was never merged back to the 5.4 branch, meaning it's only avaailable on > > the 5.5 release. > > > > Could we cherry pick it for the 5.4 branch ? > > >

[PHP-DEV] Request for Comments: Use default_charset As Default Character Encoding

2013-06-29 Thread Yasuo Ohgaki
Hi all, I've updated almost a year old RFC. https://wiki.php.net/rfc/default_encoding?&#encoding_name_handling PoC patch is made. https://github.com/yohgaki/php-src/compare/master-unified-encoding-setting If you are interested in this, please post comments. Thank you. -- Yasuo Ohgaki yohg...@o

Re: [PHP-DEV] Re: hex2bin: E_WARNING is too much for odd string?

2013-06-29 Thread Lester Caine
Sherif Ramadan wrote: I see these as two separate problems. The first problem is clearly a design problem (but we can't really do much about that in the short term). One thing that came to mind when this first popped up was "Why isn't the string automatically zero padded?" Check my own uses I

Re: [PHP-DEV] Re: hex2bin: E_WARNING is too much for odd string?

2013-06-29 Thread Nikita Popov
On Sat, Jun 29, 2013 at 3:41 AM, Yasuo Ohgaki wrote: > Hi Sherif, > > The problem is that current code 'returns false for invalid hex' while it > 'returns false and E_WARNING for invalid length'. > > We may choose behavior for invalid inputs > - return false always > - return false and raise E_