Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

2014-09-21 Thread Pierre Joye
hi Kris, On Sat, Sep 20, 2014 at 4:15 AM, Kris Craig wrote: > Per discussion in an earlier thread. Here's the RFC: > > https://wiki.php.net/rfc/checkdnsrr-default-type > > > Basically, this RFC seeks to make it so that PHP's checkdnsrr() function, > which is most commonly used to see whether or

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-09-21 Thread Dmitry Stogov
Hi Anatol, I didn't completely get your ideas, but if tsrm_ls_cache can't be exported on Windows directly, can we have a copy of tsrm_ls_cache in each DLL/EXE and initialize it once? Thanks. Dmitry. On Sun, Sep 21, 2014 at 9:19 PM, Anatol Belski wrote: > Hi Dmitry, > > On Sat, September 20, 2

Re: [PHP-DEV] [VOTE][RFC] Integer Semantics

2014-09-21 Thread Andrea Faulds
On 21 Sep 2014, at 22:49, Peter Cowburn wrote: > It is closed now. > > The vote is closed now, fact. That does not prevent further (hopefully > productive) discussion from happening, and it also doesn’t stipulate that the > RFC must be merged. The RFC is merged. I suppose you could revert

Re: [PHP-DEV] Request #67949 DOMNodeList should implement ArrayAccess

2014-09-21 Thread Andrea Faulds
On 21 Sep 2014, at 22:43, Peter Cowburn wrote: > The DOM has a very specific API that we should be keeping to, and > encouraging developers to use. This is true and we should keep doing this. > I’d *much* rather see the DOM implementation completed (check out all of > the “not implemented” par

Re: [PHP-DEV] [VOTE][RFC] Integer Semantics

2014-09-21 Thread Peter Cowburn
On 21 September 2014 04:53, Pierre Joye wrote: > On Sep 21, 2014 10:48 AM, "Xinchen Hui" wrote: > > > > On Sun, Sep 21, 2014 at 11:33 AM, Pierre Joye > wrote: > > > Hi, > > > On Sep 21, 2014 10:08 AM, "Xinchen Hui" wrote: > > >> > > >> On Sun, Sep 21, 2014 at 11:03 AM, Andrea Faulds wrote: >

Re: [PHP-DEV] Request #67949 DOMNodeList should implement ArrayAccess

2014-09-21 Thread Peter Cowburn
On 21 September 2014 12:39, Florian Margaine wrote: > Hi list, > > The request is so that we can do this: > > $html = << data > HTML; > $doc = new DOMDocument; > $doc->loadHTML($html); > var_dump($doc->getElementsByTagName('div')[0]->textContent); > > I started implementing this on my branch ( >

Re: [PHP-DEV] Re: Renaming type-hints to something else?

2014-09-21 Thread Thomas Gutbier
Am 17.09.2014 um 16:43 schrieb Levi Morrison: class ReflectionType Methods: ReflectionFunction::hasReturnType ReflectionFunction::getReturnType ReflectionParameter::hasType ReflectionParameter::getType This looks most straightforward to me while I dont see any benefit by adding some

Re: [PHP-DEV] Renaming type-hints to something else?

2014-09-21 Thread Thomas Gutbier
Am 20.09.2014 um 15:05 schrieb Levi Morrison: On Fri, Sep 19, 2014 at 7:58 AM, wrote: What's about "Typed Arguments"? I am proposing return types which are not arguments, so that would be too narrow. Sorry, I have mistaken that related to the recently discussion about return types. Otherw

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fix CG(empty_string) init in ZTS: Zend/zend.c

2014-09-21 Thread Anatol Belski
Hi Dmitry, On Sat, September 20, 2014 09:58, Anatol Belski wrote: > Hi Dmitry, > > > On Fri, September 19, 2014 12:43, Dmitry Stogov wrote: > >> I know :) >> Interned strings in PHP5 were implemented as characters allocated in one >> single buffer. Adding new strings into this buffer from differe

[PHP-DEV] Re: [RFC] Loop... or...

2014-09-21 Thread Leigh
Completed my proof of concept patch: https://github.com/lt/php-src/compare/loop-or This gives for, foreach, and while loops an additional "or {}" block -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Request #67949 DOMNodeList should implement ArrayAccess

2014-09-21 Thread Florian Margaine
Hi list, The request is so that we can do this: $html = <loadHTML($html); var_dump($doc->getElementsByTagName('div')[0]->textContent); I started implementing this on my branch ( https://github.com/Ralt/php-src/tree/issue-67949), but then I was thinking..

[PHP-DEV] ext/date arguments handling

2014-09-21 Thread Florian Margaine
Hi list, I specifically mean to ask @derick about this issue I'm having, since he is the maintainer of ext/date. I wrote this pull request for the DateTimeZone::getOffset method to accept a DateTimeInterface instead of a DateTime object: https://github.com/php/php-src/pull/831 Instead of using Z

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

2014-09-21 Thread Kris Craig
I checked and it looks like E_WARNING is what we currently throw for that. Should we consider changing that to E_ERROR? I mean, if a function *requires* an argument that's missing, I don't think we'd want that script execution to continue. What's the reasoning behind the current behavior of just

[PHP-DEV] #68049 filter_var echo wrong result for a url

2014-09-21 Thread Florian Margaine
Hi, According to https://bugs.php.net/bug.php?id=51192 , valid URLs cannot contain underscores. The following bug was reported a couple days ago: https://bugs.php.net/bug.php?id=68049 The thing is, browsers *do* accept the underscore in URLs. Should the rfc3986

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

2014-09-21 Thread Lester Caine
On 20/09/14 12:51, Rowan Collins wrote: > On 20/09/2014 10:17, Lester Caine wrote: >> That most of my spare time is still being taken up >> living with the consequences of changes in PHP is water under the bridge >> now [...] PLEASE can we get >> back to a level playing field and use PHP7 as a base