Re: [PHP-DEV] bug35437.php fails on master?

2015-07-27 Thread Stanislav Malyshev
Hi! > it should be fixed in > https://github.com/php/php-src/commit/16d6dfddef5ac43de3b20ffa7818d5b11f4e6a4b Looks ok to me now, thanks. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] bug35437.php fails on master?

2015-07-27 Thread Xinchen Hui
Hey: On Tue, Jul 28, 2015 at 1:50 AM, Ferenc Kovacs wrote: > > > On Mon, Jul 27, 2015 at 6:57 PM, Stanislav Malyshev > wrote: >> >> Hi! >> >> I've build current master branch and I get segfault on bug35437.phpt. >> Doesn't happen with PHP-7.0.0 branch. Anybody did anything there that >> may ha

Re: [PHP-DEV] json_decode/encode should return full precision values by default

2015-07-27 Thread Stanislav Malyshev
Hi! > JSON is var exporter/importer like serialize/var_export. > > Both of serialize/var_export uses PG(serialize_precision), what's the > point of > _lose_ / _destroy_ original values while PHP could keep more precise values > than now? So you're saying JSON should use serialize_precision setti

Re: [PHP-DEV] json_decode/encode should return full precision values by default

2015-07-27 Thread Yasuo Ohgaki
Hi all, On Tue, Jul 28, 2015 at 9:34 AM, Stanislav Malyshev wrote: > > > > We can write > > > > $old = ini_set('precision', 17); > > json_encode($var); > > ini_set('precision', $old); > > > > everywhere to workaround this problem. > > If we're talking about encoding, that's what precision settin

Re: [PHP-DEV] json_decode/encode should return full precision values by default

2015-07-27 Thread Stanislav Malyshev
Hi! > > We can write > > $old = ini_set('precision', 17); > json_encode($var); > ini_set('precision', $old); > > everywhere to workaround this problem. If we're talking about encoding, that's what precision setting is - it says how much we want to preserve in decimal encoding of float numbers.

Re: [PHP-DEV] json_decode/encode should return full precision values by default

2015-07-27 Thread Yasuo Ohgaki
On Tue, Jul 28, 2015 at 7:10 AM, Yasuo Ohgaki wrote: > On Tue, Jul 28, 2015 at 6:54 AM, Anthony Ferrara > wrote: > >> On Sun, Jul 26, 2015 at 4:20 PM, Yasuo Ohgaki wrote: >> > Hi Jakub, >> > >> > On Mon, Jul 27, 2015 at 3:32 AM, Jakub Zelenka wrote: >> > >> >> I don't think that this is a bug.

Re: [PHP-DEV] json_decode/encode should return full precision values by default

2015-07-27 Thread Yasuo Ohgaki
Hi Anthony, On Tue, Jul 28, 2015 at 6:54 AM, Anthony Ferrara wrote: > On Sun, Jul 26, 2015 at 4:20 PM, Yasuo Ohgaki wrote: > > Hi Jakub, > > > > On Mon, Jul 27, 2015 at 3:32 AM, Jakub Zelenka wrote: > > > >> I don't think that this is a bug. Your example is also completely > >> unrelated to js

Re: [PHP-DEV] json_decode/encode should return full precision values by default

2015-07-27 Thread Anthony Ferrara
Yasuo, On Sun, Jul 26, 2015 at 4:20 PM, Yasuo Ohgaki wrote: > Hi Jakub, > > On Mon, Jul 27, 2015 at 3:32 AM, Jakub Zelenka wrote: > >> I don't think that this is a bug. Your example is also completely >> unrelated to json because the place when the value is rounded is var_dump >> where it's base

Re: [PHP-DEV] json_decode/encode should return full precision values by default

2015-07-27 Thread Jakub Zelenka
Hi Yasuo, On Sun, Jul 26, 2015 at 9:20 PM, Yasuo Ohgaki wrote: > Hi Jakub, > > On Mon, Jul 27, 2015 at 3:32 AM, Jakub Zelenka wrote: > >> I don't think that this is a bug. Your example is also completely >> unrelated to json because the place when the value is rounded is var_dump >> where it's

Re: [PHP-DEV] Core functions throwing exceptions in PHP7

2015-07-27 Thread Anthony Ferrara
Rowan, > This is certainly some people's concern, but Anatol has raised a subtly > different consistency-related point, which is this: > > Since we have no policy for what kinds of Throwable should be emitted in > what circumstance, throwing anything in this function sets a precedent which > will

Re: [PHP-DEV] Core functions throwing exceptions in PHP7

2015-07-27 Thread Rowan Collins
Scott Arciszewski wrote on 27/07/2015 18:35: I understand that some of the Internals contributors are allergic to special cases. There's some validity to wanting the language to be predictable and consistent across the board, because that might be a UX concern in and of itself. (What do you mean

Re: [PHP-DEV] bug35437.php fails on master?

2015-07-27 Thread Ferenc Kovacs
On Mon, Jul 27, 2015 at 6:57 PM, Stanislav Malyshev wrote: > Hi! > > I've build current master branch and I get segfault on bug35437.phpt. > Doesn't happen with PHP-7.0.0 branch. Anybody did anything there that > may have caused this? > -- > Stas Malyshev > smalys...@gmail.com > > -- > PHP Intern

Re: [PHP-DEV] Core functions throwing exceptions in PHP7

2015-07-27 Thread Scott Arciszewski
On Mon, Jul 27, 2015 at 1:04 PM, Rowan Collins wrote: > Scott Arciszewski wrote on 27/07/2015 15:45: >> >> The problem with fatal errors is that "This function can fail >> irrecoverably outside of your control" isn't going to encourage >> adoption. > > > Well... rats! ;) > > It seems whatever we d

Re: [PHP-DEV] Core functions throwing exceptions in PHP7

2015-07-27 Thread Rowan Collins
Scott Arciszewski wrote on 27/07/2015 15:45: The problem with fatal errors is that "This function can fail irrecoverably outside of your control" isn't going to encourage adoption. Well... rats! ;) It seems whatever we do here is going to carry some kind of risk / downside. :( -- PHP Intern

[PHP-DEV] bug35437.php fails on master?

2015-07-27 Thread Stanislav Malyshev
Hi! I've build current master branch and I get segfault on bug35437.phpt. Doesn't happen with PHP-7.0.0 branch. Anybody did anything there that may have caused this? -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.ph

[PHP-DEV] Re: use https when downloading the pear installer

2015-07-27 Thread Ferenc Kovacs
On Mon, Jul 27, 2015 at 5:46 PM, Hannes Magnusson wrote: > On Mon, Jul 27, 2015 at 12:32 AM, Ferenc Kovacs wrote: > > Hi, > > > > I've just realized that even thought https://pear.php.net/ is > available, we > > are still downloading the install-pear-nozlib.phar via http:// in > > pear/Makefile.

[PHP-DEV] Re: use https when downloading the pear installer

2015-07-27 Thread Hannes Magnusson
On Mon, Jul 27, 2015 at 12:32 AM, Ferenc Kovacs wrote: > Hi, > > I've just realized that even thought https://pear.php.net/ is available, we > are still downloading the install-pear-nozlib.phar via http:// in > pear/Makefile.frag and makedist > Do you happen to know any reason for keeping it that

Re: [PHP-DEV] Core functions throwing exceptions in PHP7

2015-07-27 Thread Scott Arciszewski
On Mon, Jul 27, 2015 at 10:27 AM, Rowan Collins wrote: > Scott Arciszewski wrote on 27/07/2015 07:57: >> >> My only concern is that, we have a fixed timetable for the 7.0.0 >> release. It's certainly a good idea to develop a cogent strategy >> before moving forward, but I worry that bikeshedding w

Re: [PHP-DEV] Core functions throwing exceptions in PHP7

2015-07-27 Thread Rowan Collins
Scott Arciszewski wrote on 27/07/2015 07:57: My only concern is that, we have a fixed timetable for the 7.0.0 release. It's certainly a good idea to develop a cogent strategy before moving forward, but I worry that bikeshedding will get involved and we won't make the deadline. I propose that, if

Re: [PHP-DEV] Re: Serializing exceptions

2015-07-27 Thread Rowan Collins
Stas Malyshev wrote on 27/07/2015 08:08: Since discussion on this did not lead to a definite conclusion, but I did not hear from anybody that they need serialized exceptions, and we keep getting bug reports about exception serialization and various issues triggered by it, I propose this change: h

RE: [PHP-DEV] PCRE JIT stack size limit

2015-07-27 Thread Anatol Belski
Hi Christoph, > -Original Message- > From: Christoph Becker [mailto:cmbecke...@gmx.de] > Sent: Monday, July 27, 2015 12:06 AM > To: Anatol Belski ; 'Pierre Joye' > > Cc: 'PHP internals' > Subject: Re: [PHP-DEV] PCRE JIT stack size limit > > Definitely interesting ideas. However, curren

[PHP-DEV] Benchmark Results for PHP Master 2015-07-27

2015-07-27 Thread lp_benchmark_robot
Results for project php-src-nightly, build date 2015-07-27 11:33:18+03:00 commit: b17ecc1e0212bb22e9bcfd701ab1a5e873c5 revision_date:2015-07-27 11:19:58+08:00 environment: Haswell-EP cpu: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

RE: [PHP-DEV] Core functions throwing exceptions in PHP7

2015-07-27 Thread Anatol Belski
Hi Scott, > -Original Message- > From: Scott Arciszewski [mailto:sc...@paragonie.com] > Sent: Monday, July 27, 2015 8:58 AM > To: Anatol Belski > Cc: Aaron Piotrowski ; Sammy Kaye Powers > ; Larry Garfield ; Jakub Kubíček > ; Stanislav Malyshev ; > rowan.coll...@gmail.com; Pierre Joye ; D

[PHP-DEV] use https when downloading the pear installer

2015-07-27 Thread Ferenc Kovacs
Hi, I've just realized that even thought https://pear.php.net/ is available, we are still downloading the install-pear-nozlib.phar via http:// in pear/Makefile.frag and makedist Do you happen to know any reason for keeping it that way or is this only for historical reasons (maybe pear.php.net did

[PHP-DEV] Re: Serializing exceptions

2015-07-27 Thread Stas Malyshev
Hi! Looking into some issue, I've discovered that, to my surprise, > Exceptions are serializable. Except that it doesn't always work of > course (e.g. see http://stackoverflow.com/q/9747813/214196) because > exceptions contain backtraces, and those can contain non-serializable > objects. So in rea