Re: [PHP-DEV] Fixing ldap_connect documentation

2015-11-04 Thread Côme Chilliet
Does this seems correct? https://github.com/php/php-src/pull/1618 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] One last ldap_connect headache

2015-11-04 Thread Côme Chilliet
Le mercredi 4 novembre 2015, 21:41:20 Bishop Bettini a écrit : > > If one wanted truly robust (paranoid) code, you'd probably want to do: > > $port = getservbyname('ldap', 'tcp'); > > if (isset($options['port']) && is_numeric($options['port'])) > $port = intval($options['port']); > > $resou

Re: [PHP-DEV] Fixing ldap_connect documentation

2015-11-04 Thread Côme Chilliet
Le mercredi 4 novembre 2015, 21:10:09 Bishop Bettini a écrit : > > - Second parameter is not used if the first one is an LDAP scheme, so > > calling ldap_connect('ldap://localhost', 456) will use default port 389. > > > > I'd prefer this raise a notice, like "Second argument ignored when using > U

Re: [PHP-DEV] One last ldap_connect headache

2015-11-04 Thread Bishop Bettini
On Tue, Nov 3, 2015 at 11:13 PM, Côme Chilliet wrote: > I got mail from someone saying that in previous version, calling > ldap_connect($host, NULL) would use default port. > While now it is considered as trying to use port 0 and trigger an error. > I believe the current behavior (interpret as z

Re: [PHP-DEV] Fixing ldap_connect documentation

2015-11-04 Thread Bishop Bettini
On Tue, Nov 3, 2015 at 11:00 PM, Côme Chilliet wrote: > What should be clear in the documentation : > - The LDAP URI scheme is the recommended way to call ldap_connect > - The ldap:// or ldaps:// is required > - People can use host, port if they do not need SSL > Agreed. > - Second parameter i

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove arc4random: ext/standard/config.m4 ext/standard/random.c

2015-11-04 Thread Tom Worster
On 11/2/15, 9:07 AM, "Anthony Ferrara" wrote: >Tom, > >> 3. arc4random puts a generator in the user process. >> >> This is much more controversial. Some people (Anthony F. for one and >>myself >> until recently) argue that a generator algorithm in the user process >> degrades security. It must in

[PHP-DEV] Benchmark Results for PHP Master 2015-11-04

2015-11-04 Thread lp_benchmark_robot
Results for project PHP master, build date 2015-11-04 05:26:46+02:00 commit: a4a767e6da477ae84e1c7e442fef64f99a4dbbc4 revision date: 2015-11-03 17:56:05-08:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB mem

Re: [PHP-DEV] Bug #70805 (Segmentation faults whilst running Drupal 8 test suite)

2015-11-04 Thread Paul Dragoonis
Hey Bob, Thanks, it was 2am and quite sleepy so wasn't considering the gen'd files. Thanks for clarifying! On Wed, Nov 4, 2015 at 2:26 AM, Bob Weinand wrote: > Hey, > > zend_vm_execute.h is an auto-generated file, via zend_vm_gen.php. In > reality the patch only fixes the code in exactly one l