Re: [PHP-DEV] bug classification discussion

2016-10-31 Thread Joe Watkins
Morning, I did review and reformat the document, so that we have lists ... lists of things are easier to retain in memory than paragraphs of things :) Feel free to review the review. Cheers Joe On Tue, Nov 1, 2016 at 1:47 AM, Anatol Belski wrote: > Hi Stas, > > > -Original Message

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread Yasuo Ohgaki
Hi David and all, On Tue, Nov 1, 2016 at 11:53 AM, David Lundgren wrote: > What if we made ArrayIterator transparently wrap all array's? If you take a look at SPL array object code, you'll see why there are so many missing functions. It's just pain for me to write new method even with simple one

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread Yasuo Ohgaki
Hi Larry, On Tue, Nov 1, 2016 at 6:49 AM, Larry Garfield wrote: > Might it make sense then to have > > first(iterable) > first_key(iterable) > array_last(array) > array_last_key(array) array_ prefix is required for all new array functions, IMHO. I don't have strong opinion for iter_ prefix for

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread David Lundgren
On 10/31/16 4:49 PM, Larry Garfield wrote: > If we're concerned about pw0ning the "first" function name, perhaps it's > time to start a new prefix: > > iter_first(iterable) > iter_first_key(iterable) > array_last(array) > array_last_key(array) > > Which gives a natural place to start putting iter

Re: [PHP-DEV] Re: Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread David Lundgren
On 10/31/16 9:02 AM, Andrea Faulds wrote: > > A concern that strikes me is that it's possible some existing code uses > these functions precisely because they don't support Iterators, because > the author wants to iterate over an object's properties. > I hadn't thought about that particular use

RE: [PHP-DEV] bug classification discussion

2016-10-31 Thread Anatol Belski
Hi Stas, > -Original Message- > From: Stanislav Malyshev [mailto:smalys...@gmail.com] > Sent: Sunday, October 30, 2016 6:21 AM > To: Anatol Belski ; 'PHP Internals' > > Cc: 'Remi Collet' > Subject: Re: [PHP-DEV] bug classification discussion > > Hi! > > So I wrote a first version of th

RE: [PHP-DEV] Security issue handling

2016-10-31 Thread Anatol Belski
Hi Stas, > -Original Message- > From: Stanislav Malyshev [mailto:smalys...@gmail.com] > Sent: Sunday, October 30, 2016 11:01 PM > To: Anatol Belski ; 'PHP Internals' > > Subject: Re: [PHP-DEV] Security issue handling > > Hi! > > > release. Say, as we do it now, we tag two days before. I

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread Larry Garfield
On 10/31/2016 01:07 PM, Levi Morrison wrote: On Mon, Oct 31, 2016 at 11:57 AM, Levi Morrison wrote: On Mon, Oct 31, 2016 at 11:27 AM, Larry Garfield wrote: Question: Now that we have "iterable" as a type, should we be adding more array-specific functions or should such operations be designed,

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset,key functions

2016-10-31 Thread Christoph M. Becker
On 31.10.2016 at 18:27m Larry Garfield wrote: > On 10/31/2016 11:26 AM, Alice Wonder wrote: > >> On 10/30/2016 10:19 AM, Rowan Collins wrote: >> >>> - deprecate reset(), end(), each(), and key() >>> - introduce array_first(), array_last(), array_first_key() and >>> array_last_key() >>> - document

[PHP-DEV] [VOTE] Debugging PDO Prepared Statement Emulation

2016-10-31 Thread Adam Baratz
Hi, Two weeks have passed since posting this RFC: https://wiki.php.net/rfc/debugging_pdo_prepared_statement_emulation There's been some discussion on this list: http://marc.info/?l=php-internals&m=147638162506291&w=2 http://marc.info/?l=php-internals&m=147734024403899&w=2 http://marc.info/?l=php-

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread Levi Morrison
On Mon, Oct 31, 2016 at 11:57 AM, Levi Morrison wrote: > On Mon, Oct 31, 2016 at 11:27 AM, Larry Garfield > wrote: >> On 10/31/2016 11:26 AM, Alice Wonder wrote: >>> >>> On 10/30/2016 10:19 AM, Rowan Collins wrote: >>> - deprecate reset(), end(), each(), and key() - introduce arra

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread Levi Morrison
On Mon, Oct 31, 2016 at 11:27 AM, Larry Garfield wrote: > On 10/31/2016 11:26 AM, Alice Wonder wrote: >> >> On 10/30/2016 10:19 AM, Rowan Collins wrote: >> >>> >>> - deprecate reset(), end(), each(), and key() >>> - introduce array_first(), array_last(), array_first_key() and >>> array_last_key()

Re: [PHP-DEV] [RFC] Debugging PDO Prepared Statement Emulation

2016-10-31 Thread Adam Baratz
> > There's value in improving tests for emulated prepares, but as I stated > somewhere else, I would rather see them deprecated and removed rather > than encouraged. > I left a note about this in the "Future Scope" section[1]. If we deprecate emulated prepares, it would make sense to deprecate PD

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread Larry Garfield
On 10/31/2016 11:26 AM, Alice Wonder wrote: On 10/30/2016 10:19 AM, Rowan Collins wrote: - deprecate reset(), end(), each(), and key() - introduce array_first(), array_last(), array_first_key() and array_last_key() - document replacements for whatever other use cases we can find examples of

[PHP-DEV] New PHP SDK for Windows

2016-10-31 Thread Anatol Belski
Hi, I'm working on the new Windows PHP SDK. So far, some usable alpha state is reached. It is compatible with PHP-7.0 and the current SDK and contains additional new features. The essential changes in the new SDK are - starter scripts included, making the environment setup easier - updated tools,

Re: [PHP-DEV] [VOTE] Deprecate png2wbmp() and jpeg2wbmp()

2016-10-31 Thread Christoph M. Becker
On 30.10.2016 at 22:37, Alice Wonder wrote: > On 10/30/2016 02:30 PM, Christoph M. Becker wrote: > >> As there has been no discussion in the RFC's discussion thread[1], I >> assume there is nothing to discuss, so I've just put the "Deprecate >> png2wbmp() and jpeg2wbmp()" RFC[2] to voting. The vo

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread Alice Wonder
On 10/30/2016 10:19 AM, Rowan Collins wrote: - deprecate reset(), end(), each(), and key() - introduce array_first(), array_last(), array_first_key() and array_last_key() - document replacements for whatever other use cases we can find examples of As a user I certainly like those names bette

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset,key functions

2016-10-31 Thread Christoph M. Becker
On 30.10.2016 at 18:19, Rowan Collins wrote: > On 30/10/2016 12:07, Fleshgrinder wrote: > >> I think it makes much more sense to deprecate all of them and introduce >> new ones that work in the way we want them to for several reasons. >> `end()` and `reset()` would have to continue working as they

Re: [PHP-DEV] Allow Iterator to be used with current, next, reset,key functions

2016-10-31 Thread Andrea Faulds
Hi Nikita, Nikita Popov wrote: On Fri, Oct 28, 2016 at 2:43 PM, Levi Morrison wrote: I can't seem to recall specifics anymore but I do believe some people would greatly prefer to remove the internal array pointer for iteration and deprecate these functions. Maybe someone else can remember mor

[PHP-DEV] Re: Allow Iterator to be used with current, next, reset, key functions

2016-10-31 Thread Andrea Faulds
Hi David, David Lundgren wrote: As suggested by several reviewers of a PR[1] I recently submitted, I'd like to get feedback on letting custom Iterators be used in the current, next, reset, and key functions. If this is something to move forward with, I'll need some help with the RFC process. Re

[PHP-DEV] UGLY Benchmark Results for PHP Master 2016-10-31

2016-10-31 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-10-31 06:25:00+02:00 commit: 4f40cf1 previous commit:c1e3fa4 revision date: 2016-10-30 17:12:21-07:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC] Debugging PDO Prepared Statement Emulation

2016-10-31 Thread Matteo Beccati
Hi Adam, On 17/10/2016 21:28, Adam Baratz wrote: > Hi, > > I've created an RFC to make it easier to work with emulated prepared > statements: > https://wiki.php.net/rfc/debugging_pdo_prepared_statement_emulation > > Based on feedback from a previous thread[1], I added some context and added > tw