[PHP-DEV] [RESULT] Convert numeric keys in object/array casts

2016-11-14 Thread Andrea Faulds
Hi everyone, Voting on the Convert numeric keys in object/array casts RFC has now ended. There were 21 votes in favour and 1 against, which is a greater than 2/3 majority in favour, and so the RFC has been accepted for PHP 7.2. The RFC (including voting details) can be found here: https://wi

[PHP-DEV] Update to SQLite 3.15.1

2016-11-14 Thread Christoph M. Becker
Hi! SQLite 3.15.1[1], which is a bug-fix release, has been released. Therefore I have updated the bundled libsqlite in master and PHP 7.1. Running the test suites of ext/sqlite3 and ext/pdo_sqlite on Windows and Linux, both x64, didn't show any regression. Davey, Joe, if you're uncomfortable wit

[PHP-DEV] GOOD Benchmark Results for PHP Master 2016-11-14

2016-11-14 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-11-14 06:25:48+02:00 commit: 189bbb5 previous commit:0d25376 revision date: 2016-11-13 23:31:40+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] How to detect classes with a count_elements handler in userland?

2016-11-14 Thread Christoph M. Becker
On 13.11.2016 at 22:10, Craig Duncan wrote: >> How about just making those classes implement the interface instead? > > Christoph pointed out that there may be classes in extensions that use > count_elements. Furthermore, letting those classes implement Countable could break BC. > Also it would

Re: [PHP-DEV] [RFC][VOTE] Object typehint

2016-11-14 Thread Michał Brzuchalski
Yes, function/method arguments should be contravariant. I'm sorry I haven't got caught anyone to review after Joe's patch. I promise to remember about that next time. 2016-11-14 10:20 GMT+01:00 Josh Di Fabio : > On Mon, Nov 14, 2016 at 8:54 AM Michał Brzuchalski > wrote: > >> Hi All, >> >> Id'

Re: [PHP-DEV] [RFC][VOTE] Object typehint

2016-11-14 Thread Josh Di Fabio
On Mon, Nov 14, 2016 at 8:54 AM Michał Brzuchalski wrote: > Hi All, > > Id' like to anounce voting reset - will end in two weeks on 28.11.2016 at > midnight and requires 2/3 majority as previously. > > There were improvements suggested by Joe Watkins and earlier by Nikita > Popov to the patch. >

Re: [PHP-DEV] [RFC][VOTE] Object typehint

2016-11-14 Thread Joe Watkins
Sorry people, my fault :( On Mon, Nov 14, 2016 at 9:16 AM, Michał Brzuchalski wrote: > Hi All, > > again with bad news, sorry for the mess, the argument override is allowed > in wrong direction what beaks Liskov's principle so need to stop it again. > Hold on for a while, don't loose faith. > >

Re: [PHP-DEV] [RFC][VOTE] Object typehint

2016-11-14 Thread Michał Brzuchalski
Hi All, again with bad news, sorry for the mess, the argument override is allowed in wrong direction what beaks Liskov's principle so need to stop it again. Hold on for a while, don't loose faith. regards, Michał 2016-11-14 9:53 GMT+01:00 Michał Brzuchalski : > Hi All, > > Id' like to anounce v

Re: [PHP-DEV] [RFC][VOTE] Object typehint

2016-11-14 Thread Michał Brzuchalski
Hi All, Id' like to anounce voting reset - will end in two weeks on 28.11.2016 at midnight and requires 2/3 majority as previously. There were improvements suggested by Joe Watkins and earlier by Nikita Popov to the patch. Those improvements are described on RFC under "Covariance" section https: