[PHP-DEV] Re: bugsnet cleanup

Hi Joe, W dniu 08.01.2017 o 07:46, Joe Watkins pisze: Morning internals, Some of you may have noticed that a few of us have put considerable effort into cleanup of pull requests on github, these are now manageable and I'm quite confident that we will be able to merge pull requests in a timely m

[PHP-DEV] bugsnet cleanup

Morning internals, Some of you may have noticed that a few of us have put considerable effort into cleanup of pull requests on github, these are now manageable and I'm quite confident that we will be able to merge pull requests in a timely manner, and stay on top of it. When it comes to bugsnet,

Re: [PHP-DEV] SimpleXML's atXPath method

Hey all, Is there a major issue with simply adding a $limit parameter to the existing xpath() method instead, and stopping searching after that many elements are found? Cheers Stephen Sent from my iPhone > On 8 Jan 2017, at 06:19, Joe Watkins wrote: > > Evening Rowan, > > Thank you. >

Re: [PHP-DEV] [RFC] Deprecate and remove INTL_IDNA_VARIANT_2003

On Sat, Jan 7, 2017 at 6:06 AM, Christoph M. Becker wrote: > Following up on , I have > written the RFC > > > > and hereby placing it under discussion. > > I appreciate reviews and com

Re: [PHP-DEV] SimpleXML's atXPath method

Evening Rowan, Thank you. Now we can get to the really hard problem ... naming things :D I'm afraid I have no good suggestions. I can find API's that use the suggested name, but they vary in functionality (some overlap). There's also XmlNode.SelectSingleNode from C#, but sounds pretty horrible

Re: [PHP-DEV] SimpleXML's atXPath method

On 07/01/2017 19:29, Joe Watkins wrote: Evening Roawn, There is no competition to see which single problem we are going to solve, we can fix more than one thing, obviously :) What we are discussing here is the value of this particular feature, not the value of things that nobody has taken th

[PHP-DEV] Improving mail() 5th parameter handling

Hi all, All of us knew details of PHPMailer and Swift Mailer issues with mail()'s 5th (additional_parameters) parameter by now, I suppose. Current behavior (applying php_escape_shell_cmd to addtional_parameters) is not nice and similar issue may raise with addtional_parameters in the future. The

Re: [PHP-DEV] [RFC][Discussion] ServerRequest and ServerResponse objects

Evening Paul, > My apologies for giving you cause to be surprised. I thought I had broadcast my intentions back in September but obviously I failed. My bad. The point of an internals discussion is to gather consensus that an RFC is a good idea; let us lo

Re: [PHP-DEV] [RFC][Discussion] ServerRequest and ServerResponse objects

Hi all, Replying to both Marco Pivetta and Joe Watkins here, as some of their critiques overlap. I apologize in advance for the length of this email. * * * On Jan 6, 2017, at 10:47, Marco Pivetta wrote: > Bundling the [PSR-7] interface is no biggie, so I suggest steering away and > going tha

Re: [PHP-DEV] Use decent entropy for uniqid($prefix, TRUE)

Hi Niklas, On Sun, Jan 8, 2017 at 4:08 AM, Niklas Keller wrote: > 2017-01-07 2:15 GMT+01:00 Yasuo Ohgaki : > >> Hi Lauri, >> >> On Wed, Jan 4, 2017 at 4:56 AM, Lauri Kenttä >> wrote: >> >> > On 2016-12-31 01:20, Yasuo Ohgaki wrote: >> > >> >> + zend_long rand; >> >> +

Re: [PHP-DEV] SimpleXML's atXPath method

Evening Roawn, There is no competition to see which single problem we are going to solve, we can fix more than one thing, obviously :) What we are discussing here is the value of this particular feature, not the value of things that nobody has taken the time to propose, implement, or fix. This c

Re: [PHP-DEV] Use decent entropy for uniqid($prefix, TRUE)

2017-01-07 2:15 GMT+01:00 Yasuo Ohgaki : > Hi Lauri, > > On Wed, Jan 4, 2017 at 4:56 AM, Lauri Kenttä > wrote: > > > On 2016-12-31 01:20, Yasuo Ohgaki wrote: > > > >> + zend_long rand; > >> + php_random_int(10, 99, &rand, 1); > >> + uniqid

Re: [PHP-DEV] Fwd: Monotonic Time

> > Hi! > > > I think we can reuse parts of it to implement a function in core to > access > > a monotonic time, I don't think we need to merge the extension into core. > > What's wrong with just having an extension? > Do you mean an external (not bundled) extension? Simply not having it availabl

Re: [PHP-DEV] SimpleXML's atXPath method

On 07/01/2017 17:01, Joe Watkins wrote: Evening Rowan, I must protest: It is wasteful, unclear, and generally nasty, to create, return, and manipulate an array if you are only ever going to reference one element in code. Meh, feels like a micro-optimisation to me, and "[0] to access first s

Re: [PHP-DEV] SimpleXML's atXPath method

2017-01-07 18:01 GMT+01:00 Joe Watkins : > Evening Rowan, > > I must protest: It is wasteful, unclear, and generally nasty, to create, > return, and manipulate an array if you are only ever going to reference one > element in code. > > It is quite normal to know the structure of a document ahead of

Re: [PHP-DEV] ext/sqlite3 module version

Hi Christoph 2017-01-07 18:32 GMT+01:00 Christoph M. Becker : > Hi! > > I've just noticed that ext/sqlite3 reports the following in the PHP info > (all version incl. current master): > > SQLite3 module version: 0.7-dev > > That's obviously a relict of when PECL/sqlite3 has been moved to > ext/sq

[PHP-DEV] ext/sqlite3 module version

Hi! I've just noticed that ext/sqlite3 reports the following in the PHP info (all version incl. current master): SQLite3 module version: 0.7-dev That's obviously a relict of when PECL/sqlite3 has been moved to ext/sqlite3 in 2008, and has since been forgotten about. I don't think that having

Re: [PHP-DEV] SimpleXML's atXPath method

Evening Rowan, I must protest: It is wasteful, unclear, and generally nasty, to create, return, and manipulate an array if you are only ever going to reference one element in code. It is quite normal to know the structure of a document ahead of time, and this would allow you to write more succinc

Re: [PHP-DEV] [RFC] Deprecate and remove INTL_IDNA_VARIANT_2003

Evening Christoph, +1, and good catch noticing the upstream change. Cheers Joe On Sat, Jan 7, 2017 at 2:06 PM, Christoph M. Becker wrote: > Hi! > > Following up on , I have > written the RFC > >

Re: [PHP-DEV] SimpleXML's atXPath method

On 06/01/2017 14:03, Willian Veiga wrote: Hello, What do you think about a new method, called atXPath, that would return a single SimpleXMLElement? Details: https://github.com/php/php-src/pull/1717 https://bugs.php.net/bug.php?id=45201 Thank you, Willian. My first thought on this was "what

[PHP-DEV] [RFC] Deprecate and remove INTL_IDNA_VARIANT_2003

Hi! Following up on , I have written the RFC and hereby placing it under discussion. I appreciate reviews and comments! -- Christoph M. Becker -- PHP Internals - PHP Runtime Dev

[PHP-DEV] array_filter(): by-ref parameter in callback

Hi! There's a patch by Jesse Donat in PhDOE which suggest to add the following info to the array_filter() man page: | As of PHP7 the value of the callback may no longer be used by | reference. Actually, it seems that declaring the callback parameter by-ref is allowed (i.e. doesn't raise a notice

Re: [PHP-DEV] [RFC][Discussion] ServerRequest and ServerResponse objects

Morning Paul, Regardless of the details of the implementation, I feel it necessary to point out that this is a surprising RFC. There are extensions that are absolutely a core part of the ecosystem that remain outside of php-src because that is where they belong. xdebug is one, apc was another, re