Re: [PHP-DEV] SHA3 is very slow

2017-04-01 Thread Yasuo Ohgaki
Hi Sara, On Sat, Apr 1, 2017 at 12:24 PM, Sara Golemon wrote: > On Fri, Mar 31, 2017 at 10:12 PM, Yasuo Ohgaki wrote: > > I noticed that our SHA-3 is inefficient. > > > Entirely possible. Feel free to improve it. :D I would like to, but it wouldn't

RE: [PHP-DEV] Directory separators on Windows

2017-04-01 Thread Anatol Belski
> -Original Message- > From: Fleshgrinder [mailto:p...@fleshgrinder.com] > Sent: Saturday, April 1, 2017 2:43 PM > To: Anatol Belski ; Rasmus Schultz > > Cc: PHP internals > Subject: Re: [PHP-DEV] Directory separators on

Re: [PHP-DEV] Directory separators on Windows

2017-04-01 Thread Rasmus Schultz
10 thumbs up ;-) But this really demonstrates how badly we need this function - I bet any number of those points may or may not be covered by any number of implementations in the wild. It would be so nice to have this done "right", once and for all. On Sat, Apr 1, 2017 at 2:42 PM, Fleshgrinder

[PHP-DEV] [RFC] Prevent number_format() from returning negative zero

2017-04-01 Thread Craig Duncan
Hi internals. Following a brief discussion on the behaviour of number_format() last year I'd like to start discussion around an RFC to bring consistency to negative zero. When number_format() is passed -0 it doesn't display the negative sign, however if it's passed something that rounds to -0

Re: [PHP-DEV] Directory separators on Windows

2017-04-01 Thread Fleshgrinder
On 4/1/2017 2:01 PM, Anatol Belski wrote: > 1. optionally - yes, otherwise it should do platform default > 2. no, this kind of operation is a pure parsing, no I/O related checks needed > 3. irrelevant, but can be defined > > Other points yet I'd care about > - result should be correct for target

RE: [PHP-DEV] Directory separators on Windows

2017-04-01 Thread Anatol Belski
Hi, > -Original Message- > From: Rasmus Schultz [mailto:ras...@mindplay.dk] > Sent: Saturday, April 1, 2017 11:13 AM > To: Pierre Joye > Cc: Kris Craig ; Sara Golemon ; PHP > internals > Subject: Re:

Re: [PHP-DEV] Directory separators on Windows

2017-04-01 Thread Fleshgrinder
On 4/1/2017 1:03 PM, Anatol Belski wrote: > " A Uniform Resource Identifier (URI) is a compact sequence of > characters that identifies an abstract or physical resource" they > say. Fits perfectly with PHP streams. > The problem I was referring to is not semantically. The problem is that the

RE: [PHP-DEV] Directory separators on Windows

2017-04-01 Thread Anatol Belski
> -Original Message- > From: Fleshgrinder [mailto:p...@fleshgrinder.com] > Sent: Saturday, April 1, 2017 12:00 AM > To: Anatol Belski ; internals@lists.php.net; Rasmus Schultz > > Subject: Re: [PHP-DEV] Directory separators on Windows > > On 3/31/2017

Re: [PHP-DEV] Directory separators on Windows

2017-04-01 Thread Fleshgrinder
On 4/1/2017 11:13 AM, Rasmus Schultz wrote: > So to summarize, a normalize_path() function should: > > 1. Fully normalize to an absolute path with no platform-specific separators > 2. Have corrected case (for files/dirs that do exist.) > 3. Have normalized (upper-case) drive-letter on Windows >

Re: [PHP-DEV] Directory separators on Windows

2017-04-01 Thread Rasmus Schultz
> Also ucfirst is useless (or any case operations) It's not useless, if you want a normalized path on Windows, it has to include a drive-letter, and Windows FS isn't case-sensitive. > Right now realpath will fail if the path does not exist I know, that's one reason I don't use it. It kind of