[PHP-DEV] hash_hkdf() signature and return value

2017-09-05 Thread Yasuo Ohgaki
Hi all, This is the last recommendation for hash_hkdf[1]. In fact, this would be the last chance to fix because we'll have 7.2 soon. The issue is secure usage and API consistency. Currently hash_hkdf() has following signature: hash_hkdf(string $algo , string $ikm [, int $length = 0 [, string $i

[PHP-DEV] BAD Benchmark Results for PHP Master 2017-09-05

2017-09-05 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-09-05 08:55:42-07:00 commit: 002856c previous commit:4cb06b9 revision date: 2017-09-05 17:18:54+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Sammy Kaye Powers
> Richard wrote: > Maybe I should stop the vote. The discussion is happening now instead of > before when I asked for it. I'm +1 for this because I'd love to see UUID's get added to PHP 7.3! :) Thanks, Sammy Kaye Powers sammyk.me -- PHP Internals - PHP Runtime Development Mailing List To unsubs

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Yasuo Ohgaki
Hi Rowan, Crocodile and Lester, Rowan, Thank you for helpful suggestions. I think it may better be named 'validate()'/etc. Sole reason I named functions as 'valid*()' is name collision. 'validate*()' seems too common, but users should use namespace to avoid collisions. I'll take your suggestions i

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Rowan Collins
On 5 September 2017 20:39:36 BST, Lester Caine wrote: >I've been pushing the idea of a single method of managing metadata for >a long time. > A single standard set of rules >that can be used across the board from variable creation to checking >data going out to forms and returns coming back and d

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Fleshgrinder
On 9/5/2017 9:32 PM, Andreas Heigl wrote: > I'm well aware of that and perhaps I didn't express myself as clear as I > should have. > > Imagine a use-case where a UUID-class is needed. But alongside the > toString, toHex and toBinary there's also the need for a further > function (let's call it to

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Lester Caine
On 05/09/17 20:05, Yasuo Ohgaki wrote: > There is one principle that developers is better to follow. > https://en.wikipedia.org/wiki/Fail-fast > If we follow this principle, validation at controller makes sense. Since a large proportion of the data coming in is a result of input into a previously g

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Andreas Heigl
Hey Richard Am 05.09.17 um 19:29 schrieb Fleshgrinder: > On 9/5/2017 7:01 PM, Andreas Heigl wrote: >> Hey Richard, Hey all. >> >> Thanks for putting up the RFC and the implementation! >> >> Having UUIDs in the core would be awesome. One of the reasons would be >> that it's in C. That'd be faster b

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Yasuo Ohgaki
Hi Lester, I always make some mistakes. s/are/is There is one principle that developers is better to follow. https://en.wikipedia.org/wiki/Fail-fast If we follow this principle, validation at controller makes sense. Anyway, thank you for pointer for PDO validation. I didn't notice the project. W

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Yasuo Ohgaki
Hi Lester, On Tue, Sep 5, 2017 at 8:36 PM, Lester Caine wrote: > On 05/09/17 12:18, Yasuo Ohgaki wrote: > > I cannot guess people's thought. I appreciated feedback! > > With a decent database layer a lot of the validation you are proposing > is already covered but PDO does not help in this area.

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Fleshgrinder
I'm sorry if my replies sound pissed. I'm generally not good at being diplomatic in writing or talking, and currently under a lot of stress in real life (which is of course not the problem of you guys). Please bare with me, I honor all constructive feedback I receive, truly! -- Richard "Fleshgri

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Fleshgrinder
On 9/5/2017 7:01 PM, Andreas Heigl wrote: > Hey Richard, Hey all. > > Thanks for putting up the RFC and the implementation! > > Having UUIDs in the core would be awesome. One of the reasons would be > that it's in C. That'd be faster but would also allow easier integration > with system-calls to

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Fleshgrinder
On 9/4/2017 11:04 AM, Zeev Suraski wrote: > Richard, > > I'm not accusing you of anything. This is all in positive constructive > spirit, and I was the first to admit I may have missed something - and > although at this point I don't think I did, that's still a possibility. > Sorry, than I mi

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread li...@rhsoft.net
Am 05.09.2017 um 18:57 schrieb Lester Caine: But not at the cost of writing different sets of code to play to each area where checking SHOULD be done. Stick to a single standard method of defining the metadata and that already exists in the database layer ok, to make that point clear: not eve

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Andreas Heigl
Am 02.09.17 um 09:01 schrieb Fleshgrinder: > Hello Internals! > > I just started the voting for the inclusion of a UUID value object in > PHP's core, targeting PHP 7.3. I wanted to start earlier, but was sick > the whole week. > > The voting is open starting now and until September 16. (2 weeks).

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Lester Caine
On 05/09/17 15:13, li...@rhsoft.net wrote: > your first error is thinking every input is related to databases at all So we end up with different code for different types of input? An array that will work directly into a database save or some other follow on process without having to think about whe

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread li...@rhsoft.net
Am 05.09.2017 um 15:44 schrieb Lester Caine: On 05/09/17 14:08, li...@rhsoft.net wrote: the only question as applicaton developer is how you proceed in which cases * reject the whole request with a error-message * reset form-fields where you don't expect an array as input * reset from-fields

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Lester Caine
On 05/09/17 14:08, li...@rhsoft.net wrote: > > > Am 05.09.2017 um 13:36 schrieb Lester Caine: >> On 05/09/17 12:18, Yasuo Ohgaki wrote: >>> I cannot guess people's thought. I appreciated feedback! >> >> With a decent database layer a lot of the validation you are proposing >> is already covered b

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread li...@rhsoft.net
Am 05.09.2017 um 13:36 schrieb Lester Caine: On 05/09/17 12:18, Yasuo Ohgaki wrote: I cannot guess people's thought. I appreciated feedback! With a decent database layer a lot of the validation you are proposing is already covered but PDO does not help in this area. Adding another layer that

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Rowan Collins
On 5 September 2017 12:36:42 BST, Lester Caine wrote: >On 05/09/17 12:18, Yasuo Ohgaki wrote: >> I cannot guess people's thought. I appreciated feedback! > >With a decent database layer a lot of the validation you are proposing >is already covered but PDO does not help in this area. Adding another

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Stephen Reay
> On 5 Sep 2017, at 14:32, Arvids Godjuks wrote: > > That way the API and > features can be stabilized. (Sorry for resend, just realised I sent from a non-list email) Hi Arvids, This is exactly why I (and possibly others) are in favour of this being implemented as a few functions - the objec

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Lester Caine
On 05/09/17 12:18, Yasuo Ohgaki wrote: > I cannot guess people's thought. I appreciated feedback! With a decent database layer a lot of the validation you are proposing is already covered but PDO does not help in this area. Adding another layer that does not integrate with a storage layer is just

Re: [PHP-DEV] A validator module for PHP7

2017-09-05 Thread Yasuo Ohgaki
Hi all, On Tue, Sep 5, 2017 at 12:19 PM, Paul Jones wrote: > > > On Sep 4, 2017, at 18:06, Marco Pivetta wrote: > > > > On Mon, Sep 4, 2017 at 8:56 PM, Crocodile wrote: > > > >> In most cases users would like more than just valid/invalid, i. e. which > >> particular rule(s) failed and also hum

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Arvids Godjuks
2017-09-05 12:24 GMT+03:00 Stephen Reay : > > On 5 Sep 2017, at 14:32, Arvids Godjuks wrote: > > That way the API and > features can be stabilized. > > > Hi Arvids, > > This is exactly why I (and possibly others) are in favour of this being > implemented as a few functions - the object side of th

Re: [PHP-DEV] [VOTE] UUID

2017-09-05 Thread Arvids Godjuks
2017-09-04 19:03 GMT+03:00 Sammy Kaye Powers : > I really, really wanted to vote yes for this as I've wanted simple > UUID creation in core for a long time, but I can't agree this is the > correct implementation. Something like "uuid_v4_create()" seems to > make a lot more pragmatic sense and use