Re: [PHP-DEV] [VOTE] array_key_first(), array_key_last(), array_value_first(),array_value_last()

2018-07-12 Thread Christoph M. Becker
On 12.07.2018 at 09:06, Côme Chilliet wrote: > Le jeudi 12 juillet 2018, 01:04:36 CEST Andrea Faulds a écrit : > >> Hmm. Returning null with no warning makes perfect sense for keys, since >> null is not a valid key so there's no ambiguity, but for values it seems >> problematic. On that ground I

Re: [PHP-DEV] [RFC] Typed Properties

2018-07-12 Thread Marco Pivetta
Nope On Thu, 12 Jul 2018, 21:10 Stanislav Malyshev, wrote: > Hi! > > > - As I said earlier, this patch has already been tested against some > > extremely tricky scenarios, so from a userland perspective it is safe for > > inclusion. If you don't have confidence in something related to it, > ple

[PHP-DEV] Re: Maintainership dates

2018-07-12 Thread Stanislav Malyshev
Hi! > In my opinion, these should be treated basically like unmaintained > extensions, i.e. issue a call for maintainership. It seems to be > appropriate to explicitly CC the listed maintainers, though. > > However, I would prefer to issue the calls for maintainership one by > one, or more likel

Re: [PHP-DEV] [RFC] Typed Properties

2018-07-12 Thread Stanislav Malyshev
Hi! > - As I said earlier, this patch has already been tested against some > extremely tricky scenarios, so from a userland perspective it is safe for > inclusion. If you don't have confidence in something related to it, please > write a test case and help out. It sounds like you are talking abo

Re: [PHP-DEV] [RFC] Typed Properties

2018-07-12 Thread Stas Malyshev
Hi! > Well... it's not being voted on because, despite being six days till > the originally planned feature freeze date, neither sponsor has opened > a vote. And I think it's a good thing. Both for selfish reasons (I haven't actually have the time to read the proposal and the mail thread properl

Re: [PHP-DEV] [RFC] Typed Properties

2018-07-12 Thread Stanislav Malyshev
Hi! > Ah, thanks, Nikita! Considering this, I'm not against delaying beta1 > for two weeks and having an alpha4, provided that we do not allow any > new (i.e. not yet under discussion) RFC to target 7.3. > > Stas, what do you think? Sorry for late answer, I've been behind my emails due to bein

Re: [PHP-DEV] [RFC] abolish narrow margins

2018-07-12 Thread Stanislav Malyshev
Hi! > Things which don't effect the language, but are more of a question of > preference - e.g., the decision to name phpng as PHP 6 vs PHP 7 - or for > that matter, deciding about a different release cadence. It's one thing to That's one of the places where 50% or plurality vote would be approp

[PHP-DEV] Re: Maintainership dates

2018-07-12 Thread Christoph M. Becker
On 03.07.2018 at 07:53, Stanislav Malyshev wrote: > Following up the proposal from Sara, I've made a patch to add dates to > maintainership status in EXTENSIONS: > https://github.com/php/php-src/pull/3357 Thanks! > I didn't touch SAPIs because it's not clear what to do with them (to me). I do n

[PHP-DEV] Re: [PATCH] Make var_export() output "(object)array(..." insteadof"stdClass::__set_state(..." for stdClass

2018-07-12 Thread Andrea Faulds
Christoph M. Becker wrote: On 14.03.2017 at 19:57, Andrea Faulds wrote: Since stdClass has no __set_state method, var_export() produces unusable output if given an object of that class. I wrote a patch that would make var_export() produce a cast to object instead, which could be evaluated to ge

Re: [PHP-DEV] [RFC] abolish narrow margins

2018-07-12 Thread Christoph M. Becker
On 12.07.2018 at 10:10, Zeev Suraski wrote: > I think the problem is that there are cases where a 2/3 vote (or a vote at > all) doesn't make sense. True, we didn't have too many of those in the > past - but as we reform, I think it's important to take note of them. > Things which don't effect the

Re: [PHP-DEV] [RFC] abolish narrow margins

2018-07-12 Thread Zeev Suraski
On Thu, Jul 12, 2018 at 7:38 AM Joe Watkins wrote: > Zeev, > > > I think our voting rules are in need of a much thorough review than just > pushing the limit to 2/3 - which also IMHO doesn't tackle the difference > scenarios that exist out there. > > Agree, they need reform, but rather than tryin

Re: [PHP-DEV] [VOTE] array_key_first(), array_key_last(), array_value_first(),array_value_last()

2018-07-12 Thread Côme Chilliet
Le jeudi 12 juillet 2018, 01:04:36 CEST Andrea Faulds a écrit : > Hmm. Returning null with no warning makes perfect sense for keys, since > null is not a valid key so there's no ambiguity, but for values it seems > problematic. On that ground I've decided to change my vote to No for the > value