[PHP-DEV] Re: [PHP-CVS] com php-src: Missing param in arginfo_pdostatement_setfetchmode: ext/pdo/pdo_stmt.c

Am 14.02.2019 um 08:13 schrieb Gabriel Caruso: Commit:ad75511c8e5461cc6ba5cf7aad8f5265615560a8 Author:Gabriel Caruso Fri, 16 Feb 2018 21:29:34 -0200 Parents: d57c56cd6304b92db83180e7939eb6288c3a18af Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff

Re: [PHP-DEV] [RFC] JIT

On 2/14/19 3:02 AM, Eugene Leonovich wrote: > On Tue, Feb 5, 2019 at 6:06 PM Bruce Weirdan > wrote: > > On Tue, Feb 5, 2019 at 8:38 AM Dmitry Stogov > wrote: > > > PHP+optimizer (-dopcache.jit_buffer_size=0):  32.29s  (100%) >

Re: [PHP-DEV] [RFC] JIT

On Tue, Feb 5, 2019 at 6:06 PM Bruce Weirdan wrote: > On Tue, Feb 5, 2019 at 8:38 AM Dmitry Stogov wrote: > > > PHP+optimizer (-dopcache.jit_buffer_size=0): 32.29s (100%) > > > PHP+optimizer+JIT (-dopcache.jit_buffer_size=5000): 30.72s (95.1%) > > > PHP+optimizer+minimalJIT (-dopcache.jit_

[PHP-DEV] Re: proper anonymous classes?

On 13.02.2019 at 09:01, Rasmus Schultz wrote: > The fact that the anonymous class syntax defines a class *and* immediately > constructs an instance is quite annoying. > > For one, this is quite incompatible with DI containers' ability to resolve > constructor arguments. > > Lets say you DI conta

Re: [PHP-DEV] proper anonymous classes?

It doesn't have to be? It could just be an inline class expression (without the new keyword) that evaluates to a string, e.g. a machine-generated class-name? I don't think that's what first-class support means? e.g. nothing like constructors in JS or class instances like Dart? This could just be

Re: [PHP-DEV] Drop support for libreadline

Missing links PHP 8.0 => https://github.com/php/php-src/pull/3823 Drop support for libreadline PHP 7.x => https://github.com/php/php-src/pull/3824 add readline_list_history with libedit >= 3.1 Remi signature.asc Description: OpenPGP digital signature

Re: [PHP-DEV] Drop support for libreadline

Hi, On Mi, 2019-02-13 at 11:56 +0100, Remi Collet wrote: > Hi, > > > Terribly old and known issue. > > libreadline license (GPL) is incompatible with PHP > > We support build with libedit (BSD) for years > > Most Linux distribution use libedit > Windows also use libedit > > > So, this PR is

Re: [PHP-DEV] Re: Drop support for libreadline

Le 13/02/2019 à 12:51, Christoph M. Becker a écrit : > It should be pointed out > that readline_list_history() doesn't work with libedit, and would be > completely removed. This function is available in recent libedit version (3.1+) So I'm working on a patch to enable it (can also be later added

Re: [PHP-DEV] [RFC] JIT

Hi Internals, According to comments, code reviews and discussions, JIT RFC was extended with few new sections. Please, consider to review the RFC once again. https://wiki.php.net/rfc/jit Any suggestion for RFC improvement are welcome. I'm not going to invest significant time into JIT implemen

[PHP-DEV] Re: Drop support for libreadline

On 13.02.2019 at 11:56, Remi Collet wrote: > Terribly old and known issue. > > libreadline license (GPL) is incompatible with PHP > > We support build with libedit (BSD) for years > > Most Linux distribution use libedit > Windows also use libedit > > > So, this PR is mostly a cleanup of what

[PHP-DEV] Re: [VOTE] Reflection for references

On Wed, Jan 30, 2019 at 11:07 AM Nikita Popov wrote: > Hi internals, > > I would like to start the vote on the ReflectionReference RFC: > > https://wiki.php.net/rfc/reference_reflection > > The vote ends 2019-02-13 and requires a 2/3 majority to pass. Please see > https://externals.io/message/103

[PHP-DEV] Drop support for libreadline

Hi, Terribly old and known issue. libreadline license (GPL) is incompatible with PHP We support build with libedit (BSD) for years Most Linux distribution use libedit Windows also use libedit So, this PR is mostly a cleanup of what should have been removed for years. Feedback before merge

[PHP-DEV] Re: ZTS improvement idea

Hi Joe, On 2/13/19 12:26 PM, Joe Watkins wrote: > Morning all, > > I'm very pleased to see effort going into this, and the resulting ideas. > > I don't have anything to add about the implementation. > > Since most people are not interested in ZTS, there aren't going to be > many voices pushing

[PHP-DEV] Re: ZTS improvement idea

Hi Nikita, On 2/13/19 12:02 PM, Nikita Popov wrote: > On Wed, Feb 13, 2019 at 9:26 AM Dmitry Stogov > wrote: > > Hi, > > > After JIT+ZTS related discussion with Joe and Bob, and some related > analyzes. > > I came to more or less formed design idea and

[PHP-DEV] Re: ZTS improvement idea

Morning all, I'm very pleased to see effort going into this, and the resulting ideas. I don't have anything to add about the implementation. Since most people are not interested in ZTS, there aren't going to be many voices pushing you to actually make changes, so I want to be that voice. The ZT

[PHP-DEV] Re: ZTS improvement idea

On Wed, Feb 13, 2019 at 9:26 AM Dmitry Stogov wrote: > Hi, > > > After JIT+ZTS related discussion with Joe and Bob, and some related > analyzes. > > I came to more or less formed design idea and described it at > https://wiki.php.net/zts-improvement > > This is not an RFC and I'm not sure, if I l

[PHP-DEV] ZTS improvement idea

Hi, After JIT+ZTS related discussion with Joe and Bob, and some related analyzes. I came to more or less formed design idea and described it at https://wiki.php.net/zts-improvement This is not an RFC and I'm not sure, if I like to implement TSRM changes myself now. Comments are welcome. T

Re: [PHP-DEV] proper anonymous classes?

What you describe is first class support for classes, nothing much to do with anonymous classes. On Wed, 13 Feb 2019, 09:01 Rasmus Schultz The fact that the anonymous class syntax defines a class *and* immediately > constructs an instance is quite annoying. > > For one, this is quite incompatible

[PHP-DEV] proper anonymous classes?

The fact that the anonymous class syntax defines a class *and* immediately constructs an instance is quite annoying. For one, this is quite incompatible with DI containers' ability to resolve constructor arguments. Lets say you DI container can register a named component by merely referencing a c