Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties

2020-02-24 Thread Larry Garfield
On Mon, Feb 24, 2020, at 3:25 PM, Mike Schinkel wrote: > > On Feb 23, 2020, at 12:06 PM, Larry Garfield wrote: > > > > On Sun, Feb 23, 2020, at 2:39 AM, Mike Schinkel wrote: > >>> On Feb 21, 2020, at 6:17 PM, Larry Garfield > >>> wrote: > >>> I'm totally on board for better value object

Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties

2020-02-24 Thread Terje Slettebø
Mike Schinkel wrote: On Feb 21, 2020, at 6:17 PM, Larry Garfield wrote: Separate visibility for internal and external access is a separate matter. (Also potentially useful, but not part of the write-once proposal at the moment.) This just hit me, so I think I will mention it. The

[PHP-DEV] Re: Make var_dump() use serialize_precision

2020-02-24 Thread Andrea Faulds
Nikita Popov wrote: Hi internals, https://github.com/php/php-src/pull/5172 changes var_dump() to use serialize_precision instead of precision to dump floating-point numbers. Hi Nikita, Thank you so much for doing this! I had wanted to do this for a long time, and I actually implemented it

Re: [PHP-DEV] [RFC] Explicit call-site pass-by-reference (again)

2020-02-24 Thread Mike Schinkel
> On Feb 23, 2020, at 9:23 AM, Rowan Tommins wrote: > > Hi Mike, > > First, I'd just like to reiterate that I absolutely see benefits in this > proposal, and am definitely not campaigning for it to be abandoned as a bad > idea. Like with any proposal, we have to weigh those benefits against

Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)

2020-02-24 Thread Rowan Tommins
Hi Paul, I left this thread to settle a bit, because I felt we were going round in circles a bit. I think there's some fundamental differences in outlook that no amount of discussion is going to resolve, so I've trimmed this reply to the more specific points. On 20/02/2020 14:56, Paul M.

Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties

2020-02-24 Thread Mike Schinkel
> On Feb 24, 2020, at 8:55 AM, Rowan Tommins wrote: > > As with typed properties, I wonder if there's a way we can introduce Now you are talking! This gives me hope after my dejected last comment on the list. -Mike -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties

2020-02-24 Thread Mike Schinkel
> On Feb 23, 2020, at 12:06 PM, Larry Garfield wrote: > > On Sun, Feb 23, 2020, at 2:39 AM, Mike Schinkel wrote: >>> On Feb 21, 2020, at 6:17 PM, Larry Garfield wrote: >>> I'm totally on board for better value object support, so that's a good >>> motive for me. The question I have is whether

Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties

2020-02-24 Thread Larry Garfield
On Mon, Feb 24, 2020, at 7:55 AM, Rowan Tommins wrote: > On Fri, 21 Feb 2020 at 23:18, Larry Garfield wrote: > > > The with*() method style requires cloning the object. What happens to the > > locked status of a set property if the object is cloned? Are they then > > settable again, or do they

Re: [PHP-DEV] [RFC] [DISCUSSION] str_contains

2020-02-24 Thread Larry Garfield
On Mon, Feb 24, 2020, at 10:56 AM, Ben Ramsey wrote: > > On Feb 24, 2020, at 10:52, Philipp Tanlak wrote: > > > >> Ben Ramsey schrieb am Mo. 24. Feb. 2020 um 17:21: > >> > On Feb 23, 2020, at 03:12, Philipp Tanlak > >> > wrote: > >> > > >> > Hey PHP Devs! > >> > > >> > Since the RFC to

Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)

2020-02-24 Thread Paul M. Jones
Hi Johannes, Thanks for continuing to evaluate the proposal. Am I correct in thinking that your primary objection to ServerRequest is that it is read-only? If so, do you have other objections beyond that? And if not, please correct me. Meanwhile, to respond to your comments ... * * * > On

Re: [PHP-DEV] [RFC] [DISCUSSION] str_contains

2020-02-24 Thread Ben Ramsey
> On Feb 24, 2020, at 10:52, Philipp Tanlak wrote: > >> Ben Ramsey schrieb am Mo. 24. Feb. 2020 um 17:21: >> > On Feb 23, 2020, at 03:12, Philipp Tanlak wrote: >> > >> > Hey PHP Devs! >> > >> > Since the RFC to str_contains is now almost a week old and most of the >> > discussion happened in

Re: [PHP-DEV] [RFC] [DISCUSSION] str_contains

2020-02-24 Thread Philipp Tanlak
Ben Ramsey schrieb am Mo. 24. Feb. 2020 um 17:21: > > On Feb 23, 2020, at 03:12, Philipp Tanlak > wrote: > > > > Hey PHP Devs! > > > > Since the RFC to str_contains is now almost a week old and most of the > > discussion happened in the initial discussion/proposal thread, I wasn't > > sure if

Re: [PHP-DEV] [RFC] [DISCUSSION] str_contains

2020-02-24 Thread Ben Ramsey
> On Feb 23, 2020, at 03:12, Philipp Tanlak wrote: > > Hey PHP Devs! > > Since the RFC to str_contains is now almost a week old and most of the > discussion happened in the initial discussion/proposal thread, I wasn't > sure if everyone has seen it. Therefore I'd like to create this new email >

Re: [PHP-DEV] RFC: Server-Side Request and Response Objects (v2)

2020-02-24 Thread Johannes Schlüter
On Wed, 2020-02-12 at 10:54 -0600, Paul M. Jones wrote: > Hi Johannes, > > > > What indication is there that this will be more successfull than > > the > > filter API? > > Fair question. While I can't say how successful (or not) ext/filter > has been, I *can* say that the proposal does not

Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties

2020-02-24 Thread Rowan Tommins
On Fri, 21 Feb 2020 at 23:18, Larry Garfield wrote: > The with*() method style requires cloning the object. What happens to the > locked status of a set property if the object is cloned? Are they then > settable again, or do they come pre-locked? > > Neither of those seem good, now that I

Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties

2020-02-24 Thread Marco Pivetta
On Mon, Feb 24, 2020, 09:19 Rowan Tommins wrote: > On 24 February 2020 03:26:19 GMT+00:00, Marco Pivetta > wrote: > >The solution is trivial: don't use cloning: > > > >final class Foo > >{ > >public function withBar($bar):self { > >$instance = new self(); > >$instance->foo =

Re: [PHP-DEV] [RFC] [DISCUSSION] Immutable/final/readonly properties

2020-02-24 Thread Rowan Tommins
On 24 February 2020 03:26:19 GMT+00:00, Marco Pivetta wrote: >The solution is trivial: don't use cloning: > >final class Foo >{ >public function withBar($bar):self { >$instance = new self(); >$instance->foo = $foo; >// more assignments here - unavoidable >