Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an array of StackFrame objects

2020-07-20 Thread Michał Marcin Brzuchalski
wt., 21 lip 2020 o 07:07 tyson andre napisał(a): > > Can you give an example of an internal stack frame? > > A stack frame that was created by a PHP internal function instead of by > userland code, i.e. one without a file in the frame. > Related to >

Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an array of StackFrame objects

2020-07-20 Thread tyson andre
> Can you give an example of an internal stack frame?  A stack frame that was created by a PHP internal function instead of by userland code, i.e. one without a file in the frame. Related to https://github.com/php/php-src/pull/5820#pullrequestreview-452080212 ``` php > array_map(fn() =>

Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an array of StackFrame objects

2020-07-20 Thread Michał Marcin Brzuchalski
Hi Tyson, wt., 21 lip 2020 o 06:54 tyson andre napisał(a): > Hi Michał Marcin Brzuchalski, > > At the time of writing, the documentation in > https://wiki.php.net/rfc/stack-frame-class#stackframe_class is also > inconsistent with the implementation. > `public readonly string $file;` is not

Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an array of StackFrame objects

2020-07-20 Thread Michał Marcin Brzuchalski
Hi Tyson, wt., 21 lip 2020 o 04:27 tyson andre napisał(a): > ... > I had some comments on the implementation in > https://github.com/php/php-src/pull/5820#pullrequestreview-452045885 > Most of these comments can be worked upon the next days in the meantime. > - How much does this change

Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an array of StackFrame objects

2020-07-20 Thread tyson andre
Hi Michał Marcin Brzuchalski, At the time of writing, the documentation in https://wiki.php.net/rfc/stack-frame-class#stackframe_class is also inconsistent with the implementation. `public readonly string $file;` is not actually read only in the implementation in the GitHub PR. It can be

Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an array of StackFrame objects

2020-07-20 Thread tyson andre
Hi Michał Marcin Brzuchalski, > Heads up, I plan to open the vote tomorrow morning. Sorry for the late comment - I'd been busy/occupied with various other things and this RFC fell off my radar, and I'd assumed that anything I'd end up noticing when looking at the RFC would have already been

Re: [PHP-DEV] [RFC] \PHP namespace usage heuristics

2020-07-20 Thread Mark Randall
On 20/07/2020 16:58, Michael Wallner wrote: Distilled down, I just cannot see any huge benefit out of a (or two) root namespace(s). As a project we rightfully own the root namespace, and putting everything beneath PHP just doesn't make any sense to me. You cannot just "own" the root namespace

[PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an array of StackFrame objects

2020-07-20 Thread Michał Marcin Brzuchalski
Hi Internals, Heads up, I plan to open the vote tomorrow morning. Cheers, Michał Marcin Brzuchalski wt., 7 lip 2020 o 22:46 Michał Marcin Brzuchalski < michal.brzuchal...@gmail.com> napisał(a): > Hi internals, > > following recently added alternative to `token_get_all()` in form of a >

Re: [PHP-DEV] [VOTE] Named arguments

2020-07-20 Thread Rowan Tommins
On Fri, 10 Jul 2020 at 09:42, Nikita Popov wrote: > Hi internals, > > I have opened voting on the named arguments RFC: > https://wiki.php.net/rfc/named_params > I see this vote is currently running close to the super-majority threshold. To those of you whose main concern is the need for

Re: [PHP-DEV] [RFC] \PHP namespace usage heuristics

2020-07-20 Thread Rowan Tommins
On Mon, 20 Jul 2020 at 16:58, Michael Wallner wrote: > Distilled down, I just cannot see any huge benefit out of a (or two) root > namespace(s). As a project we rightfully own the root namespace, and > putting everything beneath PHP just doesn't make any sense to me. > I will ask you the same

Re: [PHP-DEV] [RFC] \PHP namespace usage heuristics

2020-07-20 Thread Michael Wallner
Hi Larry! Larry Garfield schrieb am Mi., 24. Juni 2020, 02:30: > Greetings, Internalians. > > *dons flame retardant suit* Thank your for your efforts, but I'm about to cast a negative vote on this policy. Distilled down, I just cannot see any huge benefit out of a (or two) root namespace(s).

Re: [PHP-DEV] Changing default assertion mode to throw exceptions

2020-07-20 Thread Levi Morrison via internals
On Mon, Jul 13, 2020 at 11:37 AM Levi Morrison wrote: > > Hello everyone, > > I'd like to change the default mode of assertion failures to throw. > The current default is to warn. In my opinion this is a bad strategy: > the engine asserted that something that is expected to be true is not, > so