Re: [PHP-DEV] Use MySQL syntax only for parsing MySQL statements in PDO

2021-04-10 Thread Sergei Morozov
Hi, > it seems to be a cheap hack To me, it seems to be within the existing architecture. I agree that the existing architecture has its flaws. > What about backtick character ` ? What about NO_BACKSLASH_ESCAPES mode? These are out of scope. I wasn't aware of the NO_BACKSLASH_ESCAPES but it ind

Re: [PHP-DEV] Use MySQL syntax only for parsing MySQL statements in PDO

2021-04-10 Thread Kamil Tekiela
This is an interesting solution to the problem, but I am unsure if it's the best one. I didn't look into it in detail yet, but at first glance, it seems to be a cheap hack to solve a bug. What about backtick character ` ? What about NO_BACKSLASH_ESCAPES mode? Any question mark within backtick-escap

Re: [PHP-DEV] [8.1] Release Manager Election

2021-04-10 Thread Saif Eddin Gmati
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hello, I would like to introduce myself to those of you who might not know me. My name is Saif ( also known as "azjezz" ), I'm 21 years old, i have been working with PHP for approximately 8 years. I'm currently employed as a senior developer at [

Re: [PHP-DEV] Changes to Git commit workflow

2021-04-10 Thread Jakub Zelenka
On Thu, Apr 1, 2021 at 3:21 PM Bishop Bettini wrote: > On Thu, Apr 1, 2021 at 9:22 AM Rowan Tommins > wrote: > > > On 01/04/2021 05:54, Bishop Bettini wrote: > > > I've documented why we need signing, and how to set it up: > > > > > > https://wiki.php.net/vcs/commit-signing > > > > > > Feedback

[PHP-DEV] Use MySQL syntax only for parsing MySQL statements in PDO

2021-04-10 Thread Sergei Morozov
Hi Internals, There are bugs #79276 and #80340 where PDO parses valid PostgreSQL statements incorrectly because it uses MySQL grammar for all statements regardless of the underlying platform. I submitted pull request