Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-11 Thread Hans Henrik Bergan
dang, yeah completely missed that, sorry On Mon, 11 Oct 2021 at 13:14, Tim Starling wrote: > On 11/10/21 9:33 pm, Hans Henrik Bergan wrote: > > @Nicolas i hope mediawiki doesn't run on Windows, because that > > escapeshellarg-replacement you did is not valid for windows. > > Maybe you missed the

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-11 Thread Tim Starling
On 11/10/21 9:33 pm, Hans Henrik Bergan wrote: > @Nicolas i hope mediawiki doesn't run on Windows, because that > escapeshellarg-replacement you did is not valid for windows. Maybe you missed the Windows-specific code on lines 113-146.

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-11 Thread Hans Henrik Bergan
@Nicolas i hope mediawiki doesn't run on Windows, because that escapeshellarg-replacement you did is not valid for windows. the code prints: echo 'foo && whoami && echo ' and when i run that in bash i get: C:\Users\hansh>echo 'foo && whoami && echo ' 'foo laptop-1plmku02\hansh ' - whoami was ex

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-11 Thread Nicolas Grekas
Le lun. 11 oct. 2021 à 03:33, Tim Starling a écrit : > On 4/10/21 9:08 pm, Nikita Popov wrote: > > > > Hi Tim, > > > > Thanks for creating this proposal, it looks great! > > > > I think this is a very beneficial change, and the amount of > > incorrect locale-dependent calls we had just in php-src