Re: [PHP-DEV] [RFC] Embedding multiple PHP engines in a single thread

2022-02-01 Thread Nikita Popov
On Tue, Feb 1, 2022 at 3:36 AM wrote: > Hello internals, > > As you know, the PHP codebase makes heavy use of global variables. In ZTS > builds, access to these globals are cleverly mapped to thread local storage > via macros. To my knowledge, the limitation here is that there's no way to > run m

Re: [PHP-DEV] Adding `final class Deque` to PHP

2022-02-01 Thread Mel Dafert
On 1 February 2022 17:06:59 CET, Stephen Reay wrote: > >The proposed API switches between terms `front`, `back`, `start` and `end` in >comments - is there meant to be a conceptual difference between front/start >and end/back ? On a similar note, why are the methods for getting the first/last va

Re: [PHP-DEV] Re: Adding `final class Deque` to PHP

2022-02-01 Thread Larry Garfield
On Tue, Feb 1, 2022, at 8:46 AM, tyson andre wrote: > I plan to start voting on https://wiki.php.net/rfc/deque on Friday, > February 4th. > > Several changes have been made to https://wiki.php.net/rfc/deque#changelog > after the feedback in https://externals.io/message/116100 > > - The class is

Re: [PHP-DEV] Adding `final class Deque` to PHP

2022-02-01 Thread Stephen Reay
> On 1 Feb 2022, at 21:46, tyson andre wrote: > > Hi internals, > >> I've created a new RFC https://wiki.php.net/rfc/deque to add a `final class >> Deque` >> >> This is based on the `Teds\Deque` implementation I've worked on >> for the https://github.com/TysonAndre/pecl-teds PECL. >> >> Whi

[PHP-DEV] Re: Adding `final class Deque` to PHP

2022-02-01 Thread tyson andre
Hi internals, > I've created a new RFC https://wiki.php.net/rfc/deque to add a `final class > Deque` > > This is based on the `Teds\Deque` implementation I've worked on > for the https://github.com/TysonAndre/pecl-teds PECL. > > While `SplDoublyLinkedList` and its subclass `SplQueue`/`SplStack`

Re: [PHP-DEV] Adding `final class Deque` to PHP

2022-02-01 Thread tyson andre
Hi Levi Morrison, > I think this RFC is in much better shape now. > > The last thing I'll personally push for is dropping `get` and `set`. > I'm not sure about those names, and the functionality is already > provided by `offsetGet` and `offsetSet`, albeit through `mixed` > instead of `int`, but I

Re: [PHP-DEV] RFC [Discussion]: Redacting parameters in back traces

2022-02-01 Thread Tim Düsterhus , WoltLab GmbH
Hi Alex On 2/1/22 07:38, Alexandru Pătrănescu wrote: I think storing the original value within the replacement value should be considered and voted in this RFC as well, even if implemented in a separate PR. I did write some code where I process programmatically the backtraces and while I might n