Re: [PHP-DEV] [RFC] [Discussion] Adding bcround, bcfloor and bcceil to BCMath

2023-10-02 Thread Saki Takamachi
Hi, Claude, Jorg > If the existence of the function is checked in advance, the BC risk is worst, > because they cannot have known whether the signature and semantics of the > function you will introduce will be compatible with the one they have > defined. In case of mismatch the eventual

Re: [PHP-DEV] [RFC] [Discussion] Adding bcround, bcfloor and bcceil to BCMath

2023-10-02 Thread Jorg Sowa
Hello, Recently I was trying to fix and clean some of the stuff within the BCmath extension along with Girgias who helped me. I wanted to enrich this extension with similar functions that GMP contains and improve the performance, however, I went to some conclusions and stopped it. 1. BCMath

[PHP-DEV] [RFC] [VOTE] DOM HTML5 parsing and serialization

2023-10-02 Thread Niels Dossche
Hi internals I just opened the vote on my RFC "DOM HTML5 parsing and serialization". RFC link: https://wiki.php.net/rfc/domdocument_html5_parser Discussion (externals.io): https://externals.io/message/120972 Voting will run for two weeks until 2023-10-16 20:20 GMT+2 There is one primary vote

Re: [PHP-DEV] trim support for multibyte spaces

2023-10-02 Thread youkidearitai
2023年10月2日(月) 23:24 Hans Henrik Bergan : > > add a > void str_dump(const size_t strlen, const char *str) > { > printf("string(%zu) \"", strlen); > fwrite(str, strlen, 1, stdout); > printf("\"\n"); > } > > then replace the string_view stuff with > > size_t teststrlen =

Re: [PHP-DEV] [RFC] [Discussion] Adding bcround, bcfloor and bcceil to BCMath

2023-10-02 Thread Claude Pache
> Le 1 oct. 2023 à 14:35, Saki Takamachi a écrit : > > Hi, internals > > I would like to start the discussion for my RFC "Adding bcround, bcfloor and > bcceil to BCMath”. > https://wiki.php.net/rfc/adding_bcround_bcfloor_bcceil_to_bcmath > > Regards. > > Saki > -- > PHP Internals - PHP

Re: [PHP-DEV] trim support for multibyte spaces

2023-10-02 Thread Hans Henrik Bergan
add a void str_dump(const size_t strlen, const char *str) { printf("string(%zu) \"", strlen); fwrite(str, strlen, 1, stdout); printf("\"\n"); } then replace the string_view stuff with size_t teststrlen = strlen(teststr); str_dump(teststrlen, teststr); mb_trim(, ,

Re: [PHP-DEV] trim support for multibyte spaces

2023-10-02 Thread youkidearitai
Hi, Hans. Thank you very much for your code. And sorry for late. I confirmed works fine. https://gist.github.com/youkidearitai/0018dee27353c00aebaff3bf57c5b8c6 However, this code is C++17, php-src is C code. If you would like contribute, I would like written to C code. Regards Yuya