[PHP-DEV] Re: DOMXPath / XSLTProcessor function callbacks

2023-10-16 Thread Niels Dossche
Hi Frederik Sorry for the resend... I accidentally replied to you only without including the list the first time. On 15/10/2023 21:37, Frederik Bosch wrote: > Dear Niels, > > First of all, thanks for all your hard work already on the DOM and SimpleXML > extensions. I have been following your w

[PHP-DEV] Re: [RFC] [VOTE] DOM HTML5 parsing and serialization

2023-10-16 Thread Niels Dossche
On 02/10/2023 20:19, Niels Dossche wrote: > Hi internals > > I just opened the vote on my RFC "DOM HTML5 parsing and serialization". > RFC link: https://wiki.php.net/rfc/domdocument_html5_parser > Discussion (externals.io): https://externals.io/message/120972 > > Voting will run for two weeks unt

Re: [PHP-DEV] Previous discussions about generics syntax only?

2023-10-16 Thread Alex Wells
On Mon, Oct 16, 2023 at 5:08 PM Olle Härstedt wrote: > Hello internals, > > Was there a previous discussion about the pros/cons of adding only the > syntax needed for generics, but not the functionality? So static > analyzers could use it, instead of docblocks. I looked at externals.io > but coul

Re: [PHP-DEV] Previous discussions about generics syntax only?

2023-10-16 Thread Benjamin Morel
Hi, yes there was, back in 2020: https://externals.io/message/111875 - Benjamin On Mon, 16 Oct 2023 at 16:08, Olle Härstedt wrote: > Hello internals, > > Was there a previous discussion about the pros/cons of adding only the > syntax needed for generics, but not the functionality? So static > a

[PHP-DEV] Previous discussions about generics syntax only?

2023-10-16 Thread Olle Härstedt
Hello internals, Was there a previous discussion about the pros/cons of adding only the syntax needed for generics, but not the functionality? So static analyzers could use it, instead of docblocks. I looked at externals.io but couldn't find anything specific. Regards Olle -- PHP Internals - PH

Re: [PHP-DEV] Better name for method Randomizer::nextFloat()

2023-10-16 Thread Tim Düsterhus
Hi On 10/16/23 10:34, Christian Schneider wrote: Am 15.10.2023 um 19:24 schrieb Tim Düsterhus : Making getFloat(float $min = 0.0, float $max = 1.0, IntervalBoundary $boundary = IntervalBoundary::ClosedOpen) would seemingly make it legal to call ->getFloat(0.5), which I consider to be worse th

Re: [PHP-DEV] Peculiar behaviour of ext/xml set_X_handler() functions

2023-10-16 Thread G. P. B.
On Tue, 10 Oct 2023 at 14:52, G. P. B. wrote: > Hello internals, > > While doing some refactoring of ext/xml to bring it up to modern engine > standards, I discovered some peculiar behaviour of the functions which set > callable handlers. > > The PR in question is: https://github.com/php/php-src/

Re: [PHP-DEV] Better name for method Randomizer::nextFloat()

2023-10-16 Thread G. P. B.
On Mon, 16 Oct 2023 at 09:34, Christian Schneider wrote: > > Side note: The implementation of nextFloat() is much more efficient than > that of getFloat(0.0, 1.0) and the output will differ even for the same > seeded engine. The domain of legal return values is identical. > > This sounds like an

Re: [PHP-DEV] Two new functions array_first() and array_last()

2023-10-16 Thread Pierre
Le 15/10/2023 à 18:09, Larry Garfield a écrit : That has already been done:https://www.php.net/array_is_list --Larry Garfield Oh, I forgot it was accepted and merged, thanks for pointing at it. Cheers, Pierre

Re: [PHP-DEV] Better name for method Randomizer::nextFloat()

2023-10-16 Thread Christian Schneider
Am 15.10.2023 um 19:24 schrieb Tim Düsterhus : > Making getFloat(float $min = 0.0, float $max = 1.0, IntervalBoundary > $boundary = IntervalBoundary::ClosedOpen) would seemingly make it legal to > call ->getFloat(0.5), which I consider to be worse than nextFloat(). While I understand that you fi