Re: [PHP-DEV] [Discussion] Variable Type Declaration Before Usage

2023-11-05 Thread David Gebler
On Sun, Nov 5, 2023 at 1:37 PM Oladoyinbo Vincent wrote: > Hello Internals, > > I was wondering if php could introduce this feature or if any experienced C > dev here can work on the implementation of this feature. > > I think this is a much bigger issue than bikeshedding over syntax. The idea of

Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()

2023-11-05 Thread Claude Pache
> Le 5 nov. 2023 à 08:31, Saki Takamachi a écrit : > Hi, > > It's almost been two weeks since I opened this discussion. If there are no > other opinions, I am thinking of starting a vote tomorrow or later. > > Regards. > > Saki Hi Saki, Reading the RFC, it is unclear for me what are the

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Kentaro Takeda via internals
Hi, Matteo > Regarding this past issue with PostgreSQL, it can be solved by > treating numbers larger than `int4` as `unknown` (as is the case now) > rather than as `int8` (as in previous attempts). I'm sorry, this was my mistake. select 1::boolean ; -- returns `t` select 1 = true ; -- `ERR

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Saki Takamachi
I couldn't express myself well in English, I'm sure my words were bad. sorry. Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Kentaro Takeda via internals
Hi, Matteo, > The last time I tried to fix the PDO_PARAM_INT behavior on pdo_pgsql I broke > Laravel and surely many other projects. > https://github.com/php/php-src/pull/6801 Thank you for providing an important example. Regarding this past issue with PostgreSQL, it can be solved by treating n

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Saki Takamachi
I should have said that the spec was broken, not the code. By that logic, my PR is probably broken as well. I did additional research on each DB to see if the specs were broken. Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Saki Takamachi
Hi Matteo, > I'm sure there are several bugs w/ types in PDO. > > Perhaps some can be fixed, but I would be very careful touching that part. > > The last time I tried to fix the PDO_PARAM_INT behaviour on pdo_pgsql I broke > Laravel and surely many other projects. > > I'm afraid that most libr

[PHP-DEV] [Discussion] Variable Type Declaration Before Usage

2023-11-05 Thread Oladoyinbo Vincent
Hello Internals, I was wondering if php could introduce this feature or if any experienced C dev here can work on the implementation of this feature. Local based variable declaration before usage is available in most languages like javascript, python, and many more. php has this, but it's only av

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Hans Henrik Bergan
I think it'd be a good idea if they used FILTER_VALIDATE_BOOLEAN and FILTER_VALIDATE_INTEGER type logic, with an error if conversion fails.. I wonder if PDO::PARAM_BOOL_OR_NULL would be worthwhile On Sun, Nov 5, 2023, 10:10 Saki Takamachi wrote: > Hi, > > To think more deeply about this issue,

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Matteo Beccati
Hi Saki, Il 04/11/2023 07:59, Saki Takamachi ha scritto: Hi internals, As shown in the following issue, the behavior of `PDO::PARAM_` is inconsistent and I would like to fix this. https://github.com/php/php-src/issues/12603 First, I tried fixed pdo_pgsql. https://github.com/php/php-src/pu

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Saki Takamachi
Hi, To think more deeply about this issue, I investigated various cases in major databases. It's too big to write in an email, so I posted it in the comments of the issue. https://github.com/php/php-src/issues/12603#issuecomment-1793679776 Regards. Saki -- PHP Internals - PHP Runtime Developm

Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()

2023-11-05 Thread Saki Takamachi
Hi, It's almost been two weeks since I opened this discussion. If there are no other opinions, I am thinking of starting a vote tomorrow or later. Regards. Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

[PHP-DEV] Re: [RFC] [Discussion] Adding bcround, bcfloor and bcceil to BCMath

2023-11-05 Thread Saki Takamachi
Hi, It's been two weeks since then. I don't think there is any reason to prevent enhancements to BCMath's functionality at this point, unless there is a realistic discussion of deprecating BCMath and providing another math extension. Also, regarding conflicts with functions of the same name th