Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()

2023-11-07 Thread Saki Takamachi
Hi Tim, > I think, most often, round() is done on the result of some calculation, not > on decimal literals. The previous implementation seems to prioritize rounding > of decimal literals over correct rounding of the actual value. Yes, as Jakub pointed out, there was a lack of explanation

Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()

2023-11-07 Thread Saki Takamachi
Hi Jakub, > please do not top post - you might want to check these rules for PHP mailing > lists: https://github.com/php/php-src/blob/master/docs/mailinglist-rules.md > if you haven't seen them already ;) I intended to post with all the quotes deleted, but it seems I was wrong. > It would be

Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()

2023-11-07 Thread Tim Starling
On 8/11/23 03:06, Saki Takamachi wrote: I have added as much of the rationale for the changes as I can think of to the RFC. I would be happy if you could see it again. Thanks for the detailed RFC and the PR. I reviewed the RFC and the PR. I would vote in favour of this change. I look

Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()

2023-11-07 Thread Jakub Zelenka
Hi, please do not top post - you might want to check these rules for PHP mailing lists: https://github.com/php/php-src/blob/master/docs/mailinglist-rules.md if you haven't seen them already ;) On Tue, Nov 7, 2023 at 4:07 PM Saki Takamachi wrote: > I have added as much of the rationale for the

[PHP-DEV] [RFC] [Discussion] Improve callbacks in ext/dom and ext/xsl

2023-11-07 Thread Niels Dossche
Hi internals I'm opening the discussion for my RFC "Improve callbacks in ext/dom and ext/xsl". RFC link: https://wiki.php.net/rfc/improve_callbacks_dom_and_xsl Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Matteo Beccati
Hi, Il 07/11/2023 14:13, Kévin Dunglas ha scritto: This change seems reasonable to me: safer, with little chance of breaking things, and easy to reverse for the end user by changing a single parameter. /me runs to remove the 16-years old "register_argc_argv = on" check from the web installer

Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()

2023-11-07 Thread Saki Takamachi
Hi Mike, I'm still new to RFC and your advice would be very helpful. I have added as much of the rationale for the changes as I can think of to the RFC. I would be happy if you could see it again. Thank you, regards. Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread G. P. B.
On Tue, 7 Nov 2023 at 10:33, Thomas Chauchefoin via internals < internals@lists.php.net> wrote: > Hey, > > I recently opened an issue on GitHub [1] to discuss setting > register_argc_argv to Off by default for all SAPIs but cli, embed, and > phpdbg. Ilija Tovilo suggested including this change in

Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()

2023-11-07 Thread Michael Wallner
On Mon, 6 Nov 2023 21:12:40 +0900, Saki Takamachi wrote: Hi Saki! > To be honest, I'm completely neutral on this. I believe that this is a > matter of will and what we want to do. As far as I know, Tim and Gina > want change on this issue. I don't want to ignore such opinions and move > forward

Re: [PHP-DEV] [Discussion] Variable Type Declaration Before Usage

2023-11-07 Thread Thomas Gutbier
Am 05.11.2023 um 14:37 schrieb Oladoyinbo Vincent: Hello Internals, Local based variable declaration before usage is available in most languages like javascript, python, and many more. php has this, but it's only available while working/dealing with oop related. Somewhat ironically, one could

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Kévin Dunglas
This change seems reasonable to me: safer, with little chance of breaking things, and easy to reverse for the end user by changing a single parameter.

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Sebastian Bergmann
Am 07.11.2023 um 11:33 schrieb Thomas Chauchefoin via internals: For instance, the official Docker image has it on [2]. "Official" is relative here. That image is maintained by (the) Docker (community), it is not maintained by the PHP project. -- PHP Internals - PHP Runtime Development

[PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Thomas Chauchefoin via internals
Hey, I recently opened an issue on GitHub [1] to discuss setting register_argc_argv to Off by default for all SAPIs but cli, embed, and phpdbg. Ilija Tovilo suggested including this change in 8.4.0. Even though most downstream distributions already turn it off, that's not the case everywhere.