[PHP-DEV] Add Dom\Element::insertAdjacentHTML()

2024-10-28 Thread Niels Dossche
Hi internals I'd like to add the Dom\Element::insertAdjacentHTML() DOM API from the WHATWG DOM spec to our DOM extension. PR link: https://github.com/php/php-src/pull/16614 It uses the same underlying infrastructure as $innerHTML and $outerHTML; it's the HTML counterpart of the existing Dom\Elem

Re: [PHP-DEV] [VOTE] Add persistent curl share handles

2024-10-28 Thread Eric Norris
> >> Accidentally sharing a cookie jar for unrelated requests due to a > >> badly > >> chosen `$persistent_id` sounds like a vulnerability to is bound to > >> happen to someone. > > > > I'll admit that I don't have a good response to this, since while I > > agree this is possible, I don't think it

Re: [PHP-DEV] [VOTE] Add persistent curl share handles

2024-10-28 Thread Tim Düsterhus
Hi Am 2024-10-25 16:29, schrieb Eric Norris: I'm especially concerned, because the documentation for `curl_share_init()` uses `CURL_LOCK_DATA_COOKIE` as the example. I would also assume that sharing a cookie jar amongst several requests is the primary use case for leveraging a curl share handl