Re: [PHP-DEV] [RFC] Policy on 3rd party code

2024-10-31 Thread Larry Garfield
On Sat, Oct 26, 2024, at 3:24 PM, Jim Winstead wrote: > There were more existing 3rd-party dependencies that should probably be > added to the policy text: > > https://news-web.php.net/php.internals/125769 > > Two I missed were JpGraph and Parsedown which are used by web-doc. > (Currently by sid

Re: [PHP-DEV] RFC: Support Closures in constant expressions

2024-10-31 Thread Gina P. Banyard
On Tuesday, 29 October 2024 at 15:11, Tim Düsterhus wrote: > Hi > > Volker and I would like to start discussion on our RFC to "Support > Closures in constant expressions". > > Please find the following resources for your reference: > > - RFC: https://wiki.php.net/rfc/closures_in_const_expr > -

Re: [PHP-DEV] Add Dom\Element::insertAdjacentHTML()

2024-10-31 Thread Gina P. Banyard
On Monday, 28 October 2024 at 20:21, Niels Dossche wrote: > Hi internals > > I'd like to add the Dom\Element::insertAdjacentHTML() DOM API from the WHATWG > DOM spec to our DOM extension. > PR link: https://github.com/php/php-src/pull/16614 > It uses the same underlying infrastructure as $inne

Re: [PHP-DEV] RFC: Support Closures in constant expressions

2024-10-31 Thread Gina P. Banyard
On Thursday, 31 October 2024 at 07:22, Rob Landers wrote: > To be honest, I thought it was a rhetorical question since the example is a > runtime error (passing string to a function that takes an array), but on this > note, we already know how it should behave: https://3v4l.org/RC6b3 because,

[PHP-DEV] Adding `ReflectionConstant::getExtension()` and `::getExtensionName()`

2024-10-31 Thread Daniel Scherzer
Hi internals, Last week I sent [1] to implement `ReflectionConstant::getExtension()` and `::getExtensionName()`. It was suggested [2] that I ask the mailing list if there are any objections. Are there? --Daniel Scherzer (https://github.com/DanielEScherzer) [1] https://github.com/php/php-src/pull

Re: [PHP-DEV] RFC: Support Closures in constant expressions

2024-10-31 Thread Rob Landers
On Thu, Oct 31, 2024, at 07:16, Larry Garfield wrote: > On Wed, Oct 30, 2024, at 3:01 AM, Tim Düsterhus wrote: > > Hi > > > > Am 2024-10-30 05:25, schrieb Larry Garfield: > >> This seems like a good idea to me. My only real question is why we > >> need to forbid short-closures. I fully agree t