Those look good except that you're using isset($ar[$key]) when you should
be using array_key_exists($key, $ar). If the value you were trying to set
is set to null, your function will erroneously return false instead of null
(since it isn't 'set', but the key does in fact exist)
On Sun, Sep 30, 201
If there's this big conflict between BC breaks being bad because they
discourage adoption and make old code unusable on the one hand, and
good because they allow many things to be cleaned up and progress to
be made, then why not pursue a three-pronged approach:
1. BC breaks are made wherever it mak
I think that your proposal looks good, but I'd like to suggest a few
changes. First of all, I'd like to see the association with integers
removed. An enum instance shouldn't just be a name for an integer, it
should be more like a singleton instance of a special kind of class
that can only ever have
This didn't seem to get much notice the first time I sent it, so as
per the suggestion at (http://php.net/svn-php.php), I'm resending it.
It would be great if someone could commit it to the source tree so
this bug can be closed. Please let me know if I need to do something
differently or if you hav
This is a patch to fix the main issue in bug #54254,
cal_from_jd(CAL_JEWISH) returns month=6 for Adar when there is only
one Adar, (it should return 7, since if there is only one Adar it's
AdarII). This will clear up an issue where cal_from_jd() returns a
month that cal_days_in_month() reports to h
