[PHP-DEV] Adding TypeError and ValueError to count() function

2020-01-07 Thread George Peter Banyard
that always return 0. I've also added a ValueError exception on invalid modes. The new pull request is located at https://github.com/php/php-src/pull/4940 Any comments would be appreciated. Best regards and happy new year. George Peter Banyard [1] https://wiki.php.net/rfc/consistent_type_erro

[PHP-DEV] Allowing variable strings to be defined for a string offset

2019-12-16 Thread George Peter Banyard
first one was used to replace the byte at the designated offset. On the other hand the introduction of an Error Exception is obviously a BC break but as it points out to some kind of logic error. I would assume the impact to be minimal for both of these case. Any opinions? Best regards George Pet

Re: [PHP-DEV] [RFC] Union Types v2 (followup on github usage)

2019-09-05 Thread George Peter Banyard
eping it's infrastructure up to date) while keeping control over it. Best regards George Peter Banyard