[PHP-DEV] Re: [PATCH] opcache bug #69090, prepend user identifier to keys

2016-11-11 Thread php-dev
lumping these issues together but they're really separate concerns. Off-list I'm going to send you a proof of concept script which demonstrates the problem with a typical FPM/OPCache deployment in a shared environment. -php-dev at coydogsoftware dot net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PATCH] opcache bug #69090, prepend user identifier to keys

2016-11-10 Thread php-dev
inking the stat() for device+inode should be done in opcache code at file compilation time; correct? Would this be a step in the right direction? Apologies if these are basic questions; I'm new to PHP extensions but strongly motivated to fix OPCache keys quickly. I may have time for a se

[PHP-DEV] Re: [PATCH] opcache bug #69090, prepend user identifier to keys

2016-11-10 Thread php-dev
Hello, Thank you for the response. Replies inline: On Thu, Nov 10, 2016 at 08:51:58AM +, Dmitry Stogov wrote: > > I see the problem(s) and I took a look into the patch. Can you confirm that you see the permissions bypass problem? I've seen the chroot filename collision problem acknowledged

[PHP-DEV] [PATCH] opcache bug #69090, prepend user identifier to keys

2016-11-04 Thread php-dev
Hello, I'm CCing Dmitry Stogov as maintainer because he's listed as an author in ext/opcache/ZendAccelerator.c and has recent commits. I've attached a patch for bug #69090. You can find a more detailed writeup at https://bugs.php.net/bug.php?id=69090 . In short, the patch adds EUID or Window

[PHP-DEV] Help w/ Parser

2011-11-06 Thread php-dev
I'm having trouble getting some changes to the parser to recognize some new syntax. I've attached a patch of what I've done. Here is the syntax I am trying to get to be parsed properly: Seconds = $Seconds; } // Getters/Setters public $Hours { get { return $this->