Re: [PHP-DEV] #[Deprecated] Attribute

2021-01-13 Thread Rowan Tommins
On 13/01/2021 12:51, Marco Pivetta wrote: For me, runtime behavior is: [...] * a production outage risk If your production code can cause outages based on E_DEPRECATED notices, then that's a bug in your code. I can't think of any justification for a production system to abort because of

Re: [PHP-DEV] #[Deprecated] Attribute

2021-01-13 Thread Marco Pivetta
Hey Benjamin On Wed, Jan 13, 2021 at 1:47 PM Benjamin Eberlei wrote: > I get where you are coming from, but side-effect based > notices/deprecations is just the way PHP works at the moment and as such > this existing mechanism should be used and extended. > > I do have (vague) plans to tackle al

Re: [PHP-DEV] #[Deprecated] Attribute

2021-01-13 Thread Benjamin Eberlei
On Wed, Jan 13, 2021 at 1:34 PM Marco Pivetta wrote: > On Sun, Jan 10, 2021 at 2:48 AM G. P. B. wrote: > >> Just to clarify this raises an E_DEPRECATED right? >> Could it make sense to raise E_USER_DEPRECATED instead? >> > > I hadn't checked this before, but as per George's message, this is > wo

Re: [PHP-DEV] #[Deprecated] Attribute

2021-01-13 Thread Benjamin Eberlei
On Wed, Jan 13, 2021 at 1:05 PM Brent Roose wrote: > Hi Sara > > > On 22 Dec 2020, at 19:54, Sara Golemon wrote: > > > > On Tue, Dec 22, 2020 at 12:35 PM Nicolas Grekas < > > nicolas.grekas+...@gmail.com> wrote: > > > >> It would be great to allow adding this attribute on classes. What about > >

Re: [PHP-DEV] #[Deprecated] Attribute

2021-01-13 Thread Marco Pivetta
On Sun, Jan 10, 2021 at 2:48 AM G. P. B. wrote: > Just to clarify this raises an E_DEPRECATED right? > Could it make sense to raise E_USER_DEPRECATED instead? > I hadn't checked this before, but as per George's message, this is worrying. I've been quite loud about it in the past, but static met

Re: [PHP-DEV] #[Deprecated] Attribute

2021-01-13 Thread Brent Roose
Hi Sara > On 22 Dec 2020, at 19:54, Sara Golemon wrote: > > On Tue, Dec 22, 2020 at 12:35 PM Nicolas Grekas < > nicolas.grekas+...@gmail.com> wrote: > >> It would be great to allow adding this attribute on classes. What about >> allowing it right now and not bind it to any runtime side-effect?

Re: [PHP-DEV] #[Deprecated] Attribute

2021-01-09 Thread G. P. B.
On Sat, 19 Dec 2020 at 10:19, Benjamin Eberlei wrote: > Hi internals, > > I have updated the RFC for a #[Deprecated] attribute that wasn't completed > for PHP 8.0 due to time constraints and I am able to restart the discussion > now. > > https://wiki.php.net/rfc/deprecated_attribute > > The follo

Re: [PHP-DEV] #[Deprecated] Attribute

2020-12-22 Thread Bruce Weirdan
On Tue, Dec 22, 2020 at 8:55 PM Sara Golemon wrote: > > You could do that now with a polyfill from userspace. If the annotation > need not have an effect, then it's just any other userspace implementation. > It's possible now, while the attribute is not provided by PHP. But once it gets introdu

Re: [PHP-DEV] #[Deprecated] Attribute

2020-12-22 Thread Sara Golemon
On Tue, Dec 22, 2020 at 12:35 PM Nicolas Grekas < nicolas.grekas+...@gmail.com> wrote: > It would be great to allow adding this attribute on classes. What about > allowing it right now and not bind it to any runtime side-effect? That > would allow static analyzers to do their job. Same for consts

Re: [PHP-DEV] #[Deprecated] Attribute

2020-12-22 Thread Nicolas Grekas
Hi Benjamin, I have updated the RFC for a #[Deprecated] attribute that wasn't completed > for PHP 8.0 due to time constraints and I am able to restart the discussion > now. > > https://wiki.php.net/rfc/deprecated_attribute > > The following updates have been made: > > - focus on only method and fu

[PHP-DEV] #[Deprecated] Attribute

2020-12-19 Thread Benjamin Eberlei
Hi internals, I have updated the RFC for a #[Deprecated] attribute that wasn't completed for PHP 8.0 due to time constraints and I am able to restart the discussion now. https://wiki.php.net/rfc/deprecated_attribute The following updates have been made: - focus on only method and function depre