Re: [PHP-DEV] [PATCH] - Check configured error level before reporting E_NOTICE messages

2009-10-31 Thread Alexey Zakhlestin
On 31.10.2009, at 12:48, Arvind Srinivasan wrote: This is a bad idea, because the error handler does other things as well. If the error reporting level indicates that the user is not interested in E_FOO, why would there be an expectation that zend_error be invoked for E_FOO messages? error

Re: [PHP-DEV] [PATCH] - Check configured error level before reporting E_NOTICE messages

2009-10-31 Thread Arvind Srinivasan
> This is a bad idea, because the error handler does other things as well. If the error reporting level indicates that the user is not interested in E_FOO, why would there be an expectation that zend_error be invoked for E_FOO messages? Arvi -- PHP Internals - PHP Runtime Development Mailing Li

Re: [PHP-DEV] [PATCH] - Check configured error level before reporting E_NOTICE messages

2009-10-30 Thread Derick Rethans
On Fri, 30 Oct 2009, Arvind Srinivasan wrote: > When compiled with #ifdef ZTS, zend_error invokes pthread_get_specific. > > The performance analyzer tool indicated that zend_error was being > invoked during normal processing of requests, even though no error > messages were logged. The source of