[PHP-DEV] [PATCH] Generate warning when using PDO::setAttribute() and ATTR_PERSISTENT

2007-10-26 Thread Ben Ramsey
For a while, we were scratching our heads over why persistent connections were not being created when using PDO_OCI, even though we were explicitly calling PDO::setAttribute() to set PDO::ATTR_PERSISTENT. My colleague Brian DeShong further explains the issue on his blog: http://www.deshong.net/?p=

RE: [PHP-DEV] [PATCH] Generate warning when using PDO::setAttribute() and ATTR_PERSISTENT

2007-10-26 Thread Andi Gutmans
Why is it not an if() statement? > -Original Message- > From: Ben Ramsey [mailto:[EMAIL PROTECTED] > Sent: Friday, October 26, 2007 10:38 AM > To: internals@lists.php.net > Subject: [PHP-DEV] [PATCH] Generate warning when using > PDO::setAttribute() and ATTR_PERSISTEN

Re: [PHP-DEV] [PATCH] Generate warning when using PDO::setAttribute() and ATTR_PERSISTENT

2007-10-26 Thread Ben Ramsey
On 10/26/07 2:44 PM, Andi Gutmans wrote: > Why is it not an if() statement? It can be an if() statement. I added it as a switch in the expectation that other attributes might be added to it in the future. -- Ben Ramsey http://benramsey.com/ -- PHP Internals - PHP Runtime Development Mailing Li

Re: [PHP-DEV] [PATCH] Generate warning when using PDO::setAttribute() and ATTR_PERSISTENT

2007-10-26 Thread Lukas Kahwe Smith
On 26.10.2007, at 20:44, Andi Gutmans wrote: Why is it not an if() statement? -Original Message- From: Ben Ramsey [mailto:[EMAIL PROTECTED] Sent: Friday, October 26, 2007 10:38 AM To: internals@lists.php.net Subject: [PHP-DEV] [PATCH] Generate warning when using PDO::setAttribute