Commited.
At 08:46 PM 10/27/2004 +0200, Vladimir Zidar wrote:
Here is version that uses spprintf()
http://leya.mindnever.org/~mr_w/php-popen2.patch.gz
On Wed, 2004-10-27 at 19:30, Vladimir Zidar wrote:
> I didn't know that such function exist. I can change my patch, and
> everybody should feel b
Here is version that uses spprintf()
http://leya.mindnever.org/~mr_w/php-popen2.patch.gz
On Wed, 2004-10-27 at 19:30, Vladimir Zidar wrote:
> I didn't know that such function exist. I can change my patch, and
> everybody should feel better.. ok ?
>
> On Wed, 2004-10-27 at 19:23, Wez Furlong
This patch makes sense to me. Anyone have a problem with it?
Andi
At 02:14 PM 10/27/2004 +0200, Vladimir Zidar wrote:
When safe_mode is set to 'on', popen() uses char buf[1024] to build
argument list. This is not good, as it truncates command line without notice.
This is NOT operating system lim
I didn't know that such function exist. I can change my patch, and
everybody should feel better.. ok ?
On Wed, 2004-10-27 at 19:23, Wez Furlong wrote:
> I'd feel slightly happier if it used spprintf() instead of manually
> calculating the buffer length, but otherwise I'm okay with it.
>
> --Wez.
I'd feel slightly happier if it used spprintf() instead of manually
calculating the buffer length, but otherwise I'm okay with it.
--Wez.
On Wed, 27 Oct 2004 09:51:52 -0700, Andi Gutmans <[EMAIL PROTECTED]> wrote:
> This patch makes sense to me. Anyone have a problem with it?
>
> Andi
>
>
>
When safe_mode is set to 'on', popen() uses char buf[1024] to build argument list.
This is not good, as it truncates command line without notice.
This is NOT operating system limit - as noted on bugreport, but PHP bug.
If anybody cares, here is fix for this bug under 4.3.9:
http://leya.mindn
