Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

2009-06-30 Thread Lukas Kahwe Smith
On 03.06.2009, at 20:45, Matt Wilmas wrote: Hi all, I first noticed this with preg_replace()'s /e modifier (SO many other issues with that...), but it also happens with create_function() and a few other places where zend_eval_string() is used. Other code evaluation in PHP is

[PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

2009-06-03 Thread Matt Wilmas
Hi all, I first noticed this with preg_replace()'s /e modifier (SO many other issues with that...), but it also happens with create_function() and a few other places where zend_eval_string() is used. Other code evaluation in PHP is binary-safe, so it seems like these areas should be as well?

Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

2009-06-03 Thread Andrei Zmievski
Matt Wilmas wrote: Hi all, I first noticed this with preg_replace()'s /e modifier (SO many other issues with that...), but it also happens with create_function() and a few other places where zend_eval_string() is used. Other code evaluation in PHP is binary-safe, so it seems like these

Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

2009-06-03 Thread Johannes Schlüter
Hi, On Wed, 2009-06-03 at 13:45 -0500, Matt Wilmas wrote: I noticed there are several zend_eval_string() references in PECL sources [1], which would be a problem after adding a string length parameter... How is that handled? Should the updated function be eval_stringL instead and add

Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

2009-06-03 Thread Matt Wilmas
Hi Andrei, all, - Original Message - From: Andrei Zmievski Sent: Wednesday, June 03, 2009 Matt Wilmas wrote: [...] Patches: http://realplain.com/php/binary_eval_string.diff http://realplain.com/php/binary_eval_string_5_3.diff Can they be applied? (Also a small optimization by

Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

2009-06-03 Thread Matt Wilmas
Hi Johannes, - Original Message - From: Johannes Schlüter Sent: Wednesday, June 03, 2009 Hi, On Wed, 2009-06-03 at 13:45 -0500, Matt Wilmas wrote: I noticed there are several zend_eval_string() references in PECL sources [1], which would be a problem after adding a string length