Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-31 Thread Edin Kadribasic
On Tuesday 31 August 2004 14:39, Joe Orton wrote: > On Tue, Aug 17, 2004 at 12:54:55PM -0700, Andi Gutmans wrote: > > Hi agree with Joe on this one. I think it would be beneficial to include > > this patch *even* if it means that we might have to update it from time > > to time. I'm sure Joe will l

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-31 Thread Joe Orton
On Tue, Aug 17, 2004 at 12:54:55PM -0700, Andi Gutmans wrote: > Hi agree with Joe on this one. I think it would be beneficial to include > this patch *even* if it means that we might have to update it from time to > time. I'm sure Joe will lend a helping hand to do so. So, am I OK to commit this

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-17 Thread Andi Gutmans
Hi agree with Joe on this one. I think it would be beneficial to include this patch *even* if it means that we might have to update it from time to time. I'm sure Joe will lend a helping hand to do so. At 09:35 AM 8/17/2004 +0100, Joe Orton wrote: On Mon, Aug 09, 2004 at 09:46:21AM +0200, Edin K

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-17 Thread Joe Orton
On Mon, Aug 09, 2004 at 09:46:21AM +0200, Edin Kadribasic wrote: > I'm -1 on this patch. The problem is has existed for mysql lib for ages and > for all other libraries used by PHP. A note in the documentation stating that > if you want to use GD from PHP and another Apache module you need to com

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-10 Thread Joe Orton
On Mon, Aug 09, 2004 at 09:46:21AM +0200, Edin Kadribasic wrote: > On Monday 09 August 2004 09:00, Derick Rethans wrote: > > On Sat, 7 Aug 2004, Joe Orton wrote: > > > That would mean adding exactly the reverse set of #defines to allow the > > > the GD extension to be built against an external copy

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-09 Thread Edin Kadribasic
On Monday 09 August 2004 09:00, Derick Rethans wrote: > On Sat, 7 Aug 2004, Joe Orton wrote: > > That would mean adding exactly the reverse set of #defines to allow the > > the GD extension to be built against an external copy of libgd (which of > > course won't use the phpgd_* symbols). > > > > Gi

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-09 Thread Derick Rethans
On Sat, 7 Aug 2004, Joe Orton wrote: > That would mean adding exactly the reverse set of #defines to allow the > the GD extension to be built against an external copy of libgd (which of > course won't use the phpgd_* symbols). > > Given that a complete set of #defines is needed anyway, doing it wi

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-07 Thread Joe Orton
On Mon, Aug 02, 2004 at 10:55:27AM +0200, Derick Rethans wrote: > On Fri, 23 Jul 2004, Joe Orton wrote: > > > Building the bundled libgd library into PHP causes symbol namespace > > pollution; if any other Apache modules link a different version of libgd > > into the Apache process they may instea

RE: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-04 Thread Steph
> On Fri, 23 Jul 2004, Joe Orton wrote: > > > Building the bundled libgd library into PHP causes symbol namespace > > pollution; if any other Apache modules link a different version of libgd > > into the Apache process they may instead pick up symbols from the PHP > > libgd, and segfault randomly.

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-02 Thread Derick Rethans
On Fri, 23 Jul 2004, Joe Orton wrote: > Building the bundled libgd library into PHP causes symbol namespace > pollution; if any other Apache modules link a different version of libgd > into the Apache process they may instead pick up symbols from the PHP > libgd, and segfault randomly. (One of ou

[PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-07-23 Thread Joe Orton
[resend, though I notice gd just got updated with some new functions so the symbol list is out of date. Feedback welcome on the principal of the change, anyway] Building the bundled libgd library into PHP causes symbol namespace pollution; if any other Apache modules link a different version of l

[PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-07-16 Thread Joe Orton
Building the bundled libgd library into PHP causes symbol namespace pollution; if any other Apache modules link a different version of libgd into the Apache process they may instead pick up symbols from the PHP libgd, and segfault randomly. (One of our users saw this when using mod_perl with Perl: