[PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-14 Thread Jérôme Loyet
Hi tony, There is several things in this patch: 1- makes log message about pool concistent. I set it to "[pool %s] message". Before there where different variants: pool %s, foo (pool %s) bar [pool %s] [%s] 2- corrects some log messages which were not very meaningful for end users 3- Some log le

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Jani Taskinen
On 12/14/2009 10:16 PM, Jérôme Loyet wrote: Hi tony, There is several things in this patch: 1- makes log message about pool concistent. I set it to "[pool %s] message". Before there where different variants: pool %s, foo (pool %s) bar [pool %s] [%s] 2- corrects some log messages which were not

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Antony Dovgal
On 15.12.2009 12:04, Jani Taskinen wrote: >> 3- Some log level have been switched from NOTICE to DEBUG, so that the >> log_file in normal operation would not be a nightmare to read (with a >> lot of anoying and useless messages for end users) >> > > Wouldn't it make more sense to make this configu

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Jani Taskinen
On 12/15/2009 11:14 AM, Antony Dovgal wrote: On 15.12.2009 12:04, Jani Taskinen wrote: 3- Some log level have been switched from NOTICE to DEBUG, so that the log_file in normal operation would not be a nightmare to read (with a lot of anoying and useless messages for end users) Wouldn't it ma

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Antony Dovgal
On 15.12.2009 12:30, Jani Taskinen wrote: >> Surely log_level is configurable. >> Jerome just changed error level of some error messages to reduce the amount >> of notices in the log. > > I replied badly, I meant ALL the points in the mail. Configurable log > entries, levels, etc. Not some stati

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Tjerk Anne Meesters
The only two things that would come up after reading Jani's email is: 1) Make the log string configurable, such as CustomLog in apache 2) Configure the log level threshold, though I think that should already be there in the first place. On 12/15/09, Antony Dovgal wrote: > On 15.12.2009 12:30, Jan

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Jérôme Loyet
2009/12/15 Tjerk Anne Meesters : > The only two things that would come up after reading Jani's email is: so am I > 1) Make the log string configurable, such as CustomLog in apache Yes but CustomLog is for access log, this feature is not present in php-fpm (should it be ?) All the log message (my

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Antony Dovgal
On 15.12.2009 15:19, Tjerk Anne Meesters wrote: > The only two things that would come up after reading Jani's email is: > 1) Make the log string configurable, such as CustomLog in apache CustomLog is needed in Apache because there are so much variables available. Here we have time, pid, function

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Michael Shadle
On Tue, Dec 15, 2009 at 4:25 AM, Antony Dovgal wrote: > Here we have time, pid, function and line. > With log_level=debug all of them are printed, in other cases only time gets > into the log, > which makes perfect sense to me. +1 to Antony and Jérôme. Having a log format parameter seems a bit

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Joey Smith
On Tue, Dec 15, 2009 at 02:27:30PM -0800, Michael Shadle wrote: > However if people have ideas on how this will help or be useful (i.e. > you -are- planning on running logfiles or logwatch or something) then > it might be smart to bring it back to the table again. Jérôme and I > were talking about

Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + homogenize log message about pool

2009-12-15 Thread Eddie Drapkin
On Tue, Dec 15, 2009 at 9:59 PM, Joey Smith wrote: > On Tue, Dec 15, 2009 at 02:27:30PM -0800, Michael Shadle wrote: >> However if people have ideas on how this will help or be useful (i.e. >> you -are- planning on running logfiles or logwatch or something) then >> it might be smart to bring it ba