[PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-08 Thread DIXON P.
Hi, I've attached a patch for getimagesize() that returns named keys for image width, height, type and attributes values. The equivalent numeric keys 0, 1,2 and 3 are still returned but could perhaps be deprecated in the future? The patch also contains updated tests to reflect the change. Regar

Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-08 Thread Richard Quadling
On 8 July 2011 17:10, DIXON P. wrote: > Hi, > > I've attached a patch ... Rename as .txt to get through the mailing list s/w. -- Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea -- PHP Internals - PHP Runtime Development Mailin

RE: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-08 Thread DIXON P.
Thanks Richard, Renamed and attached. -Original Message- From: Richard Quadling [mailto:rquadl...@gmail.com] Sent: 08 July 2011 17:13 To: DIXON P. Cc: internals@lists.php.net Subject: Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes On 8

Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-08 Thread Richard Quadling
[PATCH] getimagesize - return named keys for width, > height, type and attributes > > On 8 July 2011 17:10, DIXON P. wrote: >> Hi, >> >> I've attached a patch ... > > Rename as .txt to get through the mailing list s/w. For consistency, should bits and mime becom

Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-11 Thread Paul Dixon
] [PATCH] getimagesize - return named keys for width, height, type and attributes On 8 July 2011 17:10, DIXON P. wrote: Hi, I've attached a patch ... Rename as .txt to get through the mailing list s/w. For consistency, should bits and mime become 4 and 5? This would work in the same way as

Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-12 Thread Michael Wallner
On Mon, 11 Jul 2011 22:33:31 +0100, Paul Dixon wrote: > personally long term, I would aim to remove the position index entries > completely. Which would make it unusable with list(). Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.ph

Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-12 Thread Alexey Shein
2011/7/12 Michael Wallner : > On Mon, 11 Jul 2011 22:33:31 +0100, Paul Dixon wrote: >> personally long term, I would aim to remove the position index entries >> completely. > > Which would make it unusable with list(). > +1 this will be huge BC break for this function. Please, don't remove positio

RE: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-13 Thread DIXON P.
44 To: Michael Wallner Cc: internals@lists.php.net Subject: Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes 2011/7/12 Michael Wallner : > On Mon, 11 Jul 2011 22:33:31 +0100, Paul Dixon wrote: >> personally long term, I would aim to remove the

Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes

2011-07-13 Thread Arvids Godjuks
This one is quite positive, I'm all +1 on this as a user land developer. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php