[PHP-DEV] [PATCH] mbstring warning fixes

[Joe Orton]

4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_converter':
4.3/ext/mbstring/mbstring.c:3729: warning: `ret' might be used uninitialized in this 
function
4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_detector':
4.3/ext/mbstring/mbstring.c:3792: warning: `encoding' might be used uninitialized in 
this function

I'm not sure what the right fixes are here, e.g. below makes the
warnings go away...

Index: ext/mbstring/mbstring.c
===================================================================
RCS file: /repository/php-src/ext/mbstring/mbstring.c,v
retrieving revision 1.142.2.37
diff -u -r1.142.2.37 mbstring.c
--- ext/mbstring/mbstring.c     6 Nov 2003 15:41:36 -0000       1.142.2.37
+++ ext/mbstring/mbstring.c     11 Nov 2003 15:41:27 -0000
@@ -3726,7 +3726,7 @@
                TSRMLS_DC)
 {
        int i;
-       mbfl_string string, result, *ret;
+       mbfl_string string, result, *ret = NULL;
        enum mbfl_no_encoding from_encoding, to_encoding;
        mbfl_buffer_converter *convd;
 
@@ -3789,7 +3789,7 @@
 {
        mbfl_string string;
        enum mbfl_no_encoding *elist;
-       enum mbfl_no_encoding encoding;
+       enum mbfl_no_encoding encoding = mbfl_no_encoding_invalid;
        mbfl_encoding_detector *identd = NULL; 
 
        int size, *list;

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php