[PHP-DEV] [PATCH] unicode_semantics "off" evaluates to true

2006-02-13 Thread Brion Vibber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, I've started cautiously poking PHP 6 so I can keep an eye on how the Unicode support is going and see what kind of work we'll eventually need to do to port MediaWiki for it... One thing I noticed right off is that this test doesn't do what yo

Re: [PHP-DEV] [PATCH] unicode_semantics "off" evaluates to true

2006-02-13 Thread Marcus Boerger
Hello Brion, i applied your fix which was correct. I however also added a function to check for unicode mode "bool unicode_enabled()" which returns true if unicode_semantics is set true. best regards marcus Monday, February 13, 2006, 10:07:58 AM, you wrote: > Index: Zend/zend.c >

Re: [PHP-DEV] [PATCH] unicode_semantics "off" evaluates to true

2006-02-13 Thread Brion Vibber
Marcus Boerger wrote: > i applied your fix which was correct. I however also added a function to > check for unicode mode "bool unicode_enabled()" which returns true if > unicode_semantics is set true. Cool, thanks! -- brion vibber (brion @ pobox.com) signature.asc Description: OpenPGP digit

Re: [PHP-DEV] [PATCH] unicode_semantics "off" evaluates to true

2006-02-13 Thread Andrei Zmievski
I don't think it's right to call it unicode_enabled(). Unicode is always accessible, it's just that certain language semantics don't use it when unicode_semantics is off. So I'd call the function unicode_semantics() or unicode_default(). -Andrei On Feb 13, 2006, at 1:20 AM, Marcus Boerger wro

Re: [PHP-DEV] [PATCH] unicode_semantics "off" evaluates to true

2006-02-13 Thread Marcus Boerger
Hello Andrei, changed to unicode_semantics() now. thanks for the hint. best regards marcus Monday, February 13, 2006, 6:26:13 PM, you wrote: > I don't think it's right to call it unicode_enabled(). Unicode is > always accessible, it's just that certain language semantics don't use > it whe