[PHP-DEV] [RFC][VOTE] array_change_keys

Greetings all, It's been a while since we introduced the array_change_keys RFC . During the discussion period there was a healthy mix of interest and critique. It seems all the major discussion points were covered, so I'd like to put this RFC to a vote

Re: [PHP-DEV] [RFC][VOTE] array_change_keys

Hi Colin, Voting NO for the following reasons: * Can be a userland function/library, unless there are huge performance benefits that justify it being in core * Doesn't work with `iterable` * New warnings. No, please, we want `Throwable`: warnings are terrible * Semantics for merging duplicate

Re: [PHP-DEV] [RFC][VOTE] array_change_keys

Hi Marco 2017-01-08 15:43 GMT+01:00 Marco Pivetta : > * New warnings. No, please, we want `Throwable`: warnings are terrible Only really chiming in for the warnings part; warnings should not be a blocker for a new feature, because it would create an inconsistency with that function and the rest.

Re: [PHP-DEV] [RFC][VOTE] array_change_keys

Hearing no objections, voting is now halted and the RFC is back to "Under Discussion". Cheers, Colin On Mon, Jan 9, 2017 at 2:40 PM Colin O'Dell wrote: > Due to concerns that have not been adequately addressed during the > discussion period, and mailing list issues which might be impacting the