Re: [PHP-DEV] [RFC] Class Friendship

2016-01-08 Thread Dustin Wheeler
Hi Dan, On Fri, Jan 8, 2016 at 9:56 AM, Dan Ackroyd wrote: > > Hi Dustin, > > I try to avoid sounding too negative when people come up with ideas > that I might not agree with. HoweverI feel obliged to give honest > feedback earlier rather than later; I can't see any circumstances > under whi

Re: [PHP-DEV] [RFC] Class Friendship

2016-01-08 Thread Dan Ackroyd
On 7 January 2016 at 20:25, Dustin Wheeler wrote: > Hello everyone, > > I have drafted an RFC that describes a proposal to add this feature to > the language. > > https://wiki.php.net/rfc/friend-classes Hi Dustin, I try to avoid sounding too negative when people come up with ideas that I might

Re: [PHP-DEV] [RFC] Class Friendship

2016-01-07 Thread Dustin Wheeler
Dan, On Thu, Jan 7, 2016 at 10:21 PM, Dan Ackroyd wrote: > > FYI The voting RFC is reasonably clear on new syntax and the passing > level: https://wiki.php.net/RFC/voting#voting > > "For these reasons, a feature affecting the language itself (new > syntax for example) will be considered as 'accep

Re: [PHP-DEV] [RFC] Class Friendship

2016-01-07 Thread Dustin Wheeler
Hi François, On Thu, Jan 7, 2016 at 8:33 PM, François Laupretre wrote: > > * There is another inheritance property I didn't include in my initial > article, and I think that should be described : > > class Base { > friend BaseFriend; > protected $base_prop; > static protec

Re: [PHP-DEV] [RFC] Class Friendship

2016-01-07 Thread Dan Ackroyd
On 8 January 2016 at 01:33, François Laupretre wrote: > Hi Dustin, > * About the voter's majority, I see that as a pure addition and there's no > BC break. So, I would say that a 50%+1 majority should be enough. To be > confirmed. > FYI The voting RFC is reasonably clear on new syntax and the pa

Re: [PHP-DEV] [RFC] Class Friendship

2016-01-07 Thread François Laupretre
Hi Dustin, thanks for this nice work ! Here are some comments and thoughts : * There is another inheritance property I didn't include in my initial article, and I think that should be described : class Base { friend BaseFriend; protected $base_prop; static protected $

[PHP-DEV] [RFC] Class Friendship

2016-01-07 Thread Dustin Wheeler
Hello everyone, Before Winter holiday, I began a discussion on the mailing list regarding the topic of class friendship in order to gauge interest towards authoring and implementing an RFC for the feature. This discussion happened at: https://marc.info/?l=php-internals&m=144954699701305&w=2 I ha