On Wed, Aug 6, 2014 at 6:38 AM, Sara Golemon poll...@php.net wrote:
https://wiki.php.net/rfc/switch.default.multiple
'Cause this code is silly (even if it had case blocks), but we allow it:
switch ($expr) {
default:
notExecuted();
break;
default:
executed();
}
--
PHP
Just saw the RFC today so I hadn't been able to comment on it until now..
If we are getting rid of it wouldn't it be better to emit an E_DEPRECATED
per
https://github.com/imnotjames/php-src/compare/switch.default.multiple-deprecated
and then remove it in the next major release?
This has been
On Wed, Aug 13, 2014 at 9:47 AM, Ferenc Kovacs tyr...@gmail.com wrote:
On Wed, Aug 6, 2014 at 6:38 AM, Sara Golemon poll...@php.net wrote:
https://wiki.php.net/rfc/switch.default.multiple
'Cause this code is silly (even if it had case blocks), but we allow it:
switch ($expr) {
default:
On Wed, Aug 13, 2014 at 10:38 AM, Pierre Joye pierre@gmail.com wrote:
On Wed, Aug 13, 2014 at 9:47 AM, Ferenc Kovacs tyr...@gmail.com wrote:
On Wed, Aug 6, 2014 at 6:38 AM, Sara Golemon poll...@php.net wrote:
https://wiki.php.net/rfc/switch.default.multiple
'Cause this code is
On 13/08/14 09:48, Ferenc Kovacs wrote:
I wanted to say that
and I also think that this isn't an important enough issue to warrant a BC
break in a minor version
Reading between the lines this does seem to be more a problem for HHVM
which has not copied the current operation properly. The
Hi!
On 13 Aug 2014, at 08:47, Ferenc Kovacs tyr...@gmail.com wrote:
and I also think that this isn't an important enough issue to warrant a BC
break (albeit this is the better kind of BC: probably doesn't effect too
many people, and they will be clearly notified about the error at compile
On Wed, Aug 13, 2014 at 11:42 AM, Andrea Faulds a...@ajf.me wrote:
I could see
where people would use it - there are reasons to, even if they are poor in
choice to do so.
How, exactly, could there ever be a use for having multiple default: sections
and ignoring all but one? This “feature”
On 13 Aug 2014, at 10:52, Pierre Joye pierre@gmail.com wrote:
On Wed, Aug 13, 2014 at 11:42 AM, Andrea Faulds a...@ajf.me wrote:
I could see
where people would use it - there are reasons to, even if they are poor in
choice to do so.
How, exactly, could there ever be a use for having
Ferenc Kovacs wrote (on 13/08/2014):
sorry to jump in this late, but I'm not sure that it is a good idea to only
reject the multiple default blocks but keep the ability to have the same
case multiple times:
http://3v4l.org/eZdPU
Multiple cases with the same value are a lot harder to prevent
On 13 August 2014 10:56, Andrea Faulds a...@ajf.me wrote:
On 13 Aug 2014, at 10:52, Pierre Joye pierre@gmail.com wrote:
On Wed, Aug 13, 2014 at 11:42 AM, Andrea Faulds a...@ajf.me wrote:
I could see
where people would use it - there are reasons to, even if they are
poor in
On 13 Aug 2014, at 11:24, Peter Cowburn petercowb...@gmail.com wrote:
On 13 August 2014 10:56, Andrea Faulds a...@ajf.me wrote:
However, I tend to think that we should simply target php7 for any of
these fixes. No need of endless arguing and keeps everyone happy.
I’d rather we fix
From: Andrea Faulds [mailto:a...@ajf.me]
Sent: Wednesday, August 13, 2014 11:43 AM
Hi!
On 13 Aug 2014, at 08:47, Ferenc Kovacs tyr...@gmail.com wrote:
and I also think that this isn't an important enough issue to warrant a BC
break (albeit this is the better kind of BC: probably doesn't
On Wed, Aug 13, 2014 at 11:42 AM, Andrea Faulds a...@ajf.me wrote:
Hi!
On 13 Aug 2014, at 08:47, Ferenc Kovacs tyr...@gmail.com wrote:
and I also think that this isn't an important enough issue to warrant a
BC
break (albeit this is the better kind of BC: probably doesn't effect too
On Wed, Aug 13, 2014 at 12:22 PM, Rowan Collins rowan.coll...@gmail.com
wrote:
Ferenc Kovacs wrote (on 13/08/2014):
sorry to jump in this late, but I'm not sure that it is a good idea to
only
reject the multiple default blocks but keep the ability to have the same
case multiple times:
On Wed, Aug 13, 2014 at 12:57:40PM +0200, Ferenc Kovacs wrote:
On Wed, Aug 13, 2014 at 11:42 AM, Andrea Faulds a...@ajf.me wrote:
Hi!
On 13 Aug 2014, at 08:47, Ferenc Kovacs tyr...@gmail.com wrote:
and I also think that this isn't an important enough issue to warrant a
BC
break
Ferenc Kovacs wrote (on 13/08/2014):
agree, and I thought about mentioning that, but I left that out,
because I'm not proposing to remove that ability (and I see more
use-cases for that as mentioned in my previous email) but stating that
this patch would make an arbitrary distinction between
On Wed, Aug 13, 2014 at 2:27 PM, Rowan Collins rowan.coll...@gmail.com
wrote:
Ferenc Kovacs wrote (on 13/08/2014):
agree, and I thought about mentioning that, but I left that out, because
I'm not proposing to remove that ability (and I see more use-cases for that
as mentioned in my previous
On Wed, Aug 13, 2014 at 2:42 PM, Ferenc Kovacs tyr...@gmail.com wrote:
On Wed, Aug 13, 2014 at 2:27 PM, Rowan Collins rowan.coll...@gmail.com
wrote:
Ferenc Kovacs wrote (on 13/08/2014):
agree, and I thought about mentioning that, but I left that out, because
I'm not proposing to remove
Ferenc Kovacs wrote (on 13/08/2014):
not sure what do you mean here, multiple default cases can be reached the
same way as any other duplicated case branch(as shown in my snippet in the
mail you replied to).
If you're talking about http://3v4l.org/eZdPU then those duplicates are
definitely
Ferenc Kovacs wrote (on 13/08/2014):
Btw. I've added a comment to https://bugs.php.net/bug.php?id=67757 as
I've found some really weird behavior for multiple defaults and I
think that it would be better to try to figure out and fix why do we
pick the last default in the problematic snippet
On Wed, Aug 13, 2014 at 2:52 PM, Rowan Collins rowan.coll...@gmail.com
wrote:
Ferenc Kovacs wrote (on 13/08/2014):
not sure what do you mean here, multiple default cases can be reached the
same way as any other duplicated case branch(as shown in my snippet in the
mail you replied to).
If
On Wed, Aug 13, 2014 at 2:58 PM, Rowan Collins rowan.coll...@gmail.com
wrote:
Ferenc Kovacs wrote (on 13/08/2014):
Btw. I've added a comment to https://bugs.php.net/bug.php?id=67757 as
I've found some really weird behavior for multiple defaults and I think
that it would be better to try to
Ferenc Kovacs wrote (on 13/08/2014):
It is not selecting the first default, it just never needs to look
for a default, because it has already found a matching case label.
yes, and it continues the execution from the first matching case and
correctly evaluates the following defaults,
On Wed, Aug 13, 2014 at 3:42 PM, Rowan Collins rowan.coll...@gmail.com
wrote:
Ferenc Kovacs wrote (on 13/08/2014):
It is not selecting the first default, it just never needs to look
for a default, because it has already found a matching case label.
yes, and it continues the
Ferenc Kovacs wrote (on 13/08/2014):
I think you misunderstood that part, I was thinking about a state
machine like this:
1. function doStuff(){
2. switch($state){
3. case OPENDOOR:
4. if(!opendoor()){
5. break;
6. }
7. $state = SITDOWN;
8. case SITDOWN:
9. if(!sitdown()){
On Wed, Aug 13, 2014 at 3:55 PM, Rowan Collins rowan.coll...@gmail.com
wrote:
Ferenc Kovacs wrote (on 13/08/2014):
I think you misunderstood that part, I was thinking about a state machine
like this:
1. function doStuff(){
2. switch($state){
3. case OPENDOOR:
4. if(!opendoor()){
5.
Even if it is fall through that is causing the behavior it still is a
syntax that no longer will be considered valid in a minor release - and
seemingly in a point release as well if everyone had their way here. [:
Not that I consider code likehttp://3v4l.org/ http://3v4l.org/mtG4KmtG4K
Hi
2014-08-13 13:02 GMT+02:00 Ferenc Kovacs tyr...@gmail.com:
agree, and I thought about mentioning that, but I left that out, because
I'm not proposing to remove that ability (and I see more use-cases for that
as mentioned in my previous email) but stating that this patch would make
an
On Wed, Aug 13, 2014 at 5:20 PM, Kalle Sommer Nielsen ka...@php.net wrote:
Hi
2014-08-13 13:02 GMT+02:00 Ferenc Kovacs tyr...@gmail.com:
agree, and I thought about mentioning that, but I left that out, because
I'm not proposing to remove that ability (and I see more use-cases for
that
I woke up to this thread, and at first I thought:
Oh, some actual discussion, maybe we should stop the vote after all
and give it some time...
One or two minor points here...
And there's the bike shed.
For my own sanity, I'm going to leave this to the people who care
about the import things like
On Wed, Aug 13, 2014 at 5:42 PM, Sara Golemon poll...@php.net wrote:
I woke up to this thread, and at first I thought:
Oh, some actual discussion, maybe we should stop the vote after all
and give it some time...
One or two minor points here...
And there's the bike shed.
For my own sanity,
On Wed, Aug 13, 2014 at 3:24 AM, Peter Cowburn petercowb...@gmail.com
wrote:
My thoughts on the topic? I think we're in danger of letting process get
in our way here. It's a bug fix which IMHO should even be thrown into 5.6
(this is a bug fix!). Going through the RFC process, being forced to
On 6 August 2014 12:32, Ferenc Kovacs tyr...@gmail.com wrote:
I'm not sure what would be the best solution, but if we don't version the
spec, then when we introduce BC breaks or simply new features in a new
version which is in turn get's added to the spec, that would make the older
php
On Wed, Aug 13, 2014 at 3:21 PM, Drew Paroski drewparo...@gmail.com wrote:
On 6 August 2014 12:32, Ferenc Kovacs tyr...@gmail.com wrote:
I'm not sure what would be the best solution, but if we don't version the
spec, then when we introduce BC breaks or simply new features in a new
Hi!
And this, which is completely undetectable at parse time:
$bar = 30;
// ... arbitrary amount of code
switch ( $foo ) {
case $bar:
case 30:
}
That's not all. You can also do:
switch (true) {
case foo($bar):
...
case baz($quz, $qux):
...
}
and this is a completely
yet another stupid implementation driven behavior :)
+1 for master.
Thanks. Dmitry.
On Wed, Aug 6, 2014 at 9:31 AM, Sebastian Bergmann sebast...@php.net
wrote:
Am 06.08.2014 um 06:38 schrieb Sara Golemon:
https://wiki.php.net/rfc/switch.default.multiple
Makes sense to me; +1.
--
PHP
On Wed, Aug 6, 2014 at 10:57 AM, Dmitry Stogov dmi...@zend.com wrote:
yet another stupid implementation driven behavior :)
+1 for master.
Thanks. Dmitry.
Yep, definitely yes +1.
Julien.Pauli
On Wed, Aug 6, 2014 at 6:38 AM, Sara Golemon poll...@php.net wrote:
https://wiki.php.net/rfc/switch.default.multiple
'Cause this code is silly (even if it had case blocks), but we allow it:
switch ($expr) {
default:
notExecuted();
break;
default:
executed();
}
--
PHP
Ferenc Kovacs wrote (on 06/08/2014):
Hi,
I think dropping this behavior is a good idea, but I'm confused by the
reasoning related to the langspec.
This rfc targets php.next (which is a safe move as this has BC break albeit
would require some questionable code), but the langspec was agreed to be
On Wed, Aug 6, 2014 at 12:16 PM, Rowan Collins rowan.coll...@gmail.com wrote:
Ferenc Kovacs wrote (on 06/08/2014):
Hi,
I think dropping this behavior is a good idea, but I'm confused by the
reasoning related to the langspec.
This rfc targets php.next (which is a safe move as this has BC
On 06/08/14 11:16, Rowan Collins wrote:
According to the bug report, HHVM also accepts multiple default blocks,
but uses the first rather than the last. It's probably not worth
implementing specific code there to take the last default label just in
order to adhere to a 5.6 spec, but is worth
Lester Caine wrote (on 06/08/2014):
On 06/08/14 11:16, Rowan Collins wrote:
According to the bug report, HHVM also accepts multiple default blocks,
but uses the first rather than the last. It's probably not worth
implementing specific code there to take the last default label just in
order to
On Wed, Aug 6, 2014 at 3:00 AM, Ferenc Kovacs tyr...@gmail.com wrote:
I think dropping this behavior is a good idea, but I'm confused by the
reasoning related to the langspec.
This rfc targets php.next (which is a safe move as this has BC break albeit
would require some questionable code), but
On Wed, Aug 6, 2014 at 8:35 PM, Sara Golemon poll...@php.net wrote:
On Wed, Aug 6, 2014 at 3:00 AM, Ferenc Kovacs tyr...@gmail.com wrote:
I think dropping this behavior is a good idea, but I'm confused by the
reasoning related to the langspec.
This rfc targets php.next (which is a safe
On 6 August 2014 12:32, Ferenc Kovacs tyr...@gmail.com wrote:
On Wed, Aug 6, 2014 at 8:35 PM, Sara Golemon poll...@php.net wrote:
Did we agree on that? The lang spec was originally written to 5.6 to
have a relatively stable target, but (in my mind at least) was meant
to track master as we
https://wiki.php.net/rfc/switch.default.multiple
'Cause this code is silly (even if it had case blocks), but we allow it:
switch ($expr) {
default:
notExecuted();
break;
default:
executed();
}
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:
Am 06.08.2014 um 06:38 schrieb Sara Golemon:
https://wiki.php.net/rfc/switch.default.multiple
Makes sense to me; +1.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
47 matches
Mail list logo
